linux-toradex.git/net/key, branch v2.6.22.9

xfrm: Add security check before flushing SAD/SPD

2007-06-07T20:42:46+00:00

Currently we check for permission before deleting entries from SAD and
SPD, (see security_xfrm_policy_delete() security_xfrm_state_delete())
However we are not checking for authorization when flushing the SPD and
the SAD completely. It was perhaps missed in the original security hooks
patch.

This patch adds a security check when flushing entries from the SAD and
SPD.  It runs the entire database and checks each entry for a denial.
If the process attempting the flush is unable to remove all of the
entries a denial is logged the the flush function returns an error
without removing anything.

This is particularly useful when a process may need to create or delete
its own xfrm entries used for things like labeled networking but that
same process should not be able to delete other entries or flush the
entire database.

Signed-off-by: Joy Latten
Signed-off-by: Eric Paris 
Signed-off-by: James Morris

[IPSEC] pfkey: Load specific algorithm in pfkey_add rather than all

2007-05-19T21:21:18+00:00

This is a natural extension of the changeset

    [XFRM]: Probe selected algorithm only.

which only removed the probe call for xfrm_user.  This patch does exactly
the same thing for af_key.  In other words, we load the algorithm requested
by the user rather than everything when adding xfrm states in af_key.

Signed-off-by: Herbert Xu 
Signed-off-by: David S. Miller

[NET]: cleanup extra semicolons

2007-04-26T05:29:24+00:00

Spring cleaning time...

There seems to be a lot of places in the network code that have
extra bogus semicolons after conditionals.  Most commonly is a
bogus semicolon after: switch() { }

Signed-off-by: Stephen Hemminger 
Signed-off-by: David S. Miller

[SK_BUFF]: Introduce skb_reset_transport_header(skb)

2007-04-26T05:25:15+00:00

For the common, open coded 'skb->h.raw = skb->data' operation, so that we can
later turn skb->h.raw into a offset, reducing the size of struct sk_buff in
64bit land while possibly keeping it as a pointer on 32bit.

This one touches just the most simple cases:

skb->h.raw = skb->data;
skb->h.raw = {skb_push|[__]skb_pull}()

The next ones will handle the slightly more "complex" cases.

Signed-off-by: Arnaldo Carvalho de Melo 
Signed-off-by: David S. Miller

[IPSEC] af_key: Fix thinko in pfkey_xfrm_policy2msg()

2007-04-18T21:16:07+00:00

Make sure to actually assign the determined mode to
rq->sadb_x_ipsecrequest_mode.

Noticed by Joe Perches.

Signed-off-by: David S. Miller

[KEY]: Fix conversion between IPSEC_MODE_xxx and XFRM_MODE_xxx.

2007-04-17T20:13:21+00:00

We should not blindly convert between IPSEC_MODE_xxx and XFRM_MODE_xxx just
by incrementing / decrementing because the assumption is not true any longer.

Signed-off-by: Kazunori MIYAZAWA 
Singed-off-by: YOSHIFUJI Hideaki

[IPSEC]: xfrm audit hook misplaced in pfkey_delete and xfrm_del_sa

2007-03-08T00:08:11+00:00

Inside pfkey_delete and xfrm_del_sa the audit hooks were not called if
there was any permission/security failures in attempting to do the del
operation (such as permission denied from security_xfrm_state_delete).
This patch moves the audit hook to the exit path such that all failures
(and successes) will actually get audited.

Signed-off-by: Eric Paris 
Acked-by: Venkat Yekkirala 
Acked-by: James Morris 
Signed-off-by: David S. Miller

[IPSEC]: Add xfrm policy change auditing to pfkey_spdget

2007-03-08T00:08:10+00:00

pfkey_spdget neither had an LSM security hook nor auditing for the
removal of xfrm_policy structs.  The security hook was added when it was
moved into xfrm_policy_byid instead of the callers to that function by
my earlier patch and this patch adds the auditing hooks as well.

Signed-off-by: Eric Paris 
Acked-by: Venkat Yekkirala 
Acked-by: James Morris 
Signed-off-by: David S. Miller

[IPSEC]: xfrm_policy delete security check misplaced

2007-03-08T00:08:09+00:00

The security hooks to check permissions to remove an xfrm_policy were
actually done after the policy was removed.  Since the unlinking and
deletion are done in xfrm_policy_by* functions this moves the hooks
inside those 2 functions.  There we have all the information needed to
do the security check and it can be done before the deletion.  Since
auditing requires the result of that security check err has to be passed
back and forth from the xfrm_policy_by* functions.

This patch also fixes a bug where a deletion that failed the security
check could cause improper accounting on the xfrm_policy
(xfrm_get_policy didn't have a put on the exit path for the hold taken
by xfrm_policy_by*)

It also fixes the return code when no policy is found in
xfrm_add_pol_expire.  In old code (at least back in the 2.6.18 days) err
wasn't used before the return when no policy is found and so the
initialization would cause err to be ENOENT.  But since err has since
been used above when we don't get a policy back from the xfrm_policy_by*
function we would always return 0 instead of the intended ENOENT.  Also
fixed some white space damage in the same area.

Signed-off-by: Eric Paris 
Acked-by: Venkat Yekkirala 
Acked-by: James Morris 
Signed-off-by: David S. Miller

[XFRM]: Fix OOPSes in xfrm_audit_log().

2007-02-12T21:53:54+00:00

Make sure that this function is called correctly, and
add BUG() checking to ensure the arguments are sane.

Based upon a patch by Joy Latten.

Signed-off-by: David S. Miller