linux-toradex.git/net/l2tp, branch v2.6.36-rc7 Linux kernel for Apalis and Colibri modules l2tp: test for ethernet header in l2tp_eth_dev_recv() 2010-08-26T20:29:38+00:00 Eric Dumazet eric.dumazet@gmail.com 2010-08-25T23:44:35+00:00 bfc960a8eec023a170a80697fe65157cd4f44f81 close https://bugzilla.kernel.org/show_bug.cgi?id=16529 Before calling dev_forward_skb(), we should make sure skb head contains at least an ethernet header, even if length included in upper layer said so. Use pskb_may_pull() to make sure this ethernet header is present in skb head. Reported-by: Thomas Heil <heil@terminal-consulting.de> Reported-by: Ian Campbell <Ian.Campbell@eu.citrix.com> Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com> Signed-off-by: David S. Miller <davem@davemloft.net> 
close https://bugzilla.kernel.org/show_bug.cgi?id=16529

Before calling dev_forward_skb(), we should make sure skb head contains
at least an ethernet header, even if length included in upper layer said
so. Use pskb_may_pull() to make sure this ethernet header is present in
skb head.

Reported-by: Thomas Heil <heil@terminal-consulting.de>
Reported-by: Ian Campbell <Ian.Campbell@eu.citrix.com>
Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
ppp: make channel_ops const 2010-08-05T04:53:17+00:00 stephen hemminger shemminger@vyatta.com 2010-08-04T07:34:36+00:00 d7100da026317fcf07411f765fe1cdb044053917 The PPP channel ops structure should be const. Cleanup the declarations to use standard C99 format. Signed-off-by: Stephen Hemminger <shemminger@vyatta.com> Signed-off-by: David S. Miller <davem@davemloft.net> 
The PPP channel ops structure should be const.
Cleanup the declarations to use standard C99 format.

Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net-next: remove useless union keyword 2010-06-11T06:31:35+00:00 Changli Gao xiaosuo@gmail.com 2010-06-11T06:31:35+00:00 d8d1f30b95a635dbd610dcc5eb641aca8f4768cf remove useless union keyword in rtable, rt6_info and dn_route. Since there is only one member in a union, the union keyword isn't useful. Signed-off-by: Changli Gao <xiaosuo@gmail.com> Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com> Signed-off-by: David S. Miller <davem@davemloft.net> 
remove useless union keyword in rtable, rt6_info and dn_route.

Since there is only one member in a union, the union keyword isn't useful.

Signed-off-by: Changli Gao <xiaosuo@gmail.com>
Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
l2tp_eth: fix memory allocation 2010-04-23T23:37:33+00:00 Jiri Pirko jpirko@redhat.com 2010-04-23T01:01:52+00:00 3a737028630bb3c2b9efc38b9ddef2e09b06b808 Since .size is set properly in "struct pernet_operations l2tp_eth_net_ops", allocating space for "struct l2tp_eth_net" by hand is not correct, even causes memory leakage. Signed-off-by: Jiri Pirko <jpirko@redhat.com> Signed-off-by: David S. Miller <davem@davemloft.net> 
Since .size is set properly in "struct pernet_operations l2tp_eth_net_ops",
allocating space for "struct l2tp_eth_net" by hand is not correct, even causes
memory leakage.

Signed-off-by: Jiri Pirko <jpirko@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
l2tp: fix memory allocation 2010-04-23T23:37:32+00:00 Jiri Pirko jpirko@redhat.com 2010-04-23T00:53:39+00:00 e773aaff8295e7f3428d9cf6f8a476a33de00716 Since .size is set properly in "struct pernet_operations l2tp_net_ops", allocating space for "struct l2tp_net" by hand is not correct, even causes memory leakage. Signed-off-by: Jiri Pirko <jpirko@redhat.com> Signed-off-by: David S. Miller <davem@davemloft.net> 
Since .size is set properly in "struct pernet_operations l2tp_net_ops",
allocating space for "struct l2tp_net" by hand is not correct, even causes
memory leakage.

Signed-off-by: Jiri Pirko <jpirko@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net: replace ipfragok with skb->local_df 2010-04-16T06:36:37+00:00 Shan Wei shanwei@cn.fujitsu.com 2010-04-15T16:43:08+00:00 4e15ed4d930297c127d280ca1d0c785be870def4 As Herbert Xu said: we should be able to simply replace ipfragok with skb->local_df. commit f88037(sctp: Drop ipfargok in sctp_xmit function) has droped ipfragok and set local_df value properly. The patch kills the ipfragok parameter of .queue_xmit(). Signed-off-by: Shan Wei <shanwei@cn.fujitsu.com> Signed-off-by: David S. Miller <davem@davemloft.net> 
As Herbert Xu said: we should be able to simply replace ipfragok
with skb->local_df. commit f88037(sctp: Drop ipfargok in sctp_xmit function)
has droped ipfragok and set local_df value properly.

The patch kills the ipfragok parameter of .queue_xmit().

Signed-off-by: Shan Wei <shanwei@cn.fujitsu.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/l2tp/l2tp_debugfs.c: Convert NIPQUAD to %pI4 2010-04-15T22:37:13+00:00 Joe Perches joe@perches.com 2010-04-15T22:37:13+00:00 a4fbf8415c462208e77251779d80dbc81914cebd Signed-off-by: Joe Perches <joe@perches.com> Acked-by: James Chapman <jchapman@katalix.com> Signed-off-by: David S. Miller <davem@davemloft.net> 
Signed-off-by: Joe Perches <joe@perches.com>
Acked-by: James Chapman <jchapman@katalix.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
l2tp: unmanaged L2TPv3 tunnels fixes 2010-04-04T08:02:46+00:00 Eric Dumazet eric.dumazet@gmail.com 2010-04-04T08:02:46+00:00 7bddd0db6248d92adb1f547fd45507af4368d6fa Followup to commit 789a4a2c (l2tp: Add support for static unmanaged L2TPv3 tunnels) One missing init in l2tp_tunnel_sock_create() could access random kernel memory, and a bit field should be unsigned. Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com> Signed-off-by: David S. Miller <davem@davemloft.net> 
Followup to commit 789a4a2c 
(l2tp: Add support for static unmanaged L2TPv3 tunnels)

One missing init in l2tp_tunnel_sock_create() could access random kernel
memory, and a bit field should be unsigned.

Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
l2tp: Fix L2TP_DEBUGFS ifdef tests. 2010-04-03T22:01:37+00:00 David S. Miller davem@davemloft.net 2010-04-03T22:01:37+00:00 f66ef2d0649b220874532dfb83b6b5b368f83591 We have to check CONFIG_L2TP_DEBUGFS_MODULE as well as CONFIG_L2TP_DEBUGFS. Signed-off-by: David S. Miller <davem@davemloft.net> 
We have to check CONFIG_L2TP_DEBUGFS_MODULE as well as
CONFIG_L2TP_DEBUGFS.

Signed-off-by: David S. Miller <davem@davemloft.net>
l2tp: Add missing semicolon to MODULE_ALIAS() in l2tp_netlink.c 2010-04-03T21:58:07+00:00 David S. Miller davem@davemloft.net 2010-04-03T21:58:07+00:00 f481c0d86227156fb1691b166a11c3f0058e1cb2 Signed-off-by: David S. Miller <davem@davemloft.net> 
Signed-off-by: David S. Miller <davem@davemloft.net>