linux-toradex.git/net/llc/llc_station.c, branch v4.9.3

llc2: Collapse remainder of state machine into simple if-else if-statement

2012-09-17T17:04:19+00:00

Signed-off-by: Ben Hutchings 
Signed-off-by: David S. Miller

llc2: Remove explicit indexing of state action arrays

2012-09-17T17:04:19+00:00

These arrays are accessed by iteration in
llc_exec_station_trans_actions().  There must not be any zero-filled
gaps in them, so the explicit indices are pointless.

Signed-off-by: Ben Hutchings 
Signed-off-by: David S. Miller

llc2: Remove the station send queue

2012-09-17T17:04:18+00:00

We only ever put one skb on the send queue, and then immediately
send it.  Remove the queue and call dev_queue_xmit() directly.

This leaves struct llc_station empty, so remove that as well.

Signed-off-by: Ben Hutchings 
Signed-off-by: David S. Miller

llc2: Collapse the station event receive path

2012-09-17T17:04:18+00:00

We only ever put one skb on the event queue, and then immediately
process it.  Remove the queue and fold together the related functions,
removing several blatantly false comments.

Signed-off-by: Ben Hutchings 
Signed-off-by: David S. Miller

llc2: Remove dead code for state machine

2012-09-17T17:04:18+00:00

The initial state is UP and there is no way to enter the other states
as the required event type is never generated.  Delete all states,
event types, and other dead code.  The only thing left is handling
of the XID and TEST commands.

Signed-off-by: Ben Hutchings 
Signed-off-by: David S. Miller

llc2: Remove pointless indirection through llc_stat_state_trans_end

2012-09-17T17:04:18+00:00

Signed-off-by: Ben Hutchings 
Signed-off-by: David S. Miller

llc: Fix races between llc2 handler use and (un)registration

2012-08-14T23:52:02+00:00

When registering the handlers, any state they rely on must be
completely initialised first.  When unregistering, we must wait until
they are definitely no longer running.  llc_rcv() must also avoid
reading the handler pointers again after checking for NULL.

Signed-off-by: Ben Hutchings 
Signed-off-by: David S. Miller

llc2: Call llc_station_exit() on llc2_init() failure path

2012-08-14T23:51:40+00:00

Otherwise the station packet handler will remain registered even though
the module is unloaded.

Signed-off-by: Ben Hutchings 
Signed-off-by: David S. Miller

llc2: Fix silent failure of llc_station_init()

2012-08-14T23:51:18+00:00

llc_station_init() creates and processes an event skb with no effect
other than to change the state from DOWN to UP.  Allocation failure is
reported, but then ignored by its caller, llc2_init().  Remove this
possibility by simply initialising the state as UP.

Signed-off-by: Ben Hutchings 
Signed-off-by: David S. Miller

llc: free the right skb

2012-08-06T20:30:01+00:00

We are freeing skb instead of nskb, resulting in a double
free on skb and a leak from nskb.

Signed-off-by: Sorin Dumitru 
Signed-off-by: David S. Miller