linux-toradex.git/net/mac80211/agg-rx.c, branch v3.11.9

mac80211: improve aggregation debug messages

2013-01-18T20:55:15+00:00

A lot of the aggregation messages don't indicate the
station so they're hard to understand if there are
multiple sessions in progress. Make that easier by
adding the MAC address to most messages. Also add
the TID if it wasn't already there.

Signed-off-by: Johannes Berg

mac80211: introduce IEEE80211_NUM_TIDS and use it

2012-11-19T14:44:00+00:00

Introduce IEEE80211_NUM_TIDS in the generic 802.11
header file and use it in place of STA_TID_NUM and
NUM_RX_DATA_QUEUES which are both really the number
of TIDs.

Signed-off-by: Johannes Berg

mac80211: clean up debugging

2012-06-24T09:32:29+00:00

There are a few things that make the logging and
debugging in mac80211 less useful than it should
be right now:
 * a lot of messages should be pr_info, not pr_debug
 * wholesale use of pr_debug makes it require *both*
   Kconfig and dynamic configuration
 * there are still a lot of ifdefs
 * the style is very inconsistent, sometimes the
   sdata->name is printed in front

Clean up everything, introducing new macros and
separating out the station MLME debugging into
a new Kconfig symbol.

Signed-off-by: Johannes Berg

Merge branch 'master' of git://git.kernel.org/pub/scm/linux/kernel/git/linville/wireless

2012-06-06T18:40:06+00:00

Conflicts:
	drivers/net/wireless/iwlwifi/iwl-drv.c

net: mac80211: Add and use ht_vdbg debugging macro

2012-06-05T19:32:10+00:00

Simplify the use of #ifdef CONFIG_MAC80211_HT_DEBUG/#endif
by adding a logging macro to encapsulate the test.

Convert the appropriate uses too.

Signed-off-by: Joe Perches 
Signed-off-by: John W. Linville

net: mac80211: Convert printk(KERN_DEBUG to pr_debug

2012-06-05T19:27:16+00:00

Standardize the debugging to be able to use dynamic_debug.

Coalesce formats, align arguments.

Signed-off-by: Joe Perches 
Signed-off-by: John W. Linville

mac80211: add missing rcu_read_lock/unlock in agg-rx session timer

2012-06-04T19:25:41+00:00

Fixes a lockdep warning:

===================================================
[ INFO: suspicious rcu_dereference_check() usage. ]
---------------------------------------------------
net/mac80211/agg-rx.c:148 invoked rcu_dereference_check() without protection!

other info that might help us debug this:

rcu_scheduler_active = 1, debug_locks = 1
1 lock held by arecord/11226:
 #0:  (&tid_agg_rx->session_timer){+.-...}, at: [] call_timer_fn+0x0/0x360

stack backtrace:
Pid: 11226, comm: arecord Not tainted 3.1.0-kml #16
Call Trace:
   [] lockdep_rcu_dereference+0xa4/0xc0
 [] sta_rx_agg_session_timer_expired+0xc9/0x110 [mac80211]
 [] ? ieee80211_process_addba_resp+0x220/0x220 [mac80211]
 [] call_timer_fn+0x8a/0x360
 [] ? init_timer_deferrable_key+0x30/0x30
 [] ? _raw_spin_unlock_irq+0x30/0x70
 [] run_timer_softirq+0x139/0x310
 [] ? put_lock_stats.isra.25+0xe/0x40
 [] ? lock_release_holdtime.part.26+0xdc/0x160
 [] ? ieee80211_process_addba_resp+0x220/0x220 [mac80211]
 [] __do_softirq+0xc8/0x3c0
 [] ? tick_dev_program_event+0x48/0x110
 [] ? tick_program_event+0x1f/0x30
 [] ? putname+0x35/0x50
 [] call_softirq+0x1c/0x30
 [] do_softirq+0xa5/0xe0
 [] irq_exit+0xae/0xe0
 [] smp_apic_timer_interrupt+0x6b/0x98
 [] apic_timer_interrupt+0x73/0x80
   [] ? free_debug_processing+0x1a1/0x1d5
 [] ? putname+0x35/0x50
 [] __slab_free+0x31/0x2ca
 [] ? _raw_spin_unlock_irqrestore+0x4a/0x90
 [] ? __debug_check_no_obj_freed+0x15f/0x210
 [] ? lock_release_nested+0x84/0xc0
 [] ? kmem_cache_free+0x105/0x250
 [] ? putname+0x35/0x50
 [] ? putname+0x35/0x50
 [] kmem_cache_free+0x23f/0x250
 [] putname+0x35/0x50
 [] do_sys_open+0x16d/0x1d0
 [] sys_open+0x20/0x30
 [] system_call_fastpath+0x16/0x1b

Reported-by: Johannes Berg 
Signed-off-by: Felix Fietkau 
Signed-off-by: John W. Linville

net: Convert net_ratelimit uses to net__ratelimited

2012-05-15T17:45:03+00:00

Standardize the net core ratelimited logging functions.

Coalesce formats, align arguments.
Change a printk then vprintk sequence to use printf extension %pV.

Signed-off-by: Joe Perches 
Signed-off-by: David S. Miller

mac80211: optimize aggregation session timeout handling

2012-04-09T20:09:36+00:00

Calling mod_timer from the rx/tx hotpath is somewhat expensive, and the
timeout doesn't need to be so precise.

Switch to a different strategy: Schedule the timer initially, store jiffies
of all last rx/tx activity which would previously modify the timer, and
let the timer re-arm itself after checking the last rx/tx timestamp.
Make the session timers deferrable to avoid causing extra wakeups on systems
running on battery.
This visibly reduces CPU load under high network load on small embedded
systems.

Signed-off-by: Felix Fietkau 
Signed-off-by: John W. Linville

mac80211: fix possible tid_rx->reorder_timer use after free

2012-03-26T19:07:29+00:00

Is possible that we will arm the tid_rx->reorder_timer after
del_timer_sync() in ___ieee80211_stop_rx_ba_session(). We need to stop
timer after RCU grace period finish, so move it to
ieee80211_free_tid_rx(). Timer will not be armed again, as
rcu_dereference(sta->ampdu_mlme.tid_rx[tid]) will return NULL.

Debug object detected problem with the following warning:
ODEBUG: free active (active state 0) object type: timer_list hint: sta_rx_agg_reorder_timer_expired+0x0/0xf0 [mac80211]

Bug report (with all warning messages):
https://bugzilla.redhat.com/show_bug.cgi?id=804007

Reported-by: "jan p. springer" 
Cc: stable@vger.kernel.org
Signed-off-by: Stanislaw Gruszka 
Signed-off-by: John W. Linville