linux-toradex.git/net/mac80211, branch v3.1

mac80211: fix missing sta_lock in __sta_info_destroy

2011-09-13T18:18:38+00:00

Since my commit 34e895075e21be3e21e71d6317440d1ee7969ad0
("mac80211: allow station add/remove to sleep") there is
a race in mac80211 when it clears the TIM bit because a
sleeping station disconnected, the spinlock isn't held
around the relevant code any more. Use the right API to
acquire the spinlock correctly.

Cc: stable@kernel.org [2.6.34+]
Signed-off-by: Johannes Berg 
Signed-off-by: John W. Linville

mac80211: fix suspend/resume races with unregister hw

2011-08-22T18:21:40+00:00

Do not call ->suspend, ->resume methods after we unregister wiphy. Also
delete sta_clanup timer after we finish wiphy unregister to avoid this:

WARNING: at lib/debugobjects.c:262 debug_print_object+0x85/0xa0()
Hardware name: 6369CTO
ODEBUG: free active (active state 0) object type: timer_list hint: sta_info_cleanup+0x0/0x180 [mac80211]
Modules linked in: aes_i586 aes_generic fuse bridge stp llc autofs4 sunrpc cpufreq_ondemand acpi_cpufreq mperf ext2 dm_mod uinput thinkpad_acpi hwmon sg arc4 rt2800usb rt2800lib crc_ccitt rt2x00usb rt2x00lib mac80211 cfg80211 i2c_i801 iTCO_wdt iTCO_vendor_support e1000e ext4 mbcache jbd2 sd_mod crc_t10dif sr_mod cdrom yenta_socket ahci libahci pata_acpi ata_generic ata_piix i915 drm_kms_helper drm i2c_algo_bit video [last unloaded: microcode]
Pid: 5663, comm: pm-hibernate Not tainted 3.1.0-rc1-wl+ #19
Call Trace:
 [] warn_slowpath_common+0x6d/0xa0
 [] ? debug_print_object+0x85/0xa0
 [] ? debug_print_object+0x85/0xa0
 [] warn_slowpath_fmt+0x2e/0x30
 [] debug_print_object+0x85/0xa0
 [] ? sta_info_alloc+0x1a0/0x1a0 [mac80211]
 [] debug_check_no_obj_freed+0xe2/0x180
 [] kfree+0x8b/0x150
 [] cfg80211_dev_free+0x7e/0x90 [cfg80211]
 [] wiphy_dev_release+0xd/0x10 [cfg80211]
 [] device_release+0x19/0x80
 [] kobject_release+0x7a/0x1c0
 [] ? rtnl_unlock+0x8/0x10
 [] ? wiphy_resume+0x6b/0x80 [cfg80211]
 [] ? kobject_del+0x30/0x30
 [] kref_put+0x2d/0x60
 [] kobject_put+0x1d/0x50
 [] ? mutex_lock+0x14/0x40
 [] put_device+0xf/0x20
 [] dpm_resume+0xca/0x160
 [] hibernation_snapshot+0xcd/0x260
 [] ? freeze_processes+0x3f/0x90
 [] hibernate+0xcb/0x1e0
 [] ? pm_async_store+0x40/0x40
 [] state_store+0xa0/0xb0
 [] ? pm_async_store+0x40/0x40
 [] kobj_attr_store+0x20/0x30
 [] sysfs_write_file+0x94/0xf0
 [] vfs_write+0x9a/0x160
 [] ? sysfs_open_file+0x200/0x200
 [] sys_write+0x3d/0x70
 [] sysenter_do_call+0x12/0x28

Cc: stable@kernel.org
Signed-off-by: Stanislaw Gruszka 
Signed-off-by: John W. Linville

net: Audit drivers to identify those needing IFF_TX_SKB_SHARING cleared

2011-07-28T05:39:30+00:00

After the last patch, We are left in a state in which only drivers calling
ether_setup have IFF_TX_SKB_SHARING set (we assume that drivers touching real
hardware call ether_setup for their net_devices and don't hold any state in
their skbs.  There are a handful of drivers that violate this assumption of
course, and need to be fixed up.  This patch identifies those drivers, and marks
them as not being able to support the safe transmission of skbs by clearning the
IFF_TX_SKB_SHARING flag in priv_flags

Signed-off-by: Neil Horman 
CC: Karsten Keil 
CC: "David S. Miller" 
CC: Jay Vosburgh 
CC: Andy Gospodarek 
CC: Patrick McHardy 
CC: Krzysztof Halasa 
CC: "John W. Linville" 
CC: Greg Kroah-Hartman 
CC: Marcel Holtmann 
CC: Johannes Berg 
Signed-off-by: David S. Miller

Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/jikos/trivial

2011-07-25T20:56:39+00:00

* 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/jikos/trivial: (43 commits)
  fs: Merge split strings
  treewide: fix potentially dangerous trailing ';' in #defined values/expressions
  uwb: Fix misspelling of neighbourhood in comment
  net, netfilter: Remove redundant goto in ebt_ulog_packet
  trivial: don't touch files that are removed in the staging tree
  lib/vsprintf: replace link to Draft by final RFC number
  doc: Kconfig: `to be' -> `be'
  doc: Kconfig: Typo: square -> squared
  doc: Konfig: Documentation/power/{pm => apm-acpi}.txt
  drivers/net: static should be at beginning of declaration
  drivers/media: static should be at beginning of declaration
  drivers/i2c: static should be at beginning of declaration
  XTENSA: static should be at beginning of declaration
  SH: static should be at beginning of declaration
  MIPS: static should be at beginning of declaration
  ARM: static should be at beginning of declaration
  rcu: treewide: Do not use rcu_read_lock_held when calling rcu_dereference_check
  Update my e-mail address
  PCIe ASPM: forcedly -> forcibly
  gma500: push through device driver tree
  ...

Fix up trivial conflicts:
 - arch/arm/mach-ep93xx/dma-m2p.c (deleted)
 - drivers/gpio/gpio-ep93xx.c (renamed and context nearby)
 - drivers/net/r8169.c (just context changes)

treewide: fix potentially dangerous trailing ';' in #defined values/expressions

2011-07-21T12:10:00+00:00

All these are instances of
  #define NAME value;
or
  #define NAME(params_opt) value;

These of course fail to build when used in contexts like
  if(foo $OP NAME)
  while(bar $OP NAME)
and may silently generate the wrong code in contexts such as
  foo = NAME + 1;    /* foo = value; + 1; */
  bar = NAME - 1;    /* bar = value; - 1; */
  baz = NAME & quux; /* baz = value; & quux; */

Reported on comp.lang.c,
Message-ID: 
Initial analysis of the dangers provided by Keith Thompson in that thread.

There are many more instances of more complicated macros having unnecessary
trailing semicolons, but this pile seems to be all of the cases of simple
values suffering from the problem. (Thus things that are likely to be found
in one of the contexts above, more complicated ones aren't.)

Signed-off-by: Phil Carmody 
Signed-off-by: Jiri Kosina

mac80211: check sta_info_get() return value

2011-07-20T19:04:36+00:00

ieee80211_stop_rx_ba_session() was calling sta_info_get()
without rcu locking, and the return value was not
checked.
This resulted in the following panic:

[] (ieee80211_stop_rx_ba_session+0x0/0x60 [mac80211])
[] (wl1271_event_handle+0x0/0xdc8 [wl12xx])
[] (wl1271_irq+0x0/0x4a0 [wl12xx])
[] (irq_thread+0x0/0x254)
[] (kthread+0x0/0x8c)

Signed-off-by: Eliad Peller 
Reviewed-by: Johannes Berg 
Signed-off-by: John W. Linville

mac80211: sync driver before TX

2011-07-20T19:04:35+00:00

In P2P client mode, the GO (AP) to connect to might
have periods of time where it is not available due
to powersave. To allow the driver to sync with it
and send frames to the GO only when it is available
add a new callback tx_sync (and the corresponding
finish_tx_sync). These callbacks can sleep unlike
the actual TX.

Signed-off-by: Johannes Berg 
Signed-off-by: John W. Linville

mac80211: implement scan supported rates

2011-07-19T20:50:00+00:00

Scanning currently uses the TX rate mask to
restrict the rate set, which is bogus. Make
it use the new set of rates from userspace.

Signed-off-by: Johannes Berg 
Signed-off-by: John W. Linville

mac80211: reconfigure tx on device reconfiguration

2011-07-18T18:29:03+00:00

Add tx_conf array to save the current tx queues
configuration, and reconfig it on resume (ieee80211_reconfig).

On resume, the driver is being reconfigured. Without
reconfiguring the tx queues as well, the driver might
configure the device to use wrong ac params (e.g. ps-poll
instead of uapsd).

Signed-off-by: Eliad Peller 
Signed-off-by: John W. Linville

mac80211: be more careful in suspend/resume

2011-07-15T17:39:42+00:00

When suspending with all netdevs down, the device
is stopped but we still call a number of driver
callbacks that the driver might not expect. The
same happens during resume, we might call a few
callbacks without starting the driver. Fix this
by checking open_count around more things and
exiting quickly if it is 0.

Also, while at this I noticed that the coverage
class isn't reprogrammed after resume, so add
that.

Signed-off-by: Johannes Berg 
Signed-off-by: John W. Linville