linux-toradex.git/net/netlink, branch v2.6.21.4

[NETLINK]: Don't attach callback to a going-away netlink socket

2007-04-19T00:05:58+00:00

There is a race between netlink_dump_start() and netlink_release()
that can lead to the situation when a netlink socket with non-zero
callback is freed.

Here it is:

CPU1:                           CPU2
netlink_release():              netlink_dump_start():

                                sk = netlink_lookup(); /* OK */

netlink_remove();

spin_lock(&nlk->cb_lock);
if (nlk->cb) { /* false */
  ...
}
spin_unlock(&nlk->cb_lock);

                                spin_lock(&nlk->cb_lock);
                                if (nlk->cb) { /* false */
                                         ...
                                }
                                nlk->cb = cb;
                                spin_unlock(&nlk->cb_lock);
                                ...
sock_orphan(sk);
/*
 * proceed with releasing
 * the socket
 */

The proposal it to make sock_orphan before detaching the callback
in netlink_release() and to check for the sock to be SOCK_DEAD in
netlink_dump_start() before setting a new callback.

Signed-off-by: Denis Lunev 
Signed-off-by: Kirill Korotaev 
Signed-off-by: Pavel Emelianov 
Acked-by: Patrick McHardy 
Signed-off-by: David S. Miller

[PATCH] mark struct file_operations const 8

2007-02-12T17:48:46+00:00

Many struct file_operations in the kernel can be "const".  Marking them const
moves these to the .rodata section, which avoids false sharing with potential
dirty data.  In addition it'll catch accidental writes at compile time to
these shared resources.

Signed-off-by: Arjan van de Ven 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

[NET] NETLINK: Fix whitespace errors.

2007-02-11T07:19:58+00:00

Signed-off-by: YOSHIFUJI Hideaki 
Signed-off-by: David S. Miller

[AF_NETLINK]: module_put cleanup

2007-01-04T02:38:15+00:00

This patch removes redundant argument check for module_put().

Signed-off-by: Mariusz Kozlowski 
Signed-off-by: David S. Miller

[PATCH] struct path: convert netlink

2006-12-08T16:28:48+00:00

Signed-off-by: Josef Sipek 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

[GENETLINK]: Fix misplaced command flags.

2006-12-07T04:06:25+00:00

The command flags for dump and do were swapped..

Signed-off-by: Jamal Hadi Salim 
Signed-off-by: David S. Miller

[GENETLINK]: Move command capabilities to flags.

2006-12-07T02:38:41+00:00

This patch moves command capabilities to command flags. Other than
being cleaner, saves several bytes.
We increment the nlctrl version so as to signal to user space that
to not expect the attributes. We will try to be careful
not to do this too often ;->

Signed-off-by: Jamal Hadi Salim 
Signed-off-by: David S. Miller

[GENETLINK]: Add cmd dump completion.

2006-12-03T05:32:09+00:00

Remove assumption that generic netlink commands cannot have dump
completion callbacks.

Signed-off-by: Jamal Hadi Salim 
Signed-off-by: David S. Miller

[NETLINK]: Remove unused dst_pid field in netlink_skb_parms

2006-12-03T05:30:43+00:00

The destination PID is passed directly to netlink_unicast()
respectively netlink_multicast().

Signed-off-by: Thomas Graf 
Signed-off-by: David S. Miller

[GENETLINK] ctrl: Avoid empty CTRL_ATTR_OPS attribute when dumping

2006-12-03T05:30:23+00:00

Based on Jamal's patch but compiled and even tested. :-)

Signed-off-by: Thomas Graf 
Signed-off-by: David S. Miller