linux-toradex.git/net/openvswitch/flow_table.c, branch v3.15-rc8

openvswitch: Fix ovs_flow_free() ovs-lock assert.

2014-02-05T06:21:45+00:00

ovs_flow_free() is not called under ovs-lock during packet
execute path (ovs_packet_cmd_execute()). Since packet execute
does not touch flow->mask, there is no need to take that
lock either. So move assert in case where flow->mask is checked.

Found by code inspection.

Signed-off-by: Pravin B Shelar 
Signed-off-by: Jesse Gross

openvswitch: Fix kernel panic on ovs_flow_free

2014-02-05T06:21:17+00:00

Both mega flow mask's reference counter and per flow table mask list
should only be accessed when holding ovs_mutex() lock. However
this is not true with ovs_flow_table_flush(). The patch fixes this bug.

Reported-by: Joe Stringer 
Signed-off-by: Andy Zhou 
Signed-off-by: Jesse Gross

openvswitch: Use kmem_cache_free() instead of kfree()

2014-01-09T19:26:39+00:00

memory allocated by kmem_cache_alloc() should be freed using
kmem_cache_free(), not kfree().

Fixes: e298e5057006 ('openvswitch: Per cpu flow stats.')
Signed-off-by: Wei Yongjun 
Acked-by: Jesse Gross 
Signed-off-by: David S. Miller

Merge branch 'master' of git://git.kernel.org/pub/scm/linux/kernel/git/jesse/openvswitch

2014-01-07T00:48:38+00:00

Jesse Gross says:

====================
[GIT net-next] Open vSwitch

Open vSwitch changes for net-next/3.14. Highlights are:
 * Performance improvements in the mechanism to get packets to userspace
   using memory mapped netlink and skb zero copy where appropriate.
 * Per-cpu flow stats in situations where flows are likely to be shared
   across CPUs. Standard flow stats are used in other situations to save
   memory and allocation time.
 * A handful of code cleanups and rationalization.
====================

Signed-off-by: David S. Miller

openvswitch: remove duplicated include from flow_table.c

2014-01-06T23:52:35+00:00

Remove duplicated include.

Signed-off-by: Wei Yongjun 
Signed-off-by: Jesse Gross

net: ovs: use kfree_rcu instead of rcu_free_{sw_flow_mask_cb,acts_callback}

2014-01-06T23:52:30+00:00

As we're only doing a kfree() anyway in the RCU callback, we can
simply use kfree_rcu, which does the same job, and remove the
function rcu_free_sw_flow_mask_cb() and rcu_free_acts_callback().

Signed-off-by: Daniel Borkmann 
Signed-off-by: Jesse Gross

openvswitch: Per cpu flow stats.

2014-01-06T23:52:24+00:00

With mega flow implementation ovs flow can be shared between
multiple CPUs which makes stats updates highly contended
operation. This patch uses per-CPU stats in cases where a flow
is likely to be shared (if there is a wildcard in the 5-tuple
and therefore likely to be spread by RSS). In other situations,
it uses the current strategy, saving memory and allocation time.

Signed-off-by: Pravin B Shelar 
Signed-off-by: Jesse Gross

openvswitch: Silence RCU lockdep checks from flow lookup.

2014-01-06T23:51:48+00:00

Flow lookup can happen either in packet processing context or userspace
context but it was annotated as requiring RCU read lock to be held. This
also allows OVS mutex to be held without causing warnings.

Reported-by: Justin Pettit 
Signed-off-by: Jesse Gross 
Reviewed-by: Thomas Graf

openvswitch: Change ovs_flow_tbl_lookup_xx() APIs

2014-01-06T23:51:41+00:00

API changes only for code readability. No functional chnages.

This patch removes the underscored version. Added a new API
ovs_flow_tbl_lookup_stats() that returns the n_mask_hits.

Reported by: Ben Pfaff 
Reviewed-by: Thomas Graf 
Signed-off-by: Andy Zhou 
Signed-off-by: Jesse Gross

openvswitch: Correct comment.

2014-01-06T23:51:21+00:00

Signed-off-by: Ben Pfaff 
Signed-off-by: Jesse Gross