linux-toradex.git/net/openvswitch, branch v4.0-rc2

openvswitch: Fix key serialization.

2015-02-15T04:20:40+00:00

Fix typo where mask is used rather than key.

Fixes: 74ed7ab9264("openvswitch: Add support for unique flow IDs.")
Reported-by: Joe Stringer 
Signed-off-by: Pravin B Shelar 
Acked-by: Joe Stringer 
Signed-off-by: David S. Miller

openvswitch: Add missing initialization in validate_and_copy_set_tun()

2015-02-11T22:40:15+00:00

net/openvswitch/flow_netlink.c: In function ‘validate_and_copy_set_tun’:
net/openvswitch/flow_netlink.c:1749: warning: ‘err’ may be used uninitialized in this function

If ipv4_tun_from_nlattr() returns a different positive value than
OVS_TUNNEL_KEY_ATTR_GENEVE_OPTS, err will be uninitialized, and
validate_and_copy_set_tun() may return an undefined value instead of a
zero success indicator. Initialize err to zero to fix this.

Fixes: 1dd144cf5b4b47e1 ("openvswitch: Support VXLAN Group Policy extension")
Signed-off-by: Geert Uytterhoeven 
Acked-by: Thomas Graf 
Acked-by: Pravin B Shelar 
Signed-off-by: David S. Miller

openvswitch: Reset key metadata for packet execution.

2015-02-11T22:40:15+00:00

Userspace packet execute command pass down flow key for given
packet. But userspace can skip some parameter with zero value.
Therefore kernel needs to initialize key metadata to zero.

Fixes: 0714812134 ("openvswitch: Eliminate memset() from flow_extract.")
Signed-off-by: Pravin B Shelar 
Signed-off-by: David S. Miller

openvswitch: Only set TUNNEL_VXLAN_OPT if VXLAN-GBP metadata is set

2015-02-09T22:25:52+00:00

This avoids setting TUNNEL_VXLAN_OPT for VXLAN frames which don't
have any GBP metadata set. It is not invalid to set it but unnecessary.

Signed-off-by: Thomas Graf 
Acked-by: Pravin B Shelar 
Signed-off-by: David S. Miller

openvswitch: Initialize unmasked key and uid len

2015-02-08T08:51:14+00:00

Flow alloc needs to initialize unmasked key pointer. Otherwise
it can crash kernel trying to free random unmasked-key pointer.

general protection fault: 0000 [#1] SMP
3.19.0-rc6-net-next+ #457
Hardware name: Supermicro X7DWU/X7DWU, BIOS  1.1 04/30/2008
RIP: 0010:[] [] kfree+0xac/0x196
Call Trace:
 [] flow_free+0x21/0x59 [openvswitch]
 [] ovs_flow_free+0x21/0x23 [openvswitch]
 [] ovs_packet_cmd_execute+0x2f3/0x35f [openvswitch]
 [] ? ovs_packet_cmd_execute+0x13e/0x35f [openvswitch]
 [] ? nla_parse+0x4f/0xec
 [] genl_family_rcv_msg+0x26d/0x2c9
 [] ? __lock_acquire+0x90e/0x9aa
 [] genl_rcv_msg+0x66/0x89
 [] ? genl_family_rcv_msg+0x2c9/0x2c9
 [] netlink_rcv_skb+0x3e/0x95
 [] ? genl_rcv+0x18/0x37
 [] genl_rcv+0x27/0x37
 [] netlink_unicast+0x103/0x191
 [] netlink_sendmsg+0x2c1/0x310
 [] ? might_fault+0x50/0xa0
 [] do_sock_sendmsg+0x5f/0x7a
 [] sock_sendmsg+0xb/0xd
 [] ___sys_sendmsg+0x1a3/0x218
 [] ? get_close_on_exec+0x86/0x86
 [] ? fsnotify+0x32c/0x348
 [] ? fsnotify+0x7c/0x348
 [] ? __fget+0xaa/0xbf
 [] ? get_close_on_exec+0x86/0x86
 [] __sys_sendmsg+0x3d/0x5e
 [] SyS_sendmsg+0x14/0x16
 [] system_call_fastpath+0x12/0x17

Fixes: 74ed7ab9264("openvswitch: Add support for unique flow IDs.")
CC: Joe Stringer 
Reported-by: Or Gerlitz 
Signed-off-by: Pravin B Shelar 
Acked-by: Eric Dumazet 
Signed-off-by: David S. Miller

net: openvswitch: Support masked set actions.

2015-02-08T06:40:17+00:00

OVS userspace already probes the openvswitch kernel module for
OVS_ACTION_ATTR_SET_MASKED support.  This patch adds the kernel module
implementation of masked set actions.

The existing set action sets many fields at once.  When only a subset
of the IP header fields, for example, should be modified, all the IP
fields need to be exact matched so that the other field values can be
copied to the set action.  A masked set action allows modification of
an arbitrary subset of the supported header bits without requiring the
rest to be matched.

Masked set action is now supported for all writeable key types, except
for the tunnel key.  The set tunnel action is an exception as any
input tunnel info is cleared before action processing starts, so there
is no tunnel info to mask.

The kernel module converts all (non-tunnel) set actions to masked set
actions.  This makes action processing more uniform, and results in
less branching and duplicating the action processing code.  When
returning actions to userspace, the fully masked set actions are
converted back to normal set actions.  We use a kernel internal action
code to be able to tell the userspace provided and converted masked
set actions apart.

Signed-off-by: Jarno Rajahalme 
Acked-by: Pravin B Shelar 
Signed-off-by: David S. Miller

openvswitch: Add support for checksums on UDP tunnels.

2015-01-29T07:04:15+00:00

Currently, it isn't possible to request checksums on the outer UDP
header of tunnels - the TUNNEL_CSUM flag is ignored. This adds
support for requesting that UDP checksums be computed on transmit
and properly reported if they are present on receive.

Signed-off-by: Jesse Gross 
Signed-off-by: David S. Miller

openvswitch: Add support for unique flow IDs.

2015-01-26T23:45:50+00:00

Previously, flows were manipulated by userspace specifying a full,
unmasked flow key. This adds significant burden onto flow
serialization/deserialization, particularly when dumping flows.

This patch adds an alternative way to refer to flows using a
variable-length "unique flow identifier" (UFID). At flow setup time,
userspace may specify a UFID for a flow, which is stored with the flow
and inserted into a separate table for lookup, in addition to the
standard flow table. Flows created using a UFID must be fetched or
deleted using the UFID.

All flow dump operations may now be made more terse with OVS_UFID_F_*
flags. For example, the OVS_UFID_F_OMIT_KEY flag allows responses to
omit the flow key from a datapath operation if the flow has a
corresponding UFID. This significantly reduces the time spent assembling
and transacting netlink messages. With all OVS_UFID_F_OMIT_* flags
enabled, the datapath only returns the UFID and statistics for each flow
during flow dump, increasing ovs-vswitchd revalidator performance by 40%
or more.

Signed-off-by: Joe Stringer 
Acked-by: Pravin B Shelar 
Signed-off-by: David S. Miller

openvswitch: Use sw_flow_key_range for key ranges.

2015-01-26T23:45:50+00:00

These minor tidyups make a future patch a little tidier.

Signed-off-by: Joe Stringer 
Acked-by: Pravin B Shelar 
Signed-off-by: David S. Miller

openvswitch: Refactor ovs_flow_tbl_insert().

2015-01-26T23:45:49+00:00

Rework so that ovs_flow_tbl_insert() calls flow_{key,mask}_insert().
This tidies up a future patch.

Signed-off-by: Joe Stringer 
Acked-by: Pravin B Shelar 
Signed-off-by: David S. Miller