linux-toradex.git/net/rxrpc, branch v3.4.96

net: rework recvmsg handler msg_name and msg_namelen logic

2013-12-08T15:29:41+00:00

[ Upstream commit f3d3342602f8bcbf37d7c46641cb9bca7618eb1c ]

This patch now always passes msg->msg_namelen as 0. recvmsg handlers must
set msg_namelen to the proper size <= sizeof(struct sockaddr_storage)
to return msg_name to the user.

This prevents numerous uninitialized memory leaks we had in the
recvmsg handlers and makes it harder for new code to accidentally leak
uninitialized memory.

Optimize for the case recvfrom is called with NULL as address. We don't
need to copy the address at all, so set it to NULL before invoking the
recvmsg handler. We can do so, because all the recvmsg handlers must
cope with the case a plain read() is called on them. read() also sets
msg_name to NULL.

Also document these changes in include/linux/net.h as suggested by David
Miller.

Changes since RFC:

Set msg->msg_name = NULL if user specified a NULL in msg_name but had a
non-null msg_namelen in verify_iovec/verify_compat_iovec. This doesn't
affect sendto as it would bail out earlier while trying to copy-in the
address. It also more naturally reflects the logic by the callers of
verify_iovec.

With this change in place I could remove "
if (!uaddr || msg_sys->msg_namelen == 0)
	msg->msg_name = NULL
".

This change does not alter the user visible error logic as we ignore
msg_namelen as long as msg_name is NULL.

Also remove two unnecessary curly brackets in ___sys_recvmsg and change
comments to netdev style.

Cc: David Miller 
Suggested-by: Eric Dumazet 
Signed-off-by: Hannes Frederic Sowa 
Signed-off-by: David S. Miller 
Signed-off-by: Greg Kroah-Hartman

RxRPC: Fix kcalloc parameters swapped

2012-02-14T19:41:55+00:00

The first parameter should be "number of elements" and the second parameter
should be "element size".

Signed-off-by: Axel Lin 
Acked-by: David Howells 
Signed-off-by: David S. Miller

net: fix assignment of 0/1 to bool variables.

2011-12-20T03:27:29+00:00

DaveM said:
   Please, this kind of stuff rots forever and not using bool properly
   drives me crazy.

Joe Perches  gave me the spatch script:

	@@
	bool b;
	@@
	-b = 0
	+b = false
	@@
	bool b;
	@@
	-b = 1
	+b = true

I merely installed coccinelle, read the documentation and took credit.

Signed-off-by: Rusty Russell 
Signed-off-by: David S. Miller

RxRPC: Use kmemdup rather than duplicating its implementation

2011-11-21T20:02:36+00:00

The semantic patch that makes this change is available
in scripts/coccinelle/api/memdup.cocci.

Signed-off-by: Thomas Meyer 
Signed-off-by: David S. Miller

net: Add export.h for EXPORT_SYMBOL/THIS_MODULE to non-modules

2011-10-31T23:30:30+00:00

These files are non modular, but need to export symbols using
the macros now living in export.h -- call out the include so
that things won't break when we remove the implicit presence
of module.h from everywhere.

Signed-off-by: Paul Gortmaker

rxrpc: Fix set but unused variable 'usage' in rxrpc_get_transport()

2011-05-19T22:51:50+00:00

This is identical to the case I fixed in rxrpc_get_peer()

Signed-off-by: David S. Miller

rxrpc: Fix set but unused variable 'usage' in rxrpc_get_peer().

2011-05-19T22:41:03+00:00

I backed off from trying to just eliminate this variable, since
transforming atomic_inc_return() into atomic_inc() takes away
the memory barriers.

Signed-off-by: David S. Miller

rxrpc: Kill set but unused variable 'local' in rxrpc_UDP_error_handler()

2011-05-19T22:37:11+00:00

Signed-off-by: David S. Miller

rxrpc: Kill set but unused variable 'sp' in rxrpc_process_connection()

2011-05-19T22:35:58+00:00

Signed-off-by: David S. Miller

rxrpc: Kill set but unused variable 'sp' in rxrpc_rotate_tx_window()

2011-05-19T22:34:37+00:00

Signed-off-by: David S. Miller