linux-toradex.git/net/sched/cls_cgroup.c, branch v5.1

net_sched: initialize net pointer inside tcf_exts_init()

2019-02-22T23:26:51+00:00

For tcindex filter, it is too late to initialize the
net pointer in tcf_exts_validate(), as tcf_exts_get_net()
requires a non-NULL net pointer. We can just move its
initialization into tcf_exts_init(), which just requires
an additional parameter.

This makes the code in tcindex_alloc_perfect_hash()
prettier.

Cc: Jamal Hadi Salim 
Cc: Jiri Pirko 
Signed-off-by: Cong Wang 
Signed-off-by: David S. Miller

net: sched: cgroup: verify that filter is not NULL during walk

2019-02-17T21:26:57+00:00

Check that filter is not NULL before passing it to tcf_walker->fn()
callback in cls_cgroup_walk(). This can happen when cls_cgroup_change()
failed to set first filter.

Fixes: ed76f5edccc9 ("net: sched: protect filter_chain list with filter_chain_lock mutex")
Signed-off-by: Vlad Buslov 
Signed-off-by: David S. Miller

net: sched: extend proto ops to support unlocked classifiers

2019-02-12T18:41:33+00:00

Add 'rtnl_held' flag to tcf proto change, delete, destroy, dump, walk
functions to track rtnl lock status. Extend users of these function in cls
API to propagate rtnl lock status to them. This allows classifiers to
obtain rtnl lock when necessary and to pass rtnl lock status to extensions
and driver offload callbacks.

Add flags field to tcf proto ops. Add flag value to indicate that
classifier doesn't require rtnl lock.

Signed-off-by: Vlad Buslov 
Acked-by: Jiri Pirko 
Signed-off-by: David S. Miller

net: sched: track rtnl lock status when validating extensions

2019-02-12T18:41:33+00:00

Actions API is already updated to not rely on rtnl lock for
synchronization. However, it need to be provided with rtnl status when
called from classifiers API in order to be able to correctly release the
lock when loading kernel module.

Extend extension validation function with 'rtnl_held' flag which is passed
to actions API. Add new 'rtnl_held' parameter to tcf_exts_validate() in cls
API. No classifier is currently updated to support unlocked execution, so
pass hardcoded 'true' flag parameter value.

Signed-off-by: Vlad Buslov 
Acked-by: Jiri Pirko 
Signed-off-by: David S. Miller

net_sched: switch to rcu_work

2018-05-25T02:56:15+00:00

Commit 05f0fe6b74db ("RCU, workqueue: Implement rcu_work") introduces
new API's for dispatching work in a RCU callback. Now we can just
switch to the new API's for tc filters. This could get rid of a lot
of code.

Cc: Tejun Heo 
Cc: "Paul E. McKenney" 
Cc: Jamal Hadi Salim 
Signed-off-by: Cong Wang 
Signed-off-by: David S. Miller

net: sched: propagate extack to cls->destroy callbacks

2018-01-24T21:01:09+00:00

Propagate extack to cls->destroy callbacks when called from
non-error paths.  On error paths pass NULL to avoid overwriting
the failure message.

Signed-off-by: Jakub Kicinski 
Reviewed-by: Simon Horman 
Signed-off-by: David S. Miller

net: sched: cls: add extack support for delete callback

2018-01-19T20:52:51+00:00

This patch adds extack support for classifier delete callback api. This
prepares to handle extack support inside each specific classifier
implementation.

Cc: David Ahern 
Signed-off-by: Alexander Aring 
Acked-by: Jiri Pirko 
Signed-off-by: David S. Miller

net: sched: cls: add extack support for tcf_exts_validate

2018-01-19T20:52:51+00:00

The tcf_exts_validate function calls the act api change callback. For
preparing extack support for act api, this patch adds the extack as
parameter for this function which is common used in cls implementations.

Furthermore the tcf_exts_validate will call action init callback which
prepares the TC action subsystem for extack support.

Cc: David Ahern 
Signed-off-by: Alexander Aring 
Acked-by: Jiri Pirko 
Signed-off-by: David S. Miller

net: sched: cls: add extack support for change callback

2018-01-19T20:52:51+00:00

This patch adds extack support for classifier change callback api. This
prepares to handle extack support inside each specific classifier
implementation.

Cc: David Ahern 
Signed-off-by: Alexander Aring 
Acked-by: Jiri Pirko 
Signed-off-by: David S. Miller

cls_cgroup: use tcf_exts_get_net() before call_rcu()

2017-11-09T01:03:09+00:00

Hold netns refcnt before call_rcu() and release it after
the tcf_exts_destroy() is done.

Note, on ->destroy() path we have to respect the return value
of tcf_exts_get_net(), on other paths it should always return
true, so we don't need to care.

Cc: Lucas Bates 
Cc: Jamal Hadi Salim 
Cc: Jiri Pirko 
Signed-off-by: Cong Wang 
Signed-off-by: David S. Miller