linux-toradex.git/net/sched/cls_route.c, branch v4.17-rc7

net: sched: propagate extack to cls->destroy callbacks

2018-01-24T21:01:09+00:00

Propagate extack to cls->destroy callbacks when called from
non-error paths.  On error paths pass NULL to avoid overwriting
the failure message.

Signed-off-by: Jakub Kicinski 
Reviewed-by: Simon Horman 
Signed-off-by: David S. Miller

net: sched: cls: add extack support for delete callback

2018-01-19T20:52:51+00:00

This patch adds extack support for classifier delete callback api. This
prepares to handle extack support inside each specific classifier
implementation.

Cc: David Ahern 
Signed-off-by: Alexander Aring 
Acked-by: Jiri Pirko 
Signed-off-by: David S. Miller

net: sched: cls: add extack support for tcf_exts_validate

2018-01-19T20:52:51+00:00

The tcf_exts_validate function calls the act api change callback. For
preparing extack support for act api, this patch adds the extack as
parameter for this function which is common used in cls implementations.

Furthermore the tcf_exts_validate will call action init callback which
prepares the TC action subsystem for extack support.

Cc: David Ahern 
Signed-off-by: Alexander Aring 
Acked-by: Jiri Pirko 
Signed-off-by: David S. Miller

net: sched: cls: add extack support for change callback

2018-01-19T20:52:51+00:00

This patch adds extack support for classifier change callback api. This
prepares to handle extack support inside each specific classifier
implementation.

Cc: David Ahern 
Signed-off-by: Alexander Aring 
Acked-by: Jiri Pirko 
Signed-off-by: David S. Miller

net: sched: introduce block mechanism to handle netif_keep_dst calls

2018-01-17T19:53:56+00:00

Couple of classifiers call netif_keep_dst directly on q->dev. That is
not possible to do directly for shared blocke where multiple qdiscs are
owning the block. So introduce a infrastructure to keep track of the
block owners in list and use this list to implement block variant of
netif_keep_dst.

Signed-off-by: Jiri Pirko 
Acked-by: Jamal Hadi Salim 
Acked-by: David Ahern 
Signed-off-by: David S. Miller

cls_route: use tcf_exts_get_net() before call_rcu()

2017-11-09T01:03:10+00:00

Hold netns refcnt before call_rcu() and release it after
the tcf_exts_destroy() is done.

Note, on ->destroy() path we have to respect the return value
of tcf_exts_get_net(), on other paths it should always return
true, so we don't need to care.

Cc: Lucas Bates 
Cc: Jamal Hadi Salim 
Cc: Jiri Pirko 
Signed-off-by: Cong Wang 
Signed-off-by: David S. Miller

net_sched: use tcf_queue_work() in route filter

2017-10-29T13:49:31+00:00

Defer the tcf_exts_destroy() in RCU callback to
tc filter workqueue and get RTNL lock.

Reported-by: Chris Mi 
Cc: Daniel Borkmann 
Cc: Jiri Pirko 
Cc: John Fastabend 
Cc: Jamal Hadi Salim 
Cc: "Paul E. McKenney" 
Signed-off-by: Cong Wang 
Signed-off-by: David S. Miller

net_sched: add reverse binding for tc class

2017-08-31T18:40:52+00:00

TC filters when used as classifiers are bound to TC classes.
However, there is a hidden difference when adding them in different
orders:

1. If we add tc classes before its filters, everything is fine.
   Logically, the classes exist before we specify their ID's in
   filters, it is easy to bind them together, just as in the current
   code base.

2. If we add tc filters before the tc classes they bind, we have to
   do dynamic lookup in fast path. What's worse, this happens all
   the time not just once, because on fast path tcf_result is passed
   on stack, there is no way to propagate back to the one in tc filters.

This hidden difference hurts performance silently if we have many tc
classes in hierarchy.

This patch intends to close this gap by doing the reverse binding when
we create a new class, in this case we can actually search all the
filters in its parent, match and fixup by classid. And because
tcf_result is specific to each type of tc filter, we have to introduce
a new ops for each filter to tell how to bind the class.

Note, we still can NOT totally get rid of those class lookup in
->enqueue() because cgroup and flow filters have no way to determine
the classid at setup time, they still have to go through dynamic lookup.

Cc: Jamal Hadi Salim 
Signed-off-by: Cong Wang 
Signed-off-by: David S. Miller

net_sched: use void pointer for filter handle

2017-08-07T21:12:17+00:00

Now we use 'unsigned long fh' as a pointer in every place,
it is safe to convert it to a void pointer now. This gets
rid of many casts to pointer.

Cc: Jamal Hadi Salim 
Cc: Jiri Pirko 
Signed-off-by: Cong Wang 
Acked-by: Jamal Hadi Salim 
Signed-off-by: David S. Miller

net: sched: cls_route: no need to call tcf_exts_change for newly allocated struct

2017-08-04T18:21:24+00:00

As the f struct was allocated right before route4_set_parms call,
no need to use tcf_exts_change to do atomic change, and we can just
fill-up the unused exts struct directly by tcf_exts_validate.

Signed-off-by: Jiri Pirko 
Signed-off-by: David S. Miller