linux-toradex.git/net/sched/cls_u32.c, branch v5.1

net_sched: initialize net pointer inside tcf_exts_init()

2019-02-22T23:26:51+00:00

For tcindex filter, it is too late to initialize the
net pointer in tcf_exts_validate(), as tcf_exts_get_net()
requires a non-NULL net pointer. We can just move its
initialization into tcf_exts_init(), which just requires
an additional parameter.

This makes the code in tcindex_alloc_perfect_hash()
prettier.

Cc: Jamal Hadi Salim 
Cc: Jiri Pirko 
Signed-off-by: Cong Wang 
Signed-off-by: David S. Miller

net: sched: extend proto ops to support unlocked classifiers

2019-02-12T18:41:33+00:00

Add 'rtnl_held' flag to tcf proto change, delete, destroy, dump, walk
functions to track rtnl lock status. Extend users of these function in cls
API to propagate rtnl lock status to them. This allows classifiers to
obtain rtnl lock when necessary and to pass rtnl lock status to extensions
and driver offload callbacks.

Add flags field to tcf proto ops. Add flag value to indicate that
classifier doesn't require rtnl lock.

Signed-off-by: Vlad Buslov 
Acked-by: Jiri Pirko 
Signed-off-by: David S. Miller

net: sched: track rtnl lock status when validating extensions

2019-02-12T18:41:33+00:00

Actions API is already updated to not rely on rtnl lock for
synchronization. However, it need to be provided with rtnl status when
called from classifiers API in order to be able to correctly release the
lock when loading kernel module.

Extend extension validation function with 'rtnl_held' flag which is passed
to actions API. Add new 'rtnl_held' parameter to tcf_exts_validate() in cls
API. No classifier is currently updated to support unlocked execution, so
pass hardcoded 'true' flag parameter value.

Signed-off-by: Vlad Buslov 
Acked-by: Jiri Pirko 
Signed-off-by: David S. Miller

net_sched: fold tcf_block_cb_call() into tc_setup_cb_call()

2018-12-14T23:32:19+00:00

After commit 69bd48404f25 ("net/sched: Remove egdev mechanism"),
tc_setup_cb_call() is nearly identical to tcf_block_cb_call(),
so we can just fold tcf_block_cb_call() into tc_setup_cb_call()
and remove its unused parameter 'exts'.

Fixes: 69bd48404f25 ("net/sched: Remove egdev mechanism")
Cc: Oz Shlomo 
Cc: Jiri Pirko 
Signed-off-by: Cong Wang 
Acked-by: Jiri Pirko 
Acked-by: Oz Shlomo 
Signed-off-by: David S. Miller

net: sched: cls_u32: add res to offload information

2018-11-20T02:53:46+00:00

In case of egress offloads the class/flowid assigned by the filter
may be very important for offloaded Qdisc selection.  Provide this
info to drivers.

Signed-off-by: Jakub Kicinski 
Reviewed-by: John Hurley 
Signed-off-by: David S. Miller

Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net

2018-10-13T04:38:46+00:00

Conflicts were easy to resolve using immediate context mostly,
except the cls_u32.c one where I simply too the entire HEAD
chunk.

Signed-off-by: David S. Miller

net: sched: cls_u32: simplify the hell out u32_delete() emptiness check

2018-10-08T17:33:35+00:00

Now that we have the knode count, we can instantly check if
any hnodes are non-empty.  And that kills the check for extra
references to root hnode - those could happen only if there was
a knode to carry such a link.

Signed-off-by: Al Viro 
Signed-off-by: Jamal Hadi Salim 
Signed-off-by: David S. Miller

net: sched: cls_u32: keep track of knodes count in tc_u_common

2018-10-08T17:33:35+00:00

allows to simplify u32_delete() considerably

Signed-off-by: Al Viro 
Signed-off-by: Jamal Hadi Salim 
Signed-off-by: David S. Miller

net: sched: cls_u32: get rid of tp_c

2018-10-08T17:33:35+00:00

Both hnode ->tp_c and tp_c argument of u32_set_parms()
the latter is redundant, the former - never read...

Signed-off-by: Al Viro 
Signed-off-by: Jamal Hadi Salim 
Signed-off-by: David S. Miller

net: sched: cls_u32: the tp_c argument of u32_set_parms() is always tp->data

2018-10-08T17:33:35+00:00

It must be tc_u_common associated with that tp (i.e. tp->data).
Proof:
	* both ->ht_up and ->tp_c are assign-once
	* ->tp_c of anything inserted into tp_c->hlist is tp_c
	* hnodes never get reinserted into the lists or moved
between those, so anything found by u32_lookup_ht(tp->data, ...)
will have ->tp_c equal to tp->data.
	* tp->root->tp_c == tp->data.
	* ->ht_up of anything inserted into hnode->ht[...] is
equal to hnode.
	* knodes never get reinserted into hash chains or moved
between those, so anything returned by u32_lookup_key(ht, ...)
will have ->ht_up equal to ht.
	* any knode returned by u32_get(tp, ...) will have ->ht_up->tp_c
point to tp->data

Signed-off-by: Al Viro 
Signed-off-by: Jamal Hadi Salim 
Signed-off-by: David S. Miller