linux-toradex.git/net/socket.c, branch v5.9-rc6

net: Fix some comments

2020-08-27T14:55:59+00:00

Fix some comments, including wrong function name, duplicated word and so
on.

Signed-off-by: Miaohe Lin 
Signed-off-by: David S. Miller

net: Revert "net: optimize the sockptr_t for unified kernel/user address spaces"

2020-08-10T19:06:44+00:00

This reverts commits 6d04fe15f78acdf8e32329e208552e226f7a8ae6 and
a31edb2059ed4e498f9aa8230c734b59d0ad797a.

It turns out the idea to share a single pointer for both kernel and user
space address causes various kinds of problems.  So use the slightly less
optimal version that uses an extra bit, but which is guaranteed to be safe
everywhere.

Fixes: 6d04fe15f78a ("net: optimize the sockptr_t for unified kernel/user address spaces")
Reported-by: Eric Dumazet 
Reported-by: John Stultz 
Signed-off-by: Christoph Hellwig 
Signed-off-by: David S. Miller

net: Convert to use the fallthrough macro

2020-08-08T21:29:09+00:00

Convert the uses of fallthrough comments to fallthrough macro.

Signed-off-by: Miaohe Lin 
Signed-off-by: David S. Miller

net: Remove meaningless jump label out_fs

2020-08-08T21:23:21+00:00

The out_fs jump label has nothing to do but goto out.

Signed-off-by: Miaohe Lin 
Signed-off-by: David S. Miller

net: Set fput_needed iff FDPUT_FPUT is set

2020-08-08T21:21:42+00:00

We should fput() file iff FDPUT_FPUT is set. So we should set fput_needed
accordingly.

Fixes: 00e188ef6a7e ("sockfd_lookup_light(): switch to fdget^W^Waway from fget_light")
Signed-off-by: Miaohe Lin 
Signed-off-by: David S. Miller

net: Use helper function fdput()

2020-08-08T21:19:16+00:00

Use helper function fdput() to fput() the file iff FDPUT_FPUT is set.

Signed-off-by: Miaohe Lin 
Signed-off-by: David S. Miller

net: improve the user pointer check in init_user_sockptr

2020-07-28T20:43:40+00:00

Make sure not just the pointer itself but the whole range lies in
the user address space.  For that pass the length and then use
the access_ok helper to do the check.

Fixes: 6d04fe15f78a ("net: optimize the sockptr_t for unified kernel/user address spaces")
Reported-by: David Laight 
Signed-off-by: Christoph Hellwig 
Signed-off-by: David S. Miller

net: optimize the sockptr_t for unified kernel/user address spaces

2020-07-24T22:41:54+00:00

For architectures like x86 and arm64 we don't need the separate bit to
indicate that a pointer is a kernel pointer as the address spaces are
unified.  That way the sockptr_t can be reduced to a union of two
pointers, which leads to nicer calling conventions.

The only caveat is that we need to check that users don't pass in kernel
address and thus gain access to kernel memory.  Thus the USER_SOCKPTR
helper is replaced with a init_user_sockptr function that does this check
and returns an error if it fails.

Signed-off-by: Christoph Hellwig 
Signed-off-by: David S. Miller

net: pass a sockptr_t into ->setsockopt

2020-07-24T22:41:54+00:00

Rework the remaining setsockopt code to pass a sockptr_t instead of a
plain user pointer.  This removes the last remaining set_fs(KERNEL_DS)
outside of architecture specific code.

Signed-off-by: Christoph Hellwig 
Acked-by: Stefan Schmidt  [ieee802154]
Acked-by: Matthieu Baerts 
Signed-off-by: David S. Miller

net: switch sock_set_timeout to sockptr_t

2020-07-24T22:41:53+00:00

Pass a sockptr_t to prepare for set_fs-less handling of the kernel
pointer from bpf-cgroup.

Signed-off-by: Christoph Hellwig 
Acked-by: Matthieu Baerts 
Signed-off-by: David S. Miller