linux-toradex.git/net/sunrpc/cache.c, branch v5.12-rc5

sunrpc: clean-up cache downcall

2020-12-09T14:38:34+00:00

We can simplify code around cache_downcall unifying memory
allocations using kvmalloc. This has the benefit of getting rid of
cache_slow_downcall (and queue_io_mutex), and also matches userland
allocation size and limits.

Signed-off-by: Roberto Bergantinos Corpas 
Signed-off-by: Chuck Lever

sunrpc: raise kernel RPC channel buffer size

2020-10-20T17:21:30+00:00

Its possible that using AUTH_SYS and mountd manage-gids option a
user may hit the 8k RPC channel buffer limit. This have been observed
on field, causing unanswered RPCs on clients after mountd fails to
write on channel :

rpc.mountd[11231]: auth_unix_gid: error writing reply

Userland nfs-utils uses a buffer size of 32k (RPC_CHAN_BUF_SIZE), so
lets match those two.

Signed-off-by: Roberto Bergantinos Corpas 
Signed-off-by: J. Bruce Fields

sunrpc: simplify do_cache_clean

2020-09-25T22:02:02+00:00

Is it just me, or is the logic written in a slightly convoluted way?

I find it a little easier to read this way.

Signed-off-by: J. Bruce Fields

sunrpc: cache : Replace seq_printf with seq_puts

2020-09-25T22:01:28+00:00

seq_puts is a lot cheaper than seq_printf, so use that to print
literal strings.

Signed-off-by: Xu Wang 
Signed-off-by: J. Bruce Fields

SUNRPC/cache: Fix unsafe traverse caused double-free in cache_purge

2020-04-13T14:28:21+00:00

Deleting list entry within hlist_for_each_entry_safe is not safe unless
next pointer (tmp) is protected too. It's not, because once hash_lock
is released, cache_clean may delete the entry that tmp points to. Then
cache_purge can walk to a deleted entry and tries to double free it.

Fix this bug by holding only the deleted entry's reference.

Suggested-by: NeilBrown 
Signed-off-by: Yihao Wu 
Reviewed-by: NeilBrown 
[ cel: removed unused variable ]
Signed-off-by: Chuck Lever

sunrpc: Add tracing for cache events

2020-03-16T16:04:34+00:00

Add basic tracing for debugging the sunrpc cache events.

Signed-off-by: Trond Myklebust 
Signed-off-by: Chuck Lever

SUNRPC/cache: Allow garbage collection of invalid cache entries

2020-03-16T16:04:34+00:00

If the cache entry never gets initialised, we want the garbage
collector to be able to evict it. Otherwise if the upcall daemon
fails to initialise the entry, we end up never expiring it.

Signed-off-by: Trond Myklebust 
[ cel: resolved a merge conflict ]
Signed-off-by: Chuck Lever

nfsd: export upcalls must not return ESTALE when mountd is down

2020-03-16T16:04:33+00:00

If the rpc.mountd daemon goes down, then that should not cause all
exports to start failing with ESTALE errors. Let's explicitly
distinguish between the cache upcall cases that need to time out,
and those that do not.

Signed-off-by: Trond Myklebust 
Signed-off-by: Chuck Lever

sunrpc: Pass lockdep expression to RCU lists

2020-03-16T16:04:31+00:00

detail->hash_table[] is traversed using hlist_for_each_entry_rcu
outside an RCU read-side critical section but under the protection
of detail->hash_lock.

Hence, add corresponding lockdep expression to silence false-positive
warnings, and harden RCU lists.

Signed-off-by: Amol Grover 
Signed-off-by: J. Bruce Fields 
Signed-off-by: Chuck Lever

Merge tag 'nfsd-5.6' of git://linux-nfs.org/~bfields/linux

2020-02-08T01:50:21+00:00

Pull nfsd updates from Bruce Fields:
 "Highlights:

   - Server-to-server copy code from Olga.

     To use it, client and both servers must have support, the target
     server must be able to access the source server over NFSv4.2, and
     the target server must have the inter_copy_offload_enable module
     parameter set.

   - Improvements and bugfixes for the new filehandle cache, especially
     in the container case, from Trond

   - Also from Trond, better reporting of write errors.

   - Y2038 work from Arnd"

* tag 'nfsd-5.6' of git://linux-nfs.org/~bfields/linux: (55 commits)
  sunrpc: expiry_time should be seconds not timeval
  nfsd: make nfsd_filecache_wq variable static
  nfsd4: fix double free in nfsd4_do_async_copy()
  nfsd: convert file cache to use over/underflow safe refcount
  nfsd: Define the file access mode enum for tracing
  nfsd: Fix a perf warning
  nfsd: Ensure sampling of the write verifier is atomic with the write
  nfsd: Ensure sampling of the commit verifier is atomic with the commit
  sunrpc: clean up cache entry add/remove from hashtable
  sunrpc: Fix potential leaks in sunrpc_cache_unhash()
  nfsd: Ensure exclusion between CLONE and WRITE errors
  nfsd: Pass the nfsd_file as arguments to nfsd4_clone_file_range()
  nfsd: Update the boot verifier on stable writes too.
  nfsd: Fix stable writes
  nfsd: Allow nfsd_vfs_write() to take the nfsd_file as an argument
  nfsd: Fix a soft lockup race in nfsd_file_mark_find_or_create()
  nfsd: Reduce the number of calls to nfsd_file_gc()
  nfsd: Schedule the laundrette regularly irrespective of file errors
  nfsd: Remove unused constant NFSD_FILE_LRU_RESCAN
  nfsd: Containerise filecache laundrette
  ...