linux-toradex.git/net/sunrpc/rpcb_clnt.c, branch v3.2.64

SUNRPC: return negative value in case rpcbind client creation error

2012-08-09T23:25:02+00:00

commit caea33da898e4e14f0ba58173e3b7689981d2c0b upstream.

Without this patch kernel will panic on LockD start, because lockd_up() checks
lockd_up_net() result for negative value.
From my pow it's better to return negative value from rpcbind routines instead
of replacing all such checks like in lockd_up().

Signed-off-by: Stanislav Kinsbursky 
Signed-off-by: Trond Myklebust 
Signed-off-by: Ben Hutchings

SUNRPC: remove rpcbind clients destruction on module cleanup

2011-10-25T11:20:50+00:00

Rpcbind clients destruction during SUNRPC module removing is obsolete since now
those clients are destroying during last RPC service shutdown.

Signed-off-by: Stanislav Kinsbursky 
Signed-off-by: Trond Myklebust

SUNRPC: remove rpcbind clients creation during service registering

2011-10-25T11:20:35+00:00

We don't need this code since rpcbind clients are creating during RPC service
creation.

Signed-off-by: Stanislav Kinsbursky 
Signed-off-by: Trond Myklebust

SUNRPC: introduce svc helpers for prepairing rpcbind infrastructure

2011-10-25T11:18:05+00:00

This helpers will be used only for those services, that will send portmapper
registration calls.

Signed-off-by: Stanislav Kinsbursky 
Signed-off-by: Trond Myklebust

SUNRPC: use rpcbind reference counting helpers

2011-10-25T11:16:36+00:00

All is simple: we just increase users counter if rpcbind clients has been
created already. Otherwise we create them and set users counter to 1.

Signed-off-by: Stanislav Kinsbursky 
Signed-off-by: Trond Myklebust

SUNRPC: introduce helpers for reference counted rpcbind clients

2011-10-25T11:15:48+00:00

v6:
1) added write memory barrier to rpcb_set_local to make sure, that rpcbind
clients become valid before rpcb_users assignment
2) explicitly set rpcb_users to 1 instead of incrementing it (looks clearer from
my pow).

v5: fixed races with rpcb_users in rpcb_get_local()

This helpers will be used for dynamical creation and destruction of rpcbind
clients.
Variable rpcb_users is actually a counter of lauched RPC services. If rpcbind
clients has been created already, then we just increase rpcb_users.

Signed-off-by: Stanislav Kinsbursky 
Signed-off-by: Trond Myklebust

SUNRPC: Fix rpc_sockaddr2uaddr

2011-10-18T16:13:32+00:00

rpc_sockaddr2uaddr is only used by net/sunrpc/rpcb_clnt.c, where
it is used in a non-blockable context in at least one case.

Add non-blocking capability by adding a gfp_t argument

Signed-off-by: Trond Myklebust

SUNRPC: Fix use of static variable in rpcb_getport_async

2011-07-12T17:40:13+00:00

Because struct rpcbind_args *map was declared static, if two
threads entered this method at the same time, the values
assigned to map could be sent two two differen tasks.
This could cause all sorts of problems, include use-after-free
and double-free of memory.

Fix this by removing the static declaration so that the map
pointer is on the stack.

Signed-off-by: Ben Greear 
Cc: stable@kernel.org
Signed-off-by: Trond Myklebust

SUNRPC: Use AF_LOCAL for rpcbind upcalls

2011-05-27T21:42:47+00:00

As libtirpc does in user space, have our registration API try using an
AF_LOCAL transport first when registering and unregistering.

This means we don't chew up privileged ports, and our registration is
bound to an "owner" (the effective uid of the process on the sending
end of the transport).  Only that "owner" may unregister the service.

The kernel could probe rpcbind via an rpcbind query to determine
whether rpcbind has an AF_LOCAL service. For simplicity, we use the
same technique that libtirpc uses: simply fail over to network
loopback if creating an AF_LOCAL transport to the well-known rpcbind
service socket fails.

This means we open-code the pathname of the rpcbind socket in the
kernel.  For now we have to do that anyway because the kernel's
RPC over AF_LOCAL implementation does not support autobind.  That may
be undesirable in the long term.

Signed-off-by: Chuck Lever 
Signed-off-by: Trond Myklebust

SUNRPC: New xdr_streams XDR decoder API

2010-12-16T17:37:25+00:00

Now that all client-side XDR decoder routines use xdr_streams, there
should be no need to support the legacy calling sequence [rpc_rqst *,
__be32 *, RPC res *] anywhere.  We can construct an xdr_stream in the
generic RPC code, instead of in each decoder function.

This is a refactoring change.  It should not cause different behavior.

Signed-off-by: Chuck Lever 
Tested-by: J. Bruce Fields 
Signed-off-by: Trond Myklebust