linux-toradex.git/net/sunrpc/sysctl.c, branch v3.0.16

sysctl: Drop & in front of every proc_handler.

2009-11-18T16:37:40+00:00

For consistency drop & in front of every proc_handler.  Explicity
taking the address is unnecessary and it prevents optimizations
like stubbing the proc_handlers to NULL.

Cc: Alexey Dobriyan 
Cc: Ingo Molnar 
Cc: Joe Perches 
Signed-off-by: Eric W. Biederman

sysctl net: Remove unused binary sysctl code

2009-11-12T10:05:06+00:00

Now that sys_sysctl is a compatiblity wrapper around /proc/sys
all sysctl strategy routines, and all ctl_name and strategy
entries in the sysctl tables are unused, and can be
revmoed.

In addition neigh_sysctl_register has been modified to no longer
take a strategy argument and it's callers have been modified not
to pass one.

Cc: "David Miller" 
Cc: Hideaki YOSHIFUJI 
Cc: netdev@vger.kernel.org
Signed-off-by: Eric W. Biederman

sysctl: remove "struct file *" argument of ->proc_handler

2009-09-24T14:21:04+00:00

It's unused.

It isn't needed -- read or write flag is already passed and sysctl
shouldn't care about the rest.

It _was_ used in two places at arch/frv for some reason.

Signed-off-by: Alexey Dobriyan 
Cc: David Howells 
Cc: "Eric W. Biederman" 
Cc: Al Viro 
Cc: Ralf Baechle 
Cc: Martin Schwidefsky 
Cc: Ingo Molnar 
Cc: "David S. Miller" 
Cc: James Morris 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

sunrpc: fix possible overrun on read of /proc/sys/sunrpc/transports

2008-09-01T18:24:24+00:00

Vegard Nossum reported
----------------------
> I noticed that something weird is going on with /proc/sys/sunrpc/transports.
> This file is generated in net/sunrpc/sysctl.c, function proc_do_xprt(). When
> I "cat" this file, I get the expected output:
>    $ cat /proc/sys/sunrpc/transports
>    tcp 1048576
>    udp 32768

> But I think that it does not check the length of the buffer supplied by
> userspace to read(). With my original program, I found that the stack was
> being overwritten by the characters above, even when the length given to
> read() was just 1.

David Wagner added (among other things) that copy_to_user could be
probably used here.

Ingo Oeser suggested to use simple_read_from_buffer() here.

The conclusion is that proc_do_xprt doesn't check for userside buffer
size indeed so fix this by using Ingo's suggestion.

Reported-by: Vegard Nossum 
Signed-off-by: Cyrill Gorcunov 
CC: Ingo Oeser 
Cc: Neil Brown 
Cc: Chuck Lever 
Cc: Greg Banks 
Cc: Tom Tucker 
Signed-off-by: J. Bruce Fields

svc: Add /proc/sys/sunrpc/transport files

2008-02-01T21:42:13+00:00

Add a file that when read lists the set of registered svc
transports.

Signed-off-by: Tom Tucker 
Acked-by: Neil Brown 
Reviewed-by: Chuck Lever 
Reviewed-by: Greg Banks 
Signed-off-by: J. Bruce Fields

SUNRPC: Restrict sunrpc client exports

2008-01-30T07:05:28+00:00

The sunrpc client exports are not meant to be part of any official kernel
API: they can change at the drop of a hat. Mark them as internal functions
using EXPORT_SYMBOL_GPL.

Signed-off-by: Trond Myklebust

SUNRPC: Move exported declarations to the function declarations

2008-01-30T07:05:28+00:00

Do this for all RPC client related functions and XDR functions.

Signed-off-by: Trond Myklebust

sunrpc: fix rpc debugging

2007-10-30T15:06:55+00:00

Commit baa3a2a0d24ebcf1c451bec8e5bee3d3467f4cbb ("sysctl: remove broken
sunrpc debug binary sysctls"), by removing initialization of the
ctl_name field, broke this conditional, preventing the display of
rpc_tasks that you previously got when turning on rpc debugging.

[akpm@linux-foundation.org: coding-style fixes]
Signed-off-by: J. Bruce Fields 
Acked-by: "Eric W. Biederman" 
Cc: "David S. Miller" 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

sysctl: remove broken sunrpc debug binary sysctls

2007-10-18T21:37:22+00:00

This is debug code so no need to support binary sysctl, and the binary sysctls
as they were written were not consistent with what showed up in /proc so
remove the binary sysctl support.

Signed-off-by: Eric W. Biederman 
Cc: Alexey Dobriyan 
Cc: "David S. Miller" 
Cc: Trond Myklebust 
Cc: Neil Brown 
Cc: "J. Bruce Fields" 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

[PATCH] sysctl: remove insert_at_head from register_sysctl

2007-02-14T16:09:59+00:00

The semantic effect of insert_at_head is that it would allow new registered
sysctl entries to override existing sysctl entries of the same name.  Which is
pain for caching and the proc interface never implemented.

I have done an audit and discovered that none of the current users of
register_sysctl care as (excpet for directories) they do not register
duplicate sysctl entries.

So this patch simply removes the support for overriding existing entries in
the sys_sysctl interface since no one uses it or cares and it makes future
enhancments harder.

Signed-off-by: Eric W. Biederman 
Acked-by: Ralf Baechle 
Acked-by: Martin Schwidefsky 
Cc: Russell King 
Cc: David Howells 
Cc: "Luck, Tony" 
Cc: Ralf Baechle 
Cc: Paul Mackerras 
Cc: Martin Schwidefsky 
Cc: Andi Kleen 
Cc: Jens Axboe 
Cc: Corey Minyard 
Cc: Neil Brown 
Cc: "John W. Linville" 
Cc: James Bottomley 
Cc: Jan Kara 
Cc: Trond Myklebust 
Cc: Mark Fasheh 
Cc: David Chinner 
Cc: "David S. Miller" 
Cc: Patrick McHardy 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds