linux-toradex.git/net/sunrpc/xdr.c, branch v3.4.80

SUNRPC: Fix memory corruption issue on 32-bit highmem systems

2013-09-08T04:58:15+00:00

commit 347e2233b7667e336d9f671f1a52dfa3f0416e2c upstream.

Some architectures, such as ARM-32 do not return the same base address
when you call kmap_atomic() twice on the same page.
This causes problems for the memmove() call in the XDR helper routine
"_shift_data_right_pages()", since it defeats the detection of
overlapping memory ranges, and has been seen to corrupt memory.

The fix is to distinguish between the case where we're doing an
inter-page copy or not. In the former case of we know that the memory
ranges cannot possibly overlap, so we can additionally micro-optimise
by replacing memmove() with memcpy().

Reported-by: Mark Young 
Reported-by: Matt Craighead 
Cc: Bruce Fields 
Signed-off-by: Trond Myklebust 
Tested-by: Matt Craighead 
Signed-off-by: Greg Kroah-Hartman

sunrpc: remove the second argument of k[un]map_atomic()

2012-03-20T13:48:28+00:00

Signed-off-by: Cong Wang

NFSv4: include bitmap in nfsv4 get acl data

2012-01-05T15:42:42+00:00

The NFSv4 bitmap size is unbounded: a server can return an arbitrary
sized bitmap in an FATTR4_WORD0_ACL request.  Replace using the
nfs4_fattr_bitmap_maxsz as a guess to the maximum bitmask returned by a server
with the inclusion of the bitmap (xdr length plus bitmasks) and the acl data
xdr length to the (cached) acl page data.

This is a general solution to commit e5012d1f "NFSv4.1: update
nfs4_fattr_bitmap_maxsz" and fixes hitting a BUG_ON in xdr_shrink_bufhead
when getting ACLs.

Fix a bug in decode_getacl that returned -EINVAL on ACLs > page when getxattr
was called with a NULL buffer, preventing ACL > PAGE_SIZE from being retrieved.

Cc: stable@kernel.org
Signed-off-by: Andy Adamson 
Signed-off-by: Trond Myklebust

SUNRPC: Convert the backchannel exports to EXPORT_SYMBOL_GPL

2011-07-15T13:12:23+00:00

Ensure that the backchannel exports conform to the existing sunrpc
practice.

Signed-off-by: Trond Myklebust

SUNRPC: introduce xdr_init_decode_pages

2011-05-29T17:52:32+00:00

Initialize xdr_stream and xdr_buf using an array of page pointers
and length of buffer.

Signed-off-by: Benny Halevy

NFS: Don't use vm_map_ram() in readdir

2011-01-10T19:45:01+00:00

vm_map_ram() is not available on NOMMU platforms, and causes trouble
on incoherrent architectures such as ARM when we access the page data
through both the direct and the virtual mapping.

The alternative is to use the direct mapping to access page data
for the case when we are not crossing a page boundary, but to copy
the data into a linear scratch buffer when we are accessing data
that spans page boundaries.

Signed-off-by: Trond Myklebust 
Tested-by: Marc Kleine-Budde 
Cc: stable@kernel.org  [2.6.37]

SUNRPC: Add a helper function xdr_inline_peek

2010-10-23T19:27:32+00:00

We sometimes need to be able to read ahead in an xdr_stream without
incrementing the current pointer position.

Signed-off-by: Trond Myklebust

SUNRPC: Refactor logic to NUL-terminate strings in pages

2010-09-21T20:55:48+00:00

Clean up: Introduce a helper to '\0'-terminate XDR strings
that are placed in a page in the page cache.

Signed-off-by: Chuck Lever 
Signed-off-by: Trond Myklebust

SUNRPC: Don't truncate tail data unnecessarily in xdr_shrink_pagelen

2010-08-29T16:13:16+00:00

If we have unused buffer space, then we should make use of that rather
than unnecessarily truncating the message.

Signed-off-by: Trond Myklebust

sunrpc: simplify xdr_shrink_pagelen use of "copy"

2010-08-29T16:13:15+00:00

The "copy" variable value can be computed using the existing
logic rather than repeating it.

Signed-off-by: Benny Halevy 
Signed-off-by: Trond Myklebust