linux-toradex.git/net/sunrpc/xprt.c, branch v3.4.2

sunrpc: fix loss of task->tk_status after rpc_delay call in xprt_alloc_slot

2012-06-09T15:36:09+00:00

commit 1afeaf5c29aa07db25760d2fbed5c08a3aec3498 upstream.

xprt_alloc_slot will call rpc_delay() to make the task wait a bit before
retrying when it gets back an -ENOMEM error from xprt_dynamic_alloc_slot.
The problem is that rpc_delay will clear the task->tk_status, causing
call_reserveresult to abort the task.

The solution is simply to let call_reserveresult handle the ENOMEM error
directly.

Reported-by: Jeff Layton 
Signed-off-by: Trond Myklebust 
Signed-off-by: Greg Kroah-Hartman

SUNRPC: Move clnt->cl_server into struct rpc_xprt

2012-03-02T20:36:41+00:00

When the cl_xprt field is updated, the cl_server field will also have
to change.  Since the contents of cl_server follow the remote endpoint
of cl_xprt, just move that field to the rpc_xprt.

Signed-off-by: Trond Myklebust 
[ cel: simplify check_gss_callback_principal(), whitespace changes ]
[ cel: forward ported to 3.4 ]
Signed-off-by: Chuck Lever 
Signed-off-by: Trond Myklebust

NFS: include filelayout DS rpc stats in mountstats

2012-02-17T18:39:47+00:00

Include RPC statistics from all data servers in /proc/self/mountstats for pNFS
filelayout mounts.

Signed-off-by: Weston Andros Adamson 
Signed-off-by: Trond Myklebust

SUNRPC: add sending,pending queue and max slot to xprt stats

2012-02-16T19:55:27+00:00

With static RPC slots, the xprt backlog queue stats were useful in showing
when the transport (TCP) was starved by lack of RPC slots. The new dynamic
RPC slot code, commit d9ba131d8f58c0d2ff5029e7002ab43f913b36f9, always
provides an RPC slot and so only uses the xprt backlog queue when the
tcp_max_slot_table_entries value has been hit or when an allocation error
occurs. All requests are now placed on the xprt sending or pending queue which
need to be monitored for debugging.

The max_slot stat shows the maximum number of dynamic RPC slots reached which is
useful when debugging performance issues.

Add the new fields at the end of the mountstats xprt stanza so that mountstats
outputs the previous correct values and ignores the new fields. Bump
NFS_IOSTATS_VERS.

Signed-off-by: Andy Adamson 
Signed-off-by: Trond Myklebust

SUNRPC: remove an unneeded NULL check in xprt_connect()

2012-02-06T23:47:59+00:00

We check "task->tk_rqstp" and then we dereference it without checking on
the next line.  The only caller is call_connect() and that has a check
which prevents it from calling xprt_connect() with a NULL.

                if (task->tk_status < 0)
                        return;

If "task->tk_rqstp" were NULL then "tk_status" would be -EAGAIN.

Signed-off-by: Dan Carpenter 
Signed-off-by: Trond Myklebust

SUNRPC: Fix potential races in xprt_lock_write_next()

2012-02-01T00:28:08+00:00

We have to ensure that the wake up from the waitqueue and the assignment
of xprt->snd_task are atomic. We can do this by assigning the snd_task
while under the waitqueue spinlock.

Signed-off-by: Trond Myklebust

SUNRPC: Ensure we always bump the backlog queue in xprt_free_slot

2011-12-01T19:16:17+00:00

Whenever we free a slot, we know that the resulting xprt->num_reqs will
be less than xprt->max_reqs, so we know that we can release at least one
backlogged rpc_task.

Signed-off-by: Trond Myklebust 
Cc: stable@vger.kernel.org [>=3.1]

net: fix new sunrpc kernel-doc warning

2011-07-29T01:20:21+00:00

Fix new kernel-doc warning in sunrpc:

Warning(net/sunrpc/xprt.c:196): No description found for parameter 'xprt'

Signed-off-by: Randy Dunlap 
Signed-off-by: David S. Miller

SUNRPC: Replace xprt->resend and xprt->sending with a priority queue

2011-07-17T22:11:34+00:00

Signed-off-by: Trond Myklebust

SUNRPC: Support dynamic slot allocation for TCP connections

2011-07-17T22:11:30+00:00

Allow the number of available slots to grow with the TCP window size.

Signed-off-by: Trond Myklebust