linux-toradex.git/net/sunrpc, branch v4.12

SUNRPC: ensure correct error is reported by xs_tcp_setup_socket()

2017-05-31T16:26:44+00:00

If you attempt a TCP mount from an host that is unreachable in a way
that triggers an immediate error from kernel_connect(), that error
does not propagate up, instead EAGAIN is reported.

This results in call_connect_status receiving the wrong error.

A case that it easy to demonstrate is to attempt to mount from an
address that results in ENETUNREACH, but first deleting any default
route.
Without this patch, the mount.nfs process is persistently runnable
and is hard to kill.  With this patch it exits as it should.

The problem is caused by the fact that xs_tcp_force_close() eventually
calls
      xprt_wake_pending_tasks(xprt, -EAGAIN);
which causes an error return of -EAGAIN.  so when xs_tcp_setup_sock()
calls
      xprt_wake_pending_tasks(xprt, status);
the status is ignored.

Fixes: 4efdd92c9211 ("SUNRPC: Remove TCP client connection reset hack")
Signed-off-by: NeilBrown 
Signed-off-by: Trond Myklebust

xprtrdma: Delete an error message for a failed memory allocation in xprt_rdma_bc_setup()

2017-05-24T11:53:37+00:00

Omit an extra message for a memory allocation failure in this function.

This issue was detected by using the Coccinelle software.

Link: http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Refactor_Strings-WSang_0.pdf
Signed-off-by: Markus Elfring 
Reviewed-by: Chuck Lever 
Signed-off-by: Trond Myklebust

Merge tag 'nfsd-4.12' of git://linux-nfs.org/~bfields/linux

2017-05-10T20:29:23+00:00

Pull nfsd updates from Bruce Fields:
 "Another RDMA update from Chuck Lever, and a bunch of miscellaneous
  bugfixes"

* tag 'nfsd-4.12' of git://linux-nfs.org/~bfields/linux: (26 commits)
  nfsd: Fix up the "supattr_exclcreat" attributes
  nfsd: encoders mustn't use unitialized values in error cases
  nfsd: fix undefined behavior in nfsd4_layout_verify
  lockd: fix lockd shutdown race
  NFSv4: Fix callback server shutdown
  SUNRPC: Refactor svc_set_num_threads()
  NFSv4.x/callback: Create the callback service through svc_create_pooled
  lockd: remove redundant check on block
  svcrdma: Clean out old XDR encoders
  svcrdma: Remove the req_map cache
  svcrdma: Remove unused RDMA Write completion handler
  svcrdma: Reduce size of sge array in struct svc_rdma_op_ctxt
  svcrdma: Clean up RPC-over-RDMA backchannel reply processing
  svcrdma: Report Write/Reply chunk overruns
  svcrdma: Clean up RDMA_ERROR path
  svcrdma: Use rdma_rw API in RPC reply path
  svcrdma: Introduce local rdma_rw API helpers
  svcrdma: Clean up svc_rdma_get_inv_rkey()
  svcrdma: Add helper to save pages under I/O
  svcrdma: Eliminate RPCRDMA_SQ_DEPTH_MULT
  ...

NFSv4: Fix callback server shutdown

2017-04-27T22:00:16+00:00

We want to use kthread_stop() in order to ensure the threads are
shut down before we tear down the nfs_callback_info in nfs_callback_down.

Tested-and-reviewed-by: Kinglong Mee 
Reported-by: Kinglong Mee 
Fixes: bb6aeba736ba9 ("NFSv4.x: Switch to using svc_set_num_threads()...")
Signed-off-by: Trond Myklebust 
Signed-off-by: J. Bruce Fields

SUNRPC: Refactor svc_set_num_threads()

2017-04-27T21:59:58+00:00

Refactor to separate out the functions of starting and stopping threads
so that they can be used in other helpers.

Signed-off-by: Trond Myklebust 
Tested-and-reviewed-by: Kinglong Mee 
Signed-off-by: J. Bruce Fields

Merge tag 'nfs-rdma-4.12-1' of git://git.linux-nfs.org/projects/anna/nfs-rdma

2017-04-25T22:42:48+00:00

NFS: NFS over RDMA Client Side Changes

New Features:
- Break RDMA connections after a connection timeout
- Support for unloading the underlying device driver

Bugfixes and cleanups:
- Mark the receive workqueue as "read-mostly"
- Silence warnings caused by ENOBUFS
- Update a comment in xdr_init_decode_pages()
- Remove rpcrdma_buffer->rb_pool.

svcrdma: Clean out old XDR encoders

2017-04-25T21:25:56+00:00

Clean up: These have been replaced and are no longer used.

Signed-off-by: Chuck Lever 
Reviewed-by: Sagi Grimberg 
Signed-off-by: J. Bruce Fields

svcrdma: Remove the req_map cache

2017-04-25T21:25:55+00:00

req_maps are no longer used by the send path and can thus be removed.

Signed-off-by: Chuck Lever 
Reviewed-by: Sagi Grimberg 
Signed-off-by: J. Bruce Fields

svcrdma: Remove unused RDMA Write completion handler

2017-04-25T21:25:55+00:00

Clean up. All RDMA Write completions are now handled by
svc_rdma_wc_write_ctx.

Signed-off-by: Chuck Lever 
Signed-off-by: J. Bruce Fields

svcrdma: Reduce size of sge array in struct svc_rdma_op_ctxt

2017-04-25T21:25:55+00:00

The sge array in struct svc_rdma_op_ctxt is no longer used for
sending RDMA Write WRs. It need only accommodate the construction of
Send and Receive WRs. The maximum inline size is the largest payload
it needs to handle now.

Signed-off-by: Chuck Lever 
Reviewed-by: Sagi Grimberg 
Signed-off-by: J. Bruce Fields