linux-toradex.git/net/switchdev, branch v4.14-rc5

net: switchdev: Remove bridge bypass support from switchdev

2017-08-07T21:48:48+00:00

Currently the bridge port flags, vlans, FDBs and MDBs can be offloaded
through the bridge code, making the switchdev's SELF bridge bypass
implementation to be redundant. This implies several changes:
- No need for dump infra in switchdev, DSA's special case is handled
  privately.
- Remove obj_dump from switchdev_ops.
- FDBs are removed from obj_add/del routines, due to the fact that they
  are offloaded through the bridge notification chain.
- The switchdev_port_bridge_xx() and switchdev_port_fdb_xx() functions
  can be removed.

Signed-off-by: Arkadi Sharshevsky 
Reviewed-by: Vivien Didelot 
Acked-by: Jiri Pirko 
Reviewed-by: Ivan Vecera 
Reviewed-by: Florian Fainelli 
Signed-off-by: David S. Miller

net: dsa: Move FDB dump implementation inside DSA

2017-08-07T21:48:48+00:00

>From all switchdev devices only DSA requires special FDB dump. This is due
to lack of ability for syncing the hardware learned FDBs with the bridge.
Due to this it is removed from switchdev and moved inside DSA.

Signed-off-by: Arkadi Sharshevsky 
Signed-off-by: David S. Miller

net: switchdev: Change notifier chain to be atomic

2017-06-08T18:16:24+00:00

In order to use the switchdev notifier chain for FDB sync with the
device it has to be changed to atomic. The is done because the bridge
can learn new FDBs in atomic context.

Signed-off-by: Arkadi Sharshevsky 
Reviewed-by: Ido Schimmel 
Reviewed-by: Ivan Vecera 
Signed-off-by: Jiri Pirko 
Reviewed-by: Ivan Vecera 
Signed-off-by: David S. Miller

netlink: pass extended ACK struct to parsing functions

2017-04-13T17:58:22+00:00

Pass the new extended ACK reporting struct to all of the generic
netlink parsing functions. For now, pass NULL in almost all callers
(except for some in the core.)

Signed-off-by: Johannes Berg 
Signed-off-by: David S. Miller

Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net

2016-10-30T16:42:58+00:00

Mostly simple overlapping changes.

For example, David Ahern's adjacency list revamp in 'net-next'
conflicted with an adjacency list traversal bug fix in 'net'.

Signed-off-by: David S. Miller

switchdev: Remove redundant variable

2016-10-29T18:58:33+00:00

Instead of storing return value in 'err' and returning, just return
directly.

Signed-off-by: Ido Schimmel 
Reviewed-by: Jiri Pirko 
Signed-off-by: David S. Miller

switchdev: Execute bridge ndos only for bridge ports

2016-10-19T14:58:04+00:00

We recently got the following warning after setting up a vlan device on
top of an offloaded bridge and executing 'bridge link':

WARNING: CPU: 0 PID: 18566 at drivers/net/ethernet/mellanox/mlxsw/spectrum_switchdev.c:81 mlxsw_sp_port_orig_get.part.9+0x55/0x70 [mlxsw_spectrum]
[...]
 CPU: 0 PID: 18566 Comm: bridge Not tainted 4.8.0-rc7 #1
 Hardware name: Mellanox Technologies Ltd. Mellanox switch/Mellanox switch, BIOS 4.6.5 05/21/2015
  0000000000000286 00000000e64ab94f ffff880406e6f8f0 ffffffff8135eaa3
  0000000000000000 0000000000000000 ffff880406e6f930 ffffffff8108c43b
  0000005106e6f988 ffff8803df398840 ffff880403c60108 ffff880406e6f990
 Call Trace:
  [] dump_stack+0x63/0x90
  [] __warn+0xcb/0xf0
  [] warn_slowpath_null+0x1d/0x20
  [] mlxsw_sp_port_orig_get.part.9+0x55/0x70 [mlxsw_spectrum]
  [] mlxsw_sp_port_attr_get+0xa5/0xb0 [mlxsw_spectrum]
  [] switchdev_port_attr_get+0x4f/0x140
  [] switchdev_port_attr_get+0x100/0x140
  [] switchdev_port_attr_get+0x100/0x140
  [] switchdev_port_bridge_getlink+0x5b/0xc0
  [] ? switchdev_port_fdb_dump+0x90/0x90
  [] rtnl_bridge_getlink+0xe7/0x190
  [] netlink_dump+0x122/0x290
  [] __netlink_dump_start+0x15f/0x190
  [] ? rtnl_bridge_dellink+0x230/0x230
  [] rtnetlink_rcv_msg+0x1a6/0x220
  [] ? __kmalloc_node_track_caller+0x208/0x2c0
  [] ? rtnl_bridge_dellink+0x230/0x230
  [] ? rtnl_newlink+0x890/0x890
  [] netlink_rcv_skb+0xa4/0xc0
  [] rtnetlink_rcv+0x28/0x30
  [] netlink_unicast+0x18c/0x240
  [] netlink_sendmsg+0x2fb/0x3a0
  [] sock_sendmsg+0x38/0x50
  [] SYSC_sendto+0x101/0x190
  [] ? __sys_recvmsg+0x51/0x90
  [] SyS_sendto+0xe/0x10
  [] entry_SYSCALL_64_fastpath+0x1a/0xa4

The problem is that the 8021q module propagates the call to
ndo_bridge_getlink() via switchdev ops, but the switch driver doesn't
recognize the netdev, as it's not offloaded.

While we can ignore calls being made to non-bridge ports inside the
driver, a better fix would be to push this check up to the switchdev
layer.

Note that these ndos can be called for non-bridged netdev, but this only
happens in certain PF drivers which don't call the corresponding
switchdev functions anyway.

Fixes: 99f44bb3527b ("mlxsw: spectrum: Enable L3 interfaces on top of bridge devices")
Signed-off-by: Ido Schimmel 
Reported-by: Tamir Winetroub 
Tested-by: Tamir Winetroub 
Signed-off-by: Jiri Pirko 
Signed-off-by: David S. Miller

switchdev: remove FIB offload infrastructure

2016-09-28T08:48:00+00:00

Since this is now taken care of by FIB notifier, remove the code, with
all unused dependencies.

Signed-off-by: Jiri Pirko 
Signed-off-by: David S. Miller

fib: introduce FIB info offload flag helpers

2016-09-28T08:48:00+00:00

These helpers are to be used in case someone offloads the FIB entry. The
result is that if the entry is offloaded to at least one device, the
offload flag is set.

Signed-off-by: Jiri Pirko 
Reviewed-by: Ido Schimmel 
Signed-off-by: David S. Miller

rtnetlink: fdb dump: optimize by saving last interface markers

2016-09-01T23:56:15+00:00

fdb dumps spanning multiple skb's currently restart from the first
interface again for every skb. This results in unnecessary
iterations on the already visited interfaces and their fdb
entries. In large scale setups, we have seen this to slow
down fdb dumps considerably. On a system with 30k macs we
see fdb dumps spanning across more than 300 skbs.

To fix the problem, this patch replaces the existing single fdb
marker with three markers: netdev hash entries, netdevs and fdb
index to continue where we left off instead of restarting from the
first netdev. This is consistent with link dumps.

In the process of fixing the performance issue, this patch also
re-implements fix done by
commit 472681d57a5d ("net: ndo_fdb_dump should report -EMSGSIZE to rtnl_fdb_dump")
(with an internal fix from Wilson Kok) in the following ways:
- change ndo_fdb_dump handlers to return error code instead
of the last fdb index
- use cb->args strictly for dump frag markers and not error codes.
This is consistent with other dump functions.

Below results were taken on a system with 1000 netdevs
and 35085 fdb entries:
before patch:
$time bridge fdb show | wc -l
15065

real    1m11.791s
user    0m0.070s
sys 1m8.395s

(existing code does not return all macs)

after patch:
$time bridge fdb show | wc -l
35085

real    0m2.017s
user    0m0.113s
sys 0m1.942s

Signed-off-by: Roopa Prabhu 
Signed-off-by: Wilson Kok 
Signed-off-by: David S. Miller