linux-toradex.git/net/tipc/netlink_compat.c, branch v4.6-rc7

tipc: fix null deref crash in compat config path

2016-02-25T22:04:48+00:00

msg.dst_sk needs to be set up with a valid socket because some callbacks
later derive the netns from it.

Fixes: 263ea09084d172d ("Revert "genl: Add genlmsg_new_unicast() for unicast message allocation")
Reported-by: Jon Maloy 
Bisected-by: Jon Maloy 
Signed-off-by: Florian Westphal 
Acked-by Jon Maloy 
Signed-off-by: David S. Miller

Revert "genl: Add genlmsg_new_unicast() for unicast message allocation"

2016-02-18T16:42:19+00:00

This reverts commit bb9b18fb55b0 ("genl: Add genlmsg_new_unicast() for
unicast message allocation")'.

Nothing wrong with it; its no longer needed since this was only for
mmapped netlink support.

Signed-off-by: Florian Westphal 
Signed-off-by: David S. Miller

tipc: narrow down interface towards struct tipc_link

2015-11-20T19:06:10+00:00

We move the definition of struct tipc_link from link.h to link.c in
order to minimize its exposure to the rest of the code.

When needed, we define new functions to make it possible for external
entities to access and set data in the link.

Apart from the above, there are no functional changes.

Reviewed-by: Ying Xue 
Signed-off-by: Jon Maloy 
Signed-off-by: David S. Miller

tipc: narrow down exposure of struct tipc_node

2015-11-20T19:06:10+00:00

In our effort to have less code and include dependencies between
entities such as node, link and bearer, we try to narrow down
the exposed interface towards the node as much as possible.

In this commit, we move the definition of struct tipc_node, along
with many of its associated function declarations, from node.h to
node.c. We also move some function definitions from link.c and
name_distr.c to node.c, since they access fields in struct tipc_node
that should not be externally visible. The moved functions are renamed
according to new location, and made static whenever possible.

There are no functional changes in this commit.

Reviewed-by: Ying Xue 
Signed-off-by: Jon Maloy 
Signed-off-by: David S. Miller

tipc: don't sanity check non-existing TLV (NL compat)

2015-08-17T17:39:54+00:00

A zero length payload means that no TLV (Type Length Value) data has
been passed. Prior to this patch a non-existing TLV could be sanity
checked with TLV_OK() resulting in random behavior where a user
sending an empty message occasionally got a incorrect "operation not
supported" message back.

Signed-off-by: Richard Alpe 
Reviewed-by: Erik Hugne 
Signed-off-by: David S. Miller

tipc: send explicit not supported error in nl compat

2015-05-09T20:40:03+00:00

The legacy netlink API treated EPERM (permission denied) as
"operation not supported".

Reported-by: Tomi Ollila 
Signed-off-by: Richard Alpe 
Reviewed-by: Erik Hugne 
Reviewed-by: Ying Xue 
Signed-off-by: David S. Miller

tipc: fix default link prop regression in nl compat

2015-05-09T20:40:02+00:00

Default link properties can be set for media or bearer. This
functionality was missed when introducing the NL compatibility layer.

This patch implements this functionality in the compat netlink
layer. It works the same way as it did in the old API. We search for
media and bearers matching the "link name". If we find a matching
media or bearer the link tolerance, priority or window is used as
default for new links on that media or bearer.

Fixes: 37e2d4843f9e (tipc: convert legacy nl link prop set to nl compat)
Reported-by: Tomi Ollila 
Signed-off-by: Richard Alpe 
Reviewed-by: Erik Hugne 
Reviewed-by: Ying Xue 
Signed-off-by: David S. Miller

tipc: nl compat add noop and remove legacy nl framework

2015-02-09T21:20:49+00:00

Add TIPC_CMD_NOOP to compat layer and remove the old framework.

All legacy nl commands are now converted to the compat layer in
netlink_compat.c.

Signed-off-by: Richard Alpe 
Reviewed-by: Erik Hugne 
Reviewed-by: Ying Xue 
Reviewed-by: Jon Maloy 
Signed-off-by: David S. Miller

tipc: convert legacy nl stats show to nl compat

2015-02-09T21:20:49+00:00

Convert TIPC_CMD_SHOW_STATS to compat layer. This command does not
have any counterpart in the new API, meaning it now solely exists as a
function in the compat layer.

Signed-off-by: Richard Alpe 
Reviewed-by: Erik Hugne 
Reviewed-by: Ying Xue 
Reviewed-by: Jon Maloy 
Signed-off-by: David S. Miller

tipc: convert legacy nl net id get to nl compat

2015-02-09T21:20:49+00:00

Convert TIPC_CMD_GET_NETID to compat dumpit.

Signed-off-by: Richard Alpe 
Reviewed-by: Erik Hugne 
Reviewed-by: Ying Xue 
Reviewed-by: Jon Maloy 
Signed-off-by: David S. Miller