linux-toradex.git/net/tipc/socket.c, branch v2.6.32.50

net: tipc: fix information leak to userland

2011-04-14T23:53:50+00:00

commit 88f8a5e3e7defccd3925cabb1ee4d3994e5cdb52 upstream.

Structure sockaddr_tipc is copied to userland with padding bytes after
"id" field in union field "name" unitialized.  It leads to leaking of
contents of kernel stack memory.  We have to initialize them to zero.

Signed-off-by: Vasiliy Kulikov 
Signed-off-by: David S. Miller 
Cc: Moritz Muehlenhoff 
Signed-off-by: Greg Kroah-Hartman

net: Make setsockopt() optlen be unsigned.

2009-09-30T23:12:20+00:00

This provides safety against negative optlen at the type
level instead of depending upon (sometimes non-trivial)
checks against this sprinkled all over the the place, in
each and every implementation.

Based upon work done by Arjan van de Ven and feedback
from Linus Torvalds.

Signed-off-by: David S. Miller

tipc: Add socket options to get number of queued messages

2009-07-06T02:16:11+00:00

This patch allows a TIPC application to determine the number of messages
currently waiting in a socket's receive queue (TIPC_SOCK_RECVQ_DEPTH) or
in all TIPC socket receive queues (TIPC_NODE_RECVQ_DEPTH).

Signed-off-by: Oscar Medina 
Signed-off-by: Allan Stephens 
Signed-off-by: David S. Miller

tipc: Fix race condition that could cause accept() to fail

2008-07-15T05:43:32+00:00

This patch ensurs that accept() returns successfully even when
the newly created socket is immediately disconnected by its peer.
Previously, accept() would fail if it was unable to pass back
the optional address info for the socket's peer before the
socket became disconnected; TIPC now allows accept() to gather
peer address information after disconnection.  As a bonus, the
revised code accesses the socket's port more efficiently, without
the overhead incurred by a reference table lookup.

Signed-off-by: Allan Stephens 
Signed-off-by: David S. Miller

tipc: Optimize pointer dereferencing when receiving stream data

2008-07-15T05:42:51+00:00

This patch eliminates an unnecessary pointer dereference when
accessing a stream-based socket's receive queue.

Signed-off-by: Allan Stephens 
Signed-off-by: David S. Miller

tipc: Remove unneeded parameter to tipc_createport_raw()

2008-07-15T05:42:19+00:00

This patch eliminates an unneeded parameter when creating a low-level
TIPC port object.  Instead of returning both the pointer to the port
structure and the port's reference ID, it now returns only the pointer
since the port structure contains the reference ID as one of its fields.

Signed-off-by: Allan Stephens 
Signed-off-by: David S. Miller

tipc: Fix race condition when creating socket or native port

2008-05-12T22:42:28+00:00

This patch eliminates the (very remote) chance of a crash resulting
from a partially initialized socket or native port unexpectedly
receiving a message.  Now, during the creation of a socket or native
port, the underlying generic port's lock is not released until all
initialization required to handle incoming messages has been done.

Signed-off-by: Allan Stephens 
Signed-off-by: David S. Miller

net: Fix wrong interpretation of some copy_to_user() results.

2008-04-25T08:49:48+00:00

I found some places, that erroneously return the value obtained from
the copy_to_user() call: if some amount of bytes were not able to get
to the user (this is what this one returns) the proper behavior is to
return the -EFAULT error, not that number itself.

Signed-off-by: Pavel Emelyanov 
Signed-off-by: David S. Miller

[TIPC]: Overhaul of socket locking logic

2008-04-15T07:22:02+00:00

This patch modifies TIPC's socket code to follow the same approach
used by other protocols.  This change eliminates the need for a
mutex in the TIPC-specific portion of the socket protocol data
structure -- in its place, the standard Linux socket backlog queue
and associated locking routines are utilized.  These changes fix
a long-standing receive queue bug on SMP systems, and also enable
individual read and write threads to utilize a socket without
unnecessarily interfering with each other.

Signed-off-by: Allan Stephens 
Signed-off-by: David S. Miller

[TIPC]: Cosmetic changes to TIPC connect() code

2008-04-15T07:20:37+00:00

This patch fixes TIPC's connect routine to conform to Linux
kernel style norms of indentation, line length, etc.

Signed-off-by: Allan Stephens 
Signed-off-by: David S. Miller