linux-toradex.git/net/tipc/subscr.c, branch v3.0.29

tipc: Avoid recomputation of outgoing message length

2011-05-10T20:03:57+00:00

Rework TIPC's message sending routines to take advantage of the total
amount of data value passed to it by the kernel socket infrastructure.
This change eliminates the need for TIPC to compute the size of outgoing
messages itself, as well as the check for an oversize message in
tipc_msg_build().  In addition, this change warrants an explanation:

   -     res = send_packet(NULL, sock, &my_msg, 0);
   +     res = send_packet(NULL, sock, &my_msg, bytes_to_send);

Previously, the final argument to send_packet() was ignored (since the
amount of data being sent was recalculated by a lower-level routine)
and we could just pass in a dummy value (0). Now that the
recalculation is being eliminated, the argument value being passed to
send_packet() is significant and we have to supply the actual amount
of data we want to send.

Signed-off-by: Allan Stephens 
Signed-off-by: Paul Gortmaker

tipc: Minor optimization to topology service connection establishment

2011-02-23T23:05:17+00:00

Eliminates a local iovec structure containing no data, which was
previously used during the establishment of a topology service connection,
since the same effect can be achieved by passing in a NULL pointer and
an iovec length of zero.

Signed-off-by: Allan Stephens 
Signed-off-by: Paul Gortmaker

tipc: Eliminate unnecessary locking when starting topology service

2011-02-23T23:05:13+00:00

Modifies the initialization code for TIPC's topology service to
avoid taking the spinlock protecting the subscriber list, since
there is no need to do this.

Signed-off-by: Allan Stephens 
Signed-off-by: Paul Gortmaker

tipc: Combine port structure with tipc_port structure

2011-02-23T23:04:27+00:00

Merge two distinct structures containing information about a TIPC port
into a single structure. The structures were previously kept separate
so that public information about a port could be made available to
applications using TIPC's native API, while the remaining information
was kept private for use by TIPC itself. However, now that the native
API has been removed there is no longer any need for this somewhat
confusing arrangement.

Since one of the structures was already embedded within the other, the
change largely involves replacing instances of "publ.foo" with "foo".
The changes do not otherwise alter the operation of TIPC ports.

Signed-off-by: Allan Stephens 
Signed-off-by: Paul Gortmaker

tipc: remove zeroing assignments to static global variables

2011-01-01T21:57:57+00:00

Cleans up TIPC's source code to eliminate the needless initialization
of static variables to zero.

These changes are purely cosmetic and do not alter the operation of TIPC
in any way.

Signed-off-by: Allan Stephens 
Signed-off-by: Paul Gortmaker 
Signed-off-by: David S. Miller

tipc: cleanup various cosmetic whitespace issues

2011-01-01T21:57:56+00:00

Cleans up TIPC's source code to eliminate deviations from generally
accepted coding conventions relating to leading/trailing white space
and white space around commas, braces, cases, and sizeof.

These changes are purely cosmetic and do not alter the operation of TIPC
in any way.

Signed-off-by: Allan Stephens 
Signed-off-by: Paul Gortmaker 
Signed-off-by: David S. Miller

tipc: remove calls to dbg() and msg_dbg()

2011-01-01T21:57:52+00:00

Eliminates obsolete calls to two of TIPC's main debugging macros, as well
as a pair of associated debugging routines that are no longer required.

Signed-off-by: Allan Stephens 
Signed-off-by: Paul Gortmaker 
Signed-off-by: David S. Miller

tipc: Remove user registry subsystem

2011-01-01T21:57:51+00:00

Eliminates routines, data structures, and files that make up TIPC's
user registry. The user registry is no longer needed since the native
API routines that utilized it no longer exist and there are no longer
any internal TIPC services that use it.

Signed-off-by: Allan Stephens 
Signed-off-by: Paul Gortmaker 
Signed-off-by: David S. Miller

tipc: Eliminate use of user registry by topology service

2011-01-01T21:57:50+00:00

Simplifies TIPC's network topology service so that it no longer registers
its ports with the user registry, since the service doesn't take advantage
of any of the registry's capabilities.

Signed-off-by: Allan Stephens 
Signed-off-by: Paul Gortmaker 
Signed-off-by: David S. Miller

tipc: Eliminate useless initialization when creating subscriber

2010-12-02T21:34:05+00:00

Removes initialization of a local variable that is always assigned
a different value before it is referenced.

Signed-off-by: Allan Stephens 
Signed-off-by: Paul Gortmaker 
Signed-off-by: David S. Miller