linux-toradex.git/net/vmw_vsock/af_vsock.c, branch v3.15-rc8

vsock: Make transport the proto owner

2014-05-05T17:13:50+00:00

Right now the core vsock module is the owner of the proto family. This
means there's nothing preventing the transport module from unloading if
there are open sockets, which results in a panic. Fix that by allowing
the transport to be the owner, which will refcount it properly.

Includes version bump to 1.0.1.0-k

Passes checkpatch this time, I swear...

Acked-by: Dmitry Torokhov 
Signed-off-by: Andy King 
Signed-off-by: David S. Miller

net: rework recvmsg handler msg_name and msg_namelen logic

2013-11-21T02:52:30+00:00

This patch now always passes msg->msg_namelen as 0. recvmsg handlers must
set msg_namelen to the proper size <= sizeof(struct sockaddr_storage)
to return msg_name to the user.

This prevents numerous uninitialized memory leaks we had in the
recvmsg handlers and makes it harder for new code to accidentally leak
uninitialized memory.

Optimize for the case recvfrom is called with NULL as address. We don't
need to copy the address at all, so set it to NULL before invoking the
recvmsg handler. We can do so, because all the recvmsg handlers must
cope with the case a plain read() is called on them. read() also sets
msg_name to NULL.

Also document these changes in include/linux/net.h as suggested by David
Miller.

Changes since RFC:

Set msg->msg_name = NULL if user specified a NULL in msg_name but had a
non-null msg_namelen in verify_iovec/verify_compat_iovec. This doesn't
affect sendto as it would bail out earlier while trying to copy-in the
address. It also more naturally reflects the logic by the callers of
verify_iovec.

With this change in place I could remove "
if (!uaddr || msg_sys->msg_namelen == 0)
	msg->msg_name = NULL
".

This change does not alter the user visible error logic as we ignore
msg_namelen as long as msg_name is NULL.

Also remove two unnecessary curly brackets in ___sys_recvmsg and change
comments to netdev style.

Cc: David Miller 
Suggested-by: Eric Dumazet 
Signed-off-by: Hannes Frederic Sowa 
Signed-off-by: David S. Miller

Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net

2013-08-16T22:37:26+00:00

net/vmw_vsock/af_vsock.c: drop unneeded semicolon

2013-08-05T18:07:44+00:00

Drop the semicolon at the end of the list_for_each_entry loop header.

Signed-off-by: Julia Lawall 
Signed-off-by: David S. Miller

VSOCK: Move af_vsock.h and vsock_addr.h to include/net

2013-07-28T05:14:06+00:00

This is useful for other VSOCK transport implemented outside the
net/vmw_vsock/ directory to use these headers.

Signed-off-by: Asias He 
Acked-by: Andy King 
Signed-off-by: David S. Miller

VSOCK: Fix VSOCK_HASH and VSOCK_CONN_HASH

2013-06-24T06:51:48+00:00

If we mod with VSOCK_HASH_SIZE -1, we get 0, 1, .... 249.  Actually, we
have vsock_bind_table[0 ... 250] and vsock_connected_table[0 .. 250].
In this case the last entry will never be used.

We should mod with VSOCK_HASH_SIZE instead.

Signed-off-by: Asias He 
Acked-by: Andy King 
Signed-off-by: David S. Miller

VSOCK: Introduce vsock_auto_bind helper

2013-06-24T06:51:48+00:00

This peace of code is called three times, let's have a helper for it.

Signed-off-by: Asias He 
Acked-by: Andy King 
Signed-off-by: David S. Miller

VSOCK: Drop bogus __init annotation from vsock_init_tables()

2013-04-25T08:21:51+00:00

If gcc (e.g. 4.1.2) decides not to inline vsock_init_tables(), this will
cause a section mismatch:

WARNING: net/vmw_vsock/vsock.o(.text+0x1bc): Section mismatch in reference from the function __vsock_core_init() to the function .init.text:vsock_init_tables()
The function __vsock_core_init() references
the function __init vsock_init_tables().
This is often because __vsock_core_init lacks a __init
annotation or the annotation of vsock_init_tables is wrong.

This may cause crashes if VSOCKETS=y and VMWARE_VMCI_VSOCKETS=m.

Signed-off-by: Geert Uytterhoeven 
Signed-off-by: David S. Miller

VSOCK: Fix misc device registration

2013-04-25T08:21:22+00:00

When we call vsock_core_init to init VSOCK the second time,
vsock_device.minor still points to the old dynamically allocated minor
number. misc_register will allocate it for us successfully as if we were
asking for a static one. However, when other user call misc_register to
allocate a dynamic minor number, it will give the one used by
vsock_core_init(), causing this:

  [  405.470687] WARNING: at fs/sysfs/dir.c:536 sysfs_add_one+0xcc/0xf0()
  [  405.470689] Hardware name: OptiPlex 790
  [  405.470690] sysfs: cannot create duplicate filename '/dev/char/10:54'

Always set vsock_device.minor to MISC_DYNAMIC_MINOR before we
register.

Cc: "David S. Miller" 
Cc: Andy King 
Cc: Dmitry Torokhov 
Cc: Reilly Grant 
Cc: netdev@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Asias He 
Acked-by: Dmitry Torokhov 
Signed-off-by: David S. Miller

VSOCK: Fix missing msg_namelen update in vsock_stream_recvmsg()

2013-04-07T20:28:02+00:00

The code misses to update the msg_namelen member to 0 and therefore
makes net/socket.c leak the local, uninitialized sockaddr_storage
variable to userland -- 128 bytes of kernel stack memory.

Cc: Andy King 
Cc: Dmitry Torokhov 
Cc: George Zhang 
Signed-off-by: Mathias Krause 
Signed-off-by: David S. Miller