linux-toradex.git/net/wireless/util.c, branch v3.4.12

cfg80211: fix interface combinations check for ADHOC(IBSS)

2012-08-15T15:10:33+00:00

partial of commit 8e8b41f9d8c8e63fc92f899ace8da91a490ac573 upstream.

As part of commit 463454b5dbd8 ("cfg80211: fix interface
combinations check"), this extra check was introduced:

       if ((all_iftypes & used_iftypes) != used_iftypes)
               goto cont;

However, most wireless NIC drivers did not advertise ADHOC in
wiphy.iface_combinations[i].limits[] and hence we'll get -EBUSY
when we bring up a ADHOC wlan with commands similar to:

 # iwconfig wlan0 mode ad-hoc && ifconfig wlan0 up

In commit 8e8b41f9d8c8e ("cfg80211: enforce lack of interface
combinations"), the change below fixes the issue:

       if (total == 1)
               return 0;

But it also introduces other dependencies for stable. For example,
a full cherry pick of 8e8b41f9d8c8e would introduce additional
regressions unless we also start cherry picking driver specific
fixes like the following:

  9b4760e  ath5k: add possible wiphy interface combinations
  1ae2fc2  mac80211_hwsim: advertise interface combinations
  20c8e8d  ath9k: add possible wiphy interface combinations

And the purpose of the 'if (total == 1)' is to cover the specific
use case (IBSS, adhoc) that was mentioned above. So we just pick
the specific part out from 8e8b41f9d8c8e here.

Doing so gives stable kernels a way to fix the change introduced
by 463454b5dbd8, without having to make cherry picks specific to
various NIC drivers.

Signed-off-by: Liang Li 
Signed-off-by: Paul Gortmaker 
Signed-off-by: Greg Kroah-Hartman

cfg80211: process pending events when unregistering net device

2012-08-15T15:10:32+00:00

commit 1f6fc43e621167492ed4b7f3b4269c584c3d6ccc upstream.

libertas currently calls cfg80211_disconnected() when it is being
brought down. This causes an event to be allocated, but since the
wdev is already removed from the rdev by the time that the event
processing work executes, the event is never processed or freed.
http://article.gmane.org/gmane.linux.kernel.wireless.general/95666

Fix this leak, and other possible situations, by processing the event
queue when a device is being unregistered. Thanks to Johannes Berg for
the suggestion.

Signed-off-by: Daniel Drake 
Reviewed-by: Johannes Berg 
Signed-off-by: John W. Linville 
Signed-off-by: Greg Kroah-Hartman

cfg80211: check iface combinations only when iface is running

2012-07-19T15:58:59+00:00

commit f8cdddb8d61d16a156229f0910f7ecfc7a82c003 upstream.

Don't validate interface combinations on a stopped
interface. Otherwise we might end up being able to
create a new interface with a certain type, but
won't be able to change an existing interface
into that type.

This also skips some other functions when
interface is stopped and changing interface type.

Signed-off-by: Michal Kazior 
Signed-off-by: Johannes Berg 
[Fixes regression introduced by cherry pick of 463454b5dbd8]
Signed-off-by: Paul Gortmaker

cfg80211: fix interface combinations check

2012-06-17T18:21:26+00:00

commit 463454b5dbd8dbab6e2fc6c557329e5b811b9c32 upstream.

If a given interface combination doesn't contain
a required interface type then we missed checking
that and erroneously allowed it even though iface
type wasn't there at all. Add a check that makes
sure that all interface types are accounted for.

Reported-by: Mohammed Shafi Shajakhan 
Signed-off-by: Johannes Berg 
Signed-off-by: John W. Linville 
Signed-off-by: Greg Kroah-Hartman

cfg80211: fix interface combinations check.

2012-04-13T18:05:35+00:00

Signed-off-by: Lukasz Kucharczyk 
Cc: stable@vger.kernel.org
Signed-off-by: John W. Linville

cfg80211: expose cfg80211_calculate_bitrate()

2012-03-06T20:16:17+00:00

Signed-off-by: Thomas Pedersen 
Reviewed-by: Johannes Berg 
Signed-off-by: John W. Linville

wireless: Treat IPv6 diffserv the same as IPv4 for 802.11e

2012-01-04T19:30:43+00:00

Wireless will select a different hardware queue based on the
top 3 bits of the diffserv field, for ipv4. Extend that queue
selection mechanism to ipv6, and make the calls orthogonal.

Signed-off-by: Dave TÃ¤ht 
Signed-off-by: John W. Linville

cfg80211: Fix race in bss timeout

2011-12-13T20:30:28+00:00

It is quite possible to run into a race in bss timeout where
the drivers see the bss entry just before notifying cfg80211
of a roaming event but it got timed out by the time rdev->event_work
got scehduled from cfg80211_wq. This would result in the following
WARN-ON() along with the failure to notify the user space of
the roaming. The other situation which is happening with ath6kl
that runs into issue is when the driver reports roam to same AP
event where the AP bss entry already got expired. To fix this,
move cfg80211_get_bss() from __cfg80211_roamed() to cfg80211_roamed().

[158645.538384] WARNING: at net/wireless/sme.c:586
__cfg80211_roamed+0xc2/0x1b1()
[158645.538810] Call Trace:
[158645.538838]  [] warn_slowpath_common+0x65/0x7a
[158645.538917]  [] ? __cfg80211_roamed+0xc2/0x1b1
[158645.538946]  [] warn_slowpath_null+0xf/0x13
[158645.539055]  [] __cfg80211_roamed+0xc2/0x1b1
[158645.539086]  [] cfg80211_process_rdev_events+0x153/0x1cc
[158645.539166]  [] cfg80211_event_work+0x26/0x36
[158645.539195]  [] process_one_work+0x219/0x38b
[158645.539273]  [] ? wiphy_new+0x419/0x419
[158645.539301]  [] worker_thread+0xf6/0x1bf
[158645.539379]  [] ? rescuer_thread+0x1b5/0x1b5
[158645.539407]  [] kthread+0x62/0x67
[158645.539484]  [] ? __init_kthread_worker+0x42/0x42
[158645.539514]  [] kernel_thread_helper+0x6/0xd

Reported-by: Kalle Valo 
Signed-off-by: Vasanthakumar Thiagarajan 
Signed-off-by: John W. Linville

Merge branch 'master' of git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux

2011-11-22T19:05:46+00:00

Conflicts:
	drivers/net/wireless/iwlegacy/iwl-debugfs.c
	drivers/net/wireless/iwlegacy/iwl-rx.c
	drivers/net/wireless/iwlegacy/iwl-scan.c
	drivers/net/wireless/iwlegacy/iwl-tx.c
	include/net/bluetooth/bluetooth.h

cfg80211: work around a sparse issue

2011-11-21T21:22:10+00:00

sparse reports:
net/wireless/util.c:499:30: error: cannot size expression
net/wireless/util.c:503:30: error: cannot size expression

This is evidently due to the EXPORT_SYMBOL() of the
bridge_tunnel_header and rfc1042 header variables.
Move them to the end of the file to work around the
sparse issue. The error itself from sparse can be
ignored safely, but since sparse stops parsing at
errors, other issues after this would go undetected.

Signed-off-by: Johannes Berg 
Signed-off-by: John W. Linville