linux-toradex.git/net/wireless, branch v2.6.38.8

nl80211: Fix set_key regression with some drivers

2011-06-03T01:33:49+00:00

commit 0e579d6a8f4aea346da818f13ee71401c125e639 upstream.

Commit dbd2fd656f2060abfd3a16257f8b51ec60f6d2ed added a mechanism for
user space to indicate whether a default key is being configured for
only unicast or only multicast frames instead of all frames. This
commit added a driver capability flag for indicating whether separate
default keys are supported and validation of the set_key command based
on that capability.

However, this single capability flag is not enough to cover possible
difference based on mode (AP/IBSS/STA) and the way this change was
introduced resulted in a regression with drivers that do not indicate
the new capability (i.e.., more or less any non-mac80211 driver using
cfg80211) when using a recent wpa_supplicant snapshot.

Fix the regression by removing the new check which is not strictly
speaking needed. The new separate default key functionality is needed
only for RSN IBSS which has a separate capability indication.

Signed-off-by: Jouni Malinen 
Signed-off-by: John W. Linville 
Signed-off-by: Greg Kroah-Hartman

Merge branch 'master' of git://git.kernel.org/pub/scm/linux/kernel/git/linville/wireless-2.6

2011-02-22T19:53:05+00:00

fix cfg80211_wext_siwfreq lock ordering...

2011-02-21T20:14:25+00:00

I previously managed to reproduce a hang while scanning wireless
channels (reproducible with airodump-ng hopping channels); subsequent
lockdep instrumentation revealed a lock ordering issue.

Without knowing the design intent, it looks like the locks should be
taken in reverse order; please comment.

=======================================================
[ INFO: possible circular locking dependency detected ]
2.6.38-rc5-341cd #4
-------------------------------------------------------
airodump-ng/15445 is trying to acquire lock:
 (&rdev->devlist_mtx){+.+.+.}, at: []
cfg80211_wext_siwfreq+0xc6/0x100

but task is already holding lock:
 (&wdev->mtx){+.+.+.}, at: [] cfg80211_wext_siwfreq+0xbc/0x100

which lock already depends on the new lock.

the existing dependency chain (in reverse order) is:

-> #1 (&wdev->mtx){+.+.+.}:
       [] lock_acquire+0xc6/0x280
       [] mutex_lock_nested+0x6e/0x4b0
       [] cfg80211_netdev_notifier_call+0x430/0x5f0
       [] notifier_call_chain+0x8b/0x100
       [] raw_notifier_call_chain+0x11/0x20
       [] call_netdevice_notifiers+0x32/0x60
       [] __dev_notify_flags+0x34/0x80
       [] dev_change_flags+0x40/0x70
       [] do_setlink+0x1fc/0x8d0
       [] rtnl_setlink+0xf2/0x140
       [] rtnetlink_rcv_msg+0x163/0x270
       [] netlink_rcv_skb+0xa1/0xd0
       [] rtnetlink_rcv+0x20/0x30
       [] netlink_unicast+0x2ba/0x300
       [] netlink_sendmsg+0x267/0x3e0
       [] sock_sendmsg+0xe4/0x110
       [] sys_sendmsg+0x253/0x3b0
       [] system_call_fastpath+0x16/0x1b

-> #0 (&rdev->devlist_mtx){+.+.+.}:
       [] __lock_acquire+0x1622/0x1d10
       [] lock_acquire+0xc6/0x280
       [] mutex_lock_nested+0x6e/0x4b0
       [] cfg80211_wext_siwfreq+0xc6/0x100
       [] ioctl_standard_call+0x5d/0xd0
       [] T.808+0x163/0x170
       [] wext_handle_ioctl+0x3a/0x90
       [] dev_ioctl+0x6f2/0x830
       [] sock_ioctl+0xfd/0x290
       [] do_vfs_ioctl+0x9d/0x590
       [] sys_ioctl+0x4a/0x80
       [] system_call_fastpath+0x16/0x1b

other info that might help us debug this:

2 locks held by airodump-ng/15445:
 #0:  (rtnl_mutex){+.+.+.}, at: [] rtnl_lock+0x12/0x20
 #1:  (&wdev->mtx){+.+.+.}, at: []
cfg80211_wext_siwfreq+0xbc/0x100

stack backtrace:
Pid: 15445, comm: airodump-ng Not tainted 2.6.38-rc5-341cd #4
Call Trace:
 [] ? print_circular_bug+0xfa/0x100
 [] ? __lock_acquire+0x1622/0x1d10
 [] ? trace_hardirqs_off_caller+0x29/0xc0
 [] ? lock_acquire+0xc6/0x280
 [] ? cfg80211_wext_siwfreq+0xc6/0x100
 [] ? mark_held_locks+0x67/0x90
 [] ? mutex_lock_nested+0x6e/0x4b0
 [] ? cfg80211_wext_siwfreq+0xc6/0x100
 [] ? mark_held_locks+0x67/0x90
 [] ? cfg80211_wext_siwfreq+0xc6/0x100
 [] ? cfg80211_wext_siwfreq+0xc6/0x100
 [] ? ioctl_standard_call+0x5d/0xd0
 [] ? __dev_get_by_name+0x9b/0xc0
 [] ? ioctl_standard_call+0x0/0xd0
 [] ? T.808+0x163/0x170
 [] ? might_fault+0x72/0xd0
 [] ? wext_handle_ioctl+0x3a/0x90
 [] ? might_fault+0xbb/0xd0
 [] ? dev_ioctl+0x6f2/0x830
 [] ? put_lock_stats+0xe/0x40
 [] ? lock_release_holdtime+0xac/0x150
 [] ? sock_ioctl+0xfd/0x290
 [] ? do_vfs_ioctl+0x9d/0x590
 [] ? fget_light+0x1df/0x3c0
 [] ? sys_ioctl+0x4a/0x80
 [] ? system_call_fastpath+0x16/0x1b

Signed-off-by: Daniel J Blueman 
Acked-by: Johannes Berg 
Signed-off-by: John W. Linville

kconfig: rename CONFIG_EMBEDDED to CONFIG_EXPERT

2011-01-21T01:02:05+00:00

The meaning of CONFIG_EMBEDDED has long since been obsoleted; the option
is used to configure any non-standard kernel with a much larger scope than
only small devices.

This patch renames the option to CONFIG_EXPERT in init/Kconfig and fixes
references to the option throughout the kernel.  A new CONFIG_EMBEDDED
option is added that automatically selects CONFIG_EXPERT when enabled and
can be used in the future to isolate options that should only be
considered for embedded systems (RISC architectures, SLOB, etc).

Calling the option "EXPERT" more accurately represents its intention: only
expert users who understand the impact of the configuration changes they
are making should enable it.

Reviewed-by: Ingo Molnar 
Acked-by: David Woodhouse 
Signed-off-by: David Rientjes 
Cc: Greg KH 
Cc: "David S. Miller" 
Cc: Jens Axboe 
Cc: Arnd Bergmann 
Cc: Robin Holt 
Cc: 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

cfg80211: fix transposition of words in printk

2011-01-04T19:43:01+00:00

Fixes the misplaced article in the following:

"cfg80211: Updating information on frequency 5785 MHz for
    20 a MHz width channel with regulatory rule:"

Signed-off-by: Bob Copeland 
Signed-off-by: John W. Linville

nl80211: Export available antennas

2010-12-20T19:49:47+00:00

Export the information which antennas are available for configuration as TX or
RX antennas via nl80211.

Signed-off-by: Bruno Randolf 
Signed-off-by: John W. Linville

cfg80211: Separate available antennas for RX and TX

2010-12-20T19:46:58+00:00

As has been pointed out by Daniel Halperin some devices (e.g. Intel IWL5100)
can only TX from a subset of RX antennas, so use separate availability masks
for RX and TX.

Signed-off-by: Bruno Randolf 
Signed-off-by: John W. Linville

mac80211: Send mesh non-HWMP path selection frames to userspace

2010-12-20T19:46:58+00:00

Let path selection frames for protocols other than HWMP be sent to
userspace via NL80211_CMD_REGISTER_FRAME.  Also allow userspace to send
and receive mesh path selection frames.

Signed-off-by: Javier Cardona 
Signed-off-by: John W. Linville

mac80211: Let userspace enable and configure vendor specific path selection.

2010-12-20T19:46:57+00:00

Userspace will now be allowed to toggle between the default path
selection algorithm (HWMP, implemented in the kernel), and a vendor
specific alternative.  Also in the same patch, allow userspace to add
information elements to mesh beacons.  This is accordance with the
Extensible Path Selection Framework specified in version 7.0 of the
802.11s draft.

Signed-off-by: Javier Cardona 
Signed-off-by: John W. Linville

mac80211: Rename mesh_params to mesh_config to prepare for mesh_setup

2010-12-20T19:46:57+00:00

Mesh parameters can be to setup a mesh or to configure it.
This patch renames the ambiguous name mesh_params to mesh_config
in preparation for mesh_setup.

Signed-off-by: Javier Cardona 
Signed-off-by: John W. Linville