linux-toradex.git/samples/vfio-mdev/mtty.c, branch v6.2-rc2

vfio/ap/ccw/samples: Fix device_register() unwind path

2022-12-05T19:37:54+00:00

We always need to call put_device() if device_register() fails.
All vfio drivers calling device_register() include a similar unwind
stack via gotos, therefore split device_unregister() into its
device_del() and put_device() components in the unwind path, and
add a goto target to handle only the put_device() requirement.

Reported-by: Ruan Jinjie 
Link: https://lore.kernel.org/all/20221118032827.3725190-1-ruanjinjie@huawei.com
Fixes: d61fc96f47fd ("sample: vfio mdev display - host device")
Fixes: 9d1a546c53b4 ("docs: Sample driver to demonstrate how to use Mediated device framework.")
Fixes: a5e6e6505f38 ("sample: vfio bochs vbe display (host device for bochs-drm)")
Fixes: 9e6f07cd1eaa ("vfio/ccw: create a parent struct")
Fixes: 36360658eb5a ("s390: vfio_ap: link the vfio_ap devices to the vfio_ap bus subsystem")
Cc: Tony Krowiak 
Cc: Halil Pasic 
Cc: Jason Herne 
Cc: Kirti Wankhede 
Reviewed-by: Kevin Tian 
Reviewed-by: Eric Farman 
Reviewed-by: Tony Krowiak 
Reviewed-by: Jason J. Herne 
Link: https://lore.kernel.org/r/166999942139.645727.12439756512449846442.stgit@omen
Signed-off-by: Alex Williamson

vfio: Remove vfio_free_device

2022-11-10T18:30:23+00:00

With the "mess" sorted out, we should be able to inline the
vfio_free_device call introduced by commit cb9ff3f3b84c
("vfio: Add helpers for unifying vfio_device life cycle")
and remove them from driver release callbacks.

Signed-off-by: Eric Farman 
Reviewed-by: Jason Gunthorpe 
Reviewed-by: Kevin Tian 
Reviewed-by: Cornelia Huck 
Reviewed-by: Tony Krowiak 	# vfio-ap part
Reviewed-by: Matthew Rosato 
Link: https://lore.kernel.org/r/20221104142007.1314999-8-farman@linux.ibm.com
Signed-off-by: Alex Williamson

vfio/mdev: consolidate all the available_instance sysfs into the core code

2022-10-04T18:06:58+00:00

Every driver just print a number, simply add a method to the mdev_driver
to return it and provide a standard sysfs show function.

Signed-off-by: Christoph Hellwig 
Reviewed-by: Jason Gunthorpe 
Reviewed-by: Kevin Tian 
Reviewed-by: Kirti Wankhede 
Reviewed-by: Eric Farman 
Link: https://lore.kernel.org/r/20220923092652.100656-13-hch@lst.de
Signed-off-by: Alex Williamson

vfio/mdev: consolidate all the name sysfs into the core code

2022-10-04T18:06:58+00:00

Every driver just emits a static string, simply add a field to the
mdev_type for the driver to fill out or fall back to the sysfs name and
provide a standard sysfs show function.

Signed-off-by: Christoph Hellwig 
Reviewed-by: Jason Gunthorpe 
Reviewed-by: Kevin Tian 
Reviewed-by: Kirti Wankhede 
Reviewed-by: Eric Farman 
Link: https://lore.kernel.org/r/20220923092652.100656-12-hch@lst.de
Signed-off-by: Alex Williamson

vfio/mdev: consolidate all the device_api sysfs into the core code

2022-10-04T18:06:58+00:00

Every driver just emits a static string, simply feed it through the ops
and provide a standard sysfs show function.

Signed-off-by: Jason Gunthorpe 
Signed-off-by: Christoph Hellwig 
Reviewed-by: Tony Krowiak 
Reviewed-by: Kevin Tian 
Reviewed-by: Kirti Wankhede 
Reviewed-by: Eric Farman 
Link: https://lore.kernel.org/r/20220923092652.100656-11-hch@lst.de
Signed-off-by: Alex Williamson

vfio/mdev: simplify mdev_type handling

2022-10-04T18:06:58+00:00

Instead of abusing struct attribute_group to control initialization of
struct mdev_type, just define the actual attributes in the mdev_driver,
allocate the mdev_type structures in the caller and pass them to
mdev_register_parent.

This allows the caller to use container_of to get at the containing
structure and thus significantly simplify the code.

Signed-off-by: Christoph Hellwig 
Reviewed-by: Jason Gunthorpe 
Reviewed-by: Tony Krowiak 
Reviewed-by: Kevin Tian 
Reviewed-by: Kirti Wankhede 
Reviewed-by: Eric Farman 
Link: https://lore.kernel.org/r/20220923092652.100656-6-hch@lst.de
Signed-off-by: Alex Williamson

vfio/mdev: embedd struct mdev_parent in the parent data structure

2022-10-04T18:06:58+00:00

Simplify mdev_{un}register_device by requiring the caller to pass in
a structure allocate as part of the parent device structure.  This
removes the need for a list of parents and the separate mdev_parent
refcount as we can simplify rely on the reference to the parent device.

Signed-off-by: Christoph Hellwig 
Reviewed-by: Jason Gunthorpe 
Reviewed-by: Tony Krowiak 
Reviewed-by: Kevin Tian 
Reviewed-by: Kirti Wankhede 
Reviewed-by: Eric Farman 
Link: https://lore.kernel.org/r/20220923092652.100656-5-hch@lst.de
Signed-off-by: Alex Williamson

vfio/mdev: make mdev.h standalone includable

2022-10-04T18:06:58+00:00

Include  and  so that users of this headers
don't need to do that and remove those includes that aren't needed
any more.

Signed-off-by: Christoph Hellwig 
Reviewed-by: Eric Farman 
Reviewed-by: Jason Gunthorpe 
Reviewed-by: Tony Krowiak 
Reviewed-by: Kevin Tian 
Reviewed-by: Kirti Wankhede 
Link: https://lore.kernel.org/r/20220923092652.100656-4-hch@lst.de
Signed-off-by: Alex Williamson

vfio/mtty: Use the new device life cycle helpers

2022-09-21T20:15:11+00:00

and manage available ports inside @init/@release.

Signed-off-by: Yi Liu 
Signed-off-by: Kevin Tian 
Reviewed-by: Jason Gunthorpe 
Link: https://lore.kernel.org/r/20220921104401.38898-7-kevin.tian@intel.com
Signed-off-by: Alex Williamson

vfio/mdev: Remove mdev_parent_ops

2022-04-21T11:36:56+00:00

The last useful member in this struct is the supported_type_groups, move
it to the mdev_driver and delete mdev_parent_ops.

Replace it with mdev_driver as an argument to mdev_register_device()

Signed-off-by: Jason Gunthorpe 
Signed-off-by: Christoph Hellwig 
Signed-off-by: Zhi Wang 
Link: http://patchwork.freedesktop.org/patch/msgid/20220411141403.86980-33-hch@lst.de
Reviewed-by: Kirti Wankhede 
Reviewed-by: Zhi Wang