linux-toradex.git/scripts/checkpatch.pl, branch v3.14.3

checkpatch: fix detection of git repository

2014-02-11T00:01:40+00:00

Since git v1.7.7, the .git directory can be a file when, for example,
the kernel is a submodule of another git super project.  So, the check
"-d .git" is not working anymore in this case.  Using a more generic
check like "-e .git" corrects this behaviour.

Signed-off-by: Richard Genoud 
Cc: Andy Whitcroft 
Cc: Joe Perches 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

checkpatch.pl: check for function declarations without arguments

2014-01-28T05:02:40+00:00

Functions like this one are evil:

void foo()
{
	...
}

Because these functions allow variadic arguments without
checking the arguments at all.

Original patch by Richard Weinberger.

Signed-off-by: Joe Perches 
Cc: Richard Weinberger 
Cc: Borislav Petkov 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

checkpatch: prefer ether_addr_copy to memcpy(foo, bar, ETH_ALEN)

2014-01-24T00:36:58+00:00

ether_addr_copy was added for kernel version 3.14.  It's slightly
smaller/faster for some arches.  Encourage its use.

Signed-off-by: Joe Perches 
Cc: Andy Whitcroft 
Cc: David Miller 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

checkpatch: add DT compatible string documentation checks

2014-01-24T00:36:58+00:00

This adds a simple check that any compatible strings in DeviceTree dts
files are present in Documentation/devicetree/bindings.  Vendor prefixes
are also checked for existing in vendor-prefixes.txt These should be
temporary checks until we have more sophisticated binding schema
checking.

Signed-off-by: Rob Herring 
Signed-off-by: Joe Perches 
Cc: Grant Likely 
Cc: Andy Whitcroft 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

checkpatch: only flag FSF address, not gnu.org URL

2014-01-24T00:36:58+00:00

This change restricts the check for the for the FSF address in the GPL
copyright statement so that it only flags the address, not the
references to the gnu.org/licenses URL which appears to be used in
numerous drivers.  The idea is to still allow some reference to an
external copy of the GPL in the event that files are copied out of the
kernel tree without the COPYING file.

So for example this statement will still return an error:
  You should have received a copy of the GNU General Public License
  along with this program; if not, write to the Free Software
  Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA.

However, this statement will not return an error after this patch:
  You should have received a copy of the GNU General Public License
  along with this program.  If not, see .

Signed-off-by: Alexander Duyck 
Cc: Joe Perches 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

checkpatch: add tests for function pointer style misuses

2014-01-24T00:36:58+00:00

Kernel style uses function pointers in this form:
	"type (*funcptr)(args...)"

Emit warnings when this function pointer form isn't used.

Signed-off-by: Joe Perches 
Cc: Andy Whitcroft 
Cc: Derek Perrin 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

checkpatch: update the FSF/GPL address check

2014-01-24T00:36:58+00:00

The FSF address check is a bit too verbose looking for the GPL text.
Quiet it a bit by requiring --strict for the GPL bit.

Also make the address tests match a few uses of abbreviations for street
names and make it case insensitive.

Signed-off-by: Joe Perches 
Reviewed-by: Josh Triplett 
Cc: Manfred Spraul 
Cc: Andy Whitcroft 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

checkpatch: check for if's with unnecessary parentheses

2014-01-24T00:36:58+00:00

If statements don't need multiple parentheses around tested comparisons
like "if ((foo == bar))".

An == comparison maybe a sign of an intended assignment, so emit a
slightly different message if so.

Signed-off-by: Joe Perches 
Reviewed-by: Josh Triplett 
Cc: Manfred Spraul 
Cc: Andy Whitcroft 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

checkpatch: improve space before tab --fix option

2014-01-24T00:36:58+00:00

This test should remove all the spaces before a tab not just one space.

Substitute a tab for each 8 space block before a tab and remove less than
8 spaces before a tab.

This SPACE_BEFORE_TAB test is done after CODE_INDENT.

If there are spaces used at the beginning of a line that should be
converted to tabs, please make sure that the CODE_INDENT test and
conversion is done before this SPACE_BEFORE_TAB test and conversion.

Reported-by: Manfred Spraul 
Signed-off-by: Joe Perches 
Cc: Josh Triplett 
Cc: Andy Whitcroft 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

checkpatch: add a --fix-inplace option

2014-01-24T00:36:58+00:00

Add the ability to fix and overwrite existing files/patches instead of
creating a new file ".EXPERIMENTAL-checkpatch-fixes".

Suggested-by: Manfred Spraul 
Signed-off-by: Joe Perches 
Reviewed-by: Josh Triplett 
Cc: Andy Whitcroft 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds