linux-toradex.git/scripts/checkpatch.pl, branch v3.15-rc6

checkpatch: don't warn on bitfield spaces around :

2014-04-03T23:21:16+00:00

This test prevents code from being aligned around the : for easy visual
counting of bitfield lengths.

ie:
	int foo		: 1,
	int bar		: 2,
	int foobar	:29;

should be acceptable so remove the test.

Signed-off-by: Joe Perches 
Suggested-by: Dan Carpenter 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

checkpatch: expand parenthesis alignment test to declarations, functions and assignments

2014-04-03T23:21:15+00:00

Currently the parenthesis alignment test works only on misalignments of
if statements like

	if (foo(bar,
			baz)

Expand the test to find misalignments like:

static inline int foo(int bar,
			int baz)

and

	foo(bar,
			baz);

and

	foo = bar(baz,
			qux);

Expand the $Inline keyword for __inline and __inline__ too.
Add $Inline to $Declare so it also matches "static inline ".

These checks are only performed with --strict.

Signed-off-by: Joe Perches 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

checkpatch.pl: add check for Change-Id

2014-04-03T23:21:15+00:00

A commit hook for the Gerrit code review server [1] inserts change
identifiers so Gerrit can track patches through multiple revisions.
These identifiers are noise in the context of the upstream kernel.
(Many Gerrit servers are private.  Even given a public instance, given
only a Change-Id, one must guess which server a change was tracked on.
Patches submitted to the Linux kernel mailing lists should be able to
stand on their own.  If it's truly useful to reference code review on a
Gerrit server, a URL is a much clearer way to do so.) Thus, issue an
error when a Change-Id line is encountered before the Signed-off-by.

1. https://gerrit.googlesource.com/gerrit/+/master/gerrit-server/src/main/resources/com/google/gerrit/server/tools/root/hooks/commit-msg

Signed-off-by: Christopher Covington 
Cc: Joe Perches 
Cc: Andy Whitcroft 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

scripts/checkpatch.pl: __GFP_NOFAIL isn't going away

2014-04-03T23:21:15+00:00

Revert commit 7e4915e78992 ("checkpatch: add warning of future
__GFP_NOFAIL use").

There are no plans to remove __GFP_NOFAIL.

__GFP_NOFAIL exists to

a) centralise the retry-allocation-for-ever operation into the core
   allocator, which is the appropriate implementation site and

b) permit us to identify code sites which aren't handling memory
   exhaustion appropriately.

Cc: David Rientjes 
Cc: Joe Perches 
Cc: Theodore Ts'o 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

checkpatch: net and drivers/net: warn on missing blank line after variable declaration

2014-04-03T23:21:15+00:00

Networking prefers this style, so warn when it's not used.

Networking uses:

    void foo(int bar)
    {
        int baz;

        code...
   }

not

    void foo(int bar)
    {
        int baz;
        code...
    }

There are a limited number of false positives when using macros to
declare variables like:

  WARNING: networking uses a blank line after declarations
  #330: FILE: net/ipv4/inet_hashtables.c:330:
  +	int dif = sk->sk_bound_dev_if;
  +	INET_ADDR_COOKIE(acookie, saddr, daddr)

Signed-off-by: Joe Perches 
Cc: David Miller 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

checkpatch: improve the compatible vendor match

2014-04-03T23:21:15+00:00

Improve the vendor name match in vendor-prefix.txt by only matching the
exact vendor name at the beginning of lines.

Signed-off-by: Florian Vaussard 
Cc: Joe Perches 
Acked-by: Rob Herring 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

checkpatch: check compatible strings in .c and .h too

2014-04-03T23:21:15+00:00

Look for ".compatible = "foo" strings not only in .dts files, but
in .c and .h too.

Signed-off-by: Florian Vaussard 
Cc: Joe Perches 
Acked-by: Rob Herring 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

checkpatch: fix spurious vendor compatible warnings

2014-04-03T23:21:14+00:00

With a compatible string like

  compatible = "foo";

checkpatch will currently try to find "foo" in vendor-prefixes.txt,
which is wrong since the vendor prefix is empty in this specific case.

Skip the vendor test if the compatible is not like

  compatible = "vendor,something";

Signed-off-by: Florian Vaussard 
Cc: Joe Perches 
Acked-by: Rob Herring 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

checkpatch: check vendor compatible with dashes

2014-04-03T23:21:14+00:00

The current vendor compatible check will not match vendors with dashes,
like:

  compatible="asahi-kasei"

Signed-off-by: Florian Vaussard 
Reported-by: Joe Perches 
Acked-by: Rob Herring 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

checkpatch: improve octal permissions test speed

2014-04-03T23:21:14+00:00

The current octal permissions test is very slow.

When patch ("checkpatch: add checks for constant non-octal permissions")
was added, processing time approximately tripled.

Regain almost all of the performance by not looping through all the
possible functions unless the line contains one of the functions.

Signed-off-by: Joe Perches 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds