linux-toradex.git/scripts/checkpatch.pl, branch v3.17-rc4

checkpatch: relax check for length of git commit IDs

2014-08-29T23:28:15+00:00

Checkpatch currently warns if a git commit ID (in the changelog,
usually) is less than 12 characters or more than 16.  The "more than 16"
is excessive.  Change the check so we accept IDs from 12 to 40 chars in
length.

Cc: Geert Uytterhoeven 
Signed-off-by: Linus Torvalds

checkpatch: update $declaration_macros, add uninitialized_var

2014-08-07T01:01:29+00:00

Using uninitialized_var reports a false positive for "Missing blank line
after declarations".

Fix it by adding uninitialized_var to the $declaration_macros exceptions
list.

Move the macro list after $Type is declared.

Add optional prefixes to DECLARE_ and DEFINE_
macro declarations to allow forms like:
	MLX4_DECLARE_DOORBELL_LOCK

Signed-off-by: Joe Perches 
Reported-by: Dotan Barak 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

checkpatch: warn on missing spaces in broken up quoted

2014-08-07T01:01:29+00:00

Checkpatch already complains when people break up quoted strings but
it's still pretty common.  One mistake that people often make is they
leave out the space character between the two strings.

This check adds around 450 new warnings and has a low rate of false
positives.

Signed-off-by: Dan Carpenter 
Cc: Andy Whitcroft 
Acked-by: Joe Perches 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

checkpatch: fix false positives for --strict "space after cast" test

2014-08-07T01:01:29+00:00

Commit 89da401f6cff ("checkpatch: improve "no space after cast" test")
in -next improved the cast test for non pointer types, but also
introduced false positives for some types of static inlines.

Add a test for an open brace to the exclusions to avoid these false
positives.

Signed-off-by: Joe Perches 
Reported-by: Hartley Sweeten 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

checkpatch: fix false positive MISSING_BREAK warnings with --file

2014-08-07T01:01:29+00:00

Using --file mode can give false positives with MISSING_BREAK
fall-through warnings on simple but long multiple consecutive case
statements.

Look for all lines before a case statement for a switch or a statement
when using --file mode.

Fix a misspelling of preceded while there.

Signed-off-by: Joe Perches 
Reported-by: Lee Jones 
Acked-by: Lee Jones 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

checkpatch: add test for native c90 types in unusual order

2014-08-07T01:01:29+00:00

c90 section "6.7.2 Type Specifiers" says:
    "type specifiers may occur in any order"

That means that:
    short int is the same as int short
    unsigned short int is the same as int unsigned short
    etc...

checkpatch currently parses only a subset of these allowed types.

For instance: "unsigned short" and "signed short" are found by
checkpatch as a specific type, but none of the or "int short" or "int
signed short" variants are found.

Add another table for the "kernel style misordered" variants.

Add this misordered table to the findable types.

Warn when the misordered style is used.

This improves the "Missing a blank line after declarations" test as it
depends on the correct parsing of the $Declare variable which looks for
"$Type $Ident;" (ie: declarations like "int foo;").

Signed-off-by: Joe Perches 
Acked-by: Andy Whitcroft 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

checkpatch: add signed generic types

2014-08-07T01:01:29+00:00

Current generic types are unsigned or unspecified.  Add signed to the
types.

Reorder the types to find the longest match first.

Signed-off-by: Joe Perches 
Acked-by: Andy Whitcroft 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

checkpatch: add short int to c variable types

2014-08-07T01:01:29+00:00

short int is one of the 6.7.2 c90 types.
Find it appropriately.

This fixes a defect in checkpatch where it suggests that a line break
after declaration is required using an input like:

	int foo;
	short int bar;

Without this change, it warns on the short int line.

Signed-off-by: Joe Perches 
Reported-by: Hartley Sweeten 
Acked-by: Andy Whitcroft 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

checkpatch: add for_each tests to indentation and brace tests

2014-08-07T01:01:29+00:00

All the various for_each loop macros were not tested for trailing brace
on the following lines and for bad indentation.

Add them.

Signed-off-by: Joe Perches 
Reported-by: Greg KH 
Cc: Andy Whitcroft 
Signed-off-by: Linus Torvalds

checkpatch: fix brace style misuses of else and while

2014-08-07T01:01:28+00:00

Add --fix corrections for ELSE_AFTER_BRACE and WHILE_AFTER_BRACE
misuses.

	if (x) {
		...
	}
	else {
		...
	}

is corrected to

	if (x) {
		...
	} else {
		...
	}

and

	do {
		...
	}
	while (x);

is corrected to

	do {
		...
	} while (x);

Signed-off-by: Joe Perches 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds