linux-toradex.git/scripts/coccicheck, branch v5.19-rc3

scripts: coccicheck: fix troubles on non-English builds

2021-05-18T09:09:59+00:00

When LANG is not set to English, the logic which checks the
number of CPUs fail, as the messages can be localized, and
the logic at:

    THREADS_PER_CORE=$(lscpu | grep "Thread(s) per core: " | tr -cd "[:digit:]")

will not get the number of threads per core.

This causes the script to not run properly, as it will produce
a warning:

	$ make coccicheck COCCI=$PWD/scripts/coccinelle/misc/add_namespace.cocci MODE=report drivers/media/
	./scripts/coccicheck: linha 93: [: número excessivo de argumentos

Fix it by forcing LANG=C when calling lscpu.

Signed-off-by: Mauro Carvalho Chehab 
Signed-off-by: Julia Lawall

scripts: coccicheck: Correct usage of make coccicheck

2020-12-24T11:59:43+00:00

The command "make coccicheck C=1 CHECK=scripts/coccicheck" results in the
error:
        ./scripts/coccicheck: line 65: -1: shift count out of range

This happens because every time the C variable is specified,
the shell arguments need to be "shifted" in order to take only
the last argument, which is the C file to test. These shell arguments
mostly comprise flags that have been set in the Makefile. However,
when coccicheck is specified in the make command as a rule, the
number of shell arguments is zero, thus passing the invalid value -1
to the shift command, resulting in an error.

Modify coccicheck to print correct usage of make coccicheck so as to
avoid the error.

Signed-off-by: Sumera Priyadarsini 
Signed-off-by: Julia Lawall

kbuild: do not use scripts/ld-version.sh for checking spatch version

2020-12-12T17:31:29+00:00

scripts/ld-version.sh was, as its file name implies, originally intended
for the GNU ld version, but is (ab)used for the spatch version too.

Use 'sort -CV' for the version comparison, then coccicheck does not need
to use scripts/ld-version.sh. Fix nsdeps as well.

Signed-off-by: Masahiro Yamada 
Signed-off-by: Julia Lawall

scripts: coccicheck: Change default condition for parallelism

2020-10-12T08:37:56+00:00

Currently, Coccinelle uses at most one thread per core by default in
machines with more than 2 hyperthreads. However, for systems with only 4
hyperthreads, this does not improve performance.

Modify coccicheck to use all available threads in machines with
upto 4 hyperthreads.

Signed-off-by: Sumera Priyadarsini 
Signed-off-by: Julia Lawall

scripts: coccicheck: Add quotes to improve portability

2020-10-12T08:32:40+00:00

While fetching the number of threads per core with lscpu,
the [:digit:] set is used for translation of digits from 0-9.
However, using [:digit:] instead of "[:digit:]" does not seem
to work uniformly for some shell types and configurations
(such as zsh).

Therefore, modify coccicheck to use double quotes around the
[:digit:] set for uniformity and better portability.

Signed-off-by: Sumera Priyadarsini 
Signed-off-by: Julia Lawall

scripts: coccicheck: Change default value for parallelism

2020-09-27T20:52:59+00:00

By default, coccicheck utilizes all available threads to implement
parallelisation. However, when all available threads are used,
a decrease in performance is noted. The elapsed time is  minimum
when at most one thread per core is used.

For example, on benchmarking the semantic patch kfree.cocci for
usb/serial using hyperfine, the outputs obtained for J=5 and J=2
are 1.32 and 1.90 times faster than those for J=10 and J=9
respectively for two separate runs. For the larger drivers/staging
directory, minimium elapsed time is obtained for J=3 which is 1.86
times faster than that for J=12. The optimal J value does not
exceed 6 in any of the test runs. The benchmarks are run on a machine
with 6 cores, with 2 threads per core, i.e, 12 hyperthreads in all.

To improve performance, modify coccicheck to use at most only
one thread per core by default.

Signed-off-by: Sumera Priyadarsini 
Signed-off-by: Julia Lawall

scripts: coccicheck: Improve error feedback when coccicheck fails

2020-09-13T20:13:01+00:00

Currently, coccicheck fails with only the message "coccicheck failed"
and the error code for the failure. To obtain the error logs,
one needs to specify a debug file using the DEBUG_FILE option.

Modify coccicheck to display error logs when it crashes unless
DEBUG_FILE is set, in which case, the error logs are stored in
the specified debug file.

Signed-off-by: Sumera Priyadarsini 
Signed-off-by: Julia Lawall

scripts: coccicheck: Add chain mode to list of modes

2020-08-21T20:34:49+00:00

This patch adds chain mode to the list of available modes in coccicheck.

Signed-off-by: Sumera Priyadarsini 
Signed-off-by: Julia Lawall

coccicheck: return proper error code on fail

2018-08-13T23:58:56+00:00

If coccicheck fails, it should return an error code distinct from zero
to signal about an internal problem. Current code instead of exiting with
the tool's error code returns the error code of 'echo "coccicheck failed"'
which is almost always equals to zero, thus failing the original intention
of alerting about a problem. This patch fixes the code.

Found by Linux Driver Verification project (linuxtesting.org).

Signed-off-by: Denis Efremov 
Acked-by: Julia Lawall 
Signed-off-by: Masahiro Yamada

Coccinelle: coccicheck: fix typo

2018-02-01T15:21:47+00:00

Correct spelling of "coccinelle".

Signed-off-by: Julia Lawall 
Signed-off-by: Masahiro Yamada