linux-toradex.git/scripts/coccinelle/free, branch v5.0

coccinelle: devm_free: reduce false positives

2018-02-07T14:53:09+00:00

Some files use both a non-devm allocation and a devm_allocation.  Don't
complain about a free when the same function contains a non-devm
allocation.

Signed-off-by: Julia Lawall 
Signed-off-by: Masahiro Yamada

Coccinelle: ifnullfree: Trim the warning reported in report mode

2018-01-16T14:39:55+00:00

Remove the unncessary part of the warning reported, in the report
mode, so that a single warning produced does not exceed more than line
and hence improve readability of the warnings produced in the subsequent
reports to a file.

Signed-off-by: Himanshu Jha 
Acked-by: Julia Lawall 
Signed-off-by: Masahiro Yamada

coccinelle: catch krealloc() on devm_*() allocated memory

2016-06-21T09:43:32+00:00

krealloc() must not be used against devm_*() allocated
memory regions:

- if a bigger memory is to be allocated, krealloc() and
  __krealloc() could return a different pointer than the
  one given to them, creating a memory region which is not
  managed, thus it will not be automatically released on
  device removal.

- if a bigger memory is to be allocated, krealloc() could
  kfree() the managed memory region which is passed to it.
  The old pointer is left registered as a resource for the
  device. On device removal, this dangling pointer will be
  used and an unrelated memory region could be released.

- if the requested size is equal to 0, krealloc() can also
  just behave like kfree(). Here too, the old pointer is
  kept associated with the device. On device removal, this
  invalid pointer will be used and an unrelated memory
  region could be released.

For all these reasons, krealloc() must not be used on a
pointer returned by devm_*() functions.

Cc: Tejun Heo 
Cc: Pekka Enberg 
Acked-by: Julia Lawall 
Signed-off-by: Yann Droneaud 
Signed-off-by: Michal Marek

coccinelle: recognize more devm_* memory allocation functions

2016-06-21T09:43:32+00:00

Updates free/devm_free.cocci to recognize functions added by:

- commit 64c862a839a8 ('devres: add kernel standard devm_k.alloc functions')
- commit e31108cad3de ('devres: introduce API "devm_kstrdup"')
- commit 3046365bb470 ('devres: introduce API "devm_kmemdup')
- commit 43339bed7010 ('devres: Add devm_get_free_pages API')
- commit 75f2a4ead5d5 ('devres: Add devm_kasprintf and devm_kvasprintf API')

See also Documentation/driver-model/devres.txt

Cc: Joe Perches 
Cc: Manish Badarkhe 
Cc: Srinivas Pandruvada 
Cc: Eli Billauer 
Cc: Himangi Saraogi 
Cc: Geert Uytterhoeven 
Cc: Wolfram Sang 
Cc: Daniel Thompson 
Acked-by: Julia Lawall 
Signed-off-by: Yann Droneaud 
Signed-off-by: Michal Marek

coccinelle: also catch kzfree() issues

2016-06-21T09:43:32+00:00

Since commit 3ef0e5ba4673 ('slab: introduce kzfree()'),
kfree() is no more the only function to be considered:
kzfree() should be recognized too.

In particular, kzfree() must not be called on memory
allocated through devm_*() functions.

Cc: Johannes Weiner 
Acked-by: Julia Lawall 
Signed-off-by: Yann Droneaud 
Signed-off-by: Michal Marek

coccinelle: ifnullfree: handle various destroy functions

2015-10-26T21:41:18+00:00

Extend ifnullfree to the various destroy functions that were recently
extended to tolerate NULL arguments.

Signed-off-by: Julia Lawall 
Signed-off-by: Michal Marek

coccinelle: ifnullfree: various cleanups

2015-10-26T21:41:13+00:00

Adjust tests to compare against NULL, to match cases that explicitly make
that comparison.

Remove removal and re-addition of freeing functions.

Add position variable on usb_free_urb in the non-patch case.

Signed-off-by: Julia Lawall 
Signed-off-by: Michal Marek

scripts/coccinelle/free/ifnullfree.cocci: add copyright information

2014-08-08T22:57:27+00:00

All coccinelle scripts have a copyright in the header.

Signed-off-by: Fabian Frederick 
Suggested-by: Julia Lawall 
Acked-by: Julia Lawall 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

scripts/coccinelle/free: add NULL test before freeing functions

2014-08-08T22:57:26+00:00

Warns or generates patch for NULL check before the following functions:

kfree
usb_free_urb
debugfs_remove
debugfs_remove_recursive

Signed-off-by: Fabian Frederick 
Acked-by: Julia Lawall 
Cc: Gilles Muller 
Cc: Joe Perches 
Cc: Markus Elfring 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

Coccinelle: Update the options used to the new option scheme

2013-07-03T20:58:13+00:00

spatch has changed its option scheme.
E.g., --no_show_diff is now --no-show-diff

This patch updates:
 - scripts/coccicheck
 - Semantic patches under scripts/coccinelle/

Signed-off-by: Nicolas Palix 
Signed-off-by: Michal Marek