linux-toradex.git/scripts/coccinelle, branch v4.9.16

Coccinelle: flag conditions with no effect

2016-10-11T07:57:17+00:00

Report code constructs where the if and else branch are functionally
identical. In cases where this is intended it really should be
documented - most reported cases probably are bugs.

Signed-off-by: Nicholas Mc Guire 
Signed-off-by: Michal Marek

Coccinelle: pm_runtime: ensure relevance of pm_runtime reports

2016-10-01T21:03:41+00:00

pm_runtime.cocci starts with one rule that searches for a variety of
functions calls, followed by various rules that report errors.  Previously,
the only connection between the first rule and the rest was to check that
the first rule had matched somewhere.  Change the rules to propagate a
position from the first rule to the others, to make sure that the sites
reported on are the same as the sites that were identified as having the
relevant functions.

Signed-off-by: Julia Lawall 
Signed-off-by: Michal Marek

Coccinelle: limit memdup_user transformation to GFP_KERNEL case

2016-10-01T21:03:09+00:00

Memdup_user encapsulates a memory allocation with the flag GFP_KERNEL, so
only allow this flag in the original code.

Signed-off-by: Julia Lawall 
Signed-off-by: Michal Marek

scripts/coccinelle: require coccinelle >= 1.0.4 on device_node_continue.cocci

2016-07-22T10:13:39+00:00

Make use of the new Requires: tag to be able to specify coccinelle binary
version requirements. The cocci file device_node_continue.cocci requires at
least coccinelle 1.0.4.

Signed-off-by: Luis R. Rodriguez 
Acked-by: Julia Lawall 
Acked-by: Nicolas Palix 
Signed-off-by: Michal Marek

coccinelle: catch krealloc() on devm_*() allocated memory

2016-06-21T09:43:32+00:00

krealloc() must not be used against devm_*() allocated
memory regions:

- if a bigger memory is to be allocated, krealloc() and
  __krealloc() could return a different pointer than the
  one given to them, creating a memory region which is not
  managed, thus it will not be automatically released on
  device removal.

- if a bigger memory is to be allocated, krealloc() could
  kfree() the managed memory region which is passed to it.
  The old pointer is left registered as a resource for the
  device. On device removal, this dangling pointer will be
  used and an unrelated memory region could be released.

- if the requested size is equal to 0, krealloc() can also
  just behave like kfree(). Here too, the old pointer is
  kept associated with the device. On device removal, this
  invalid pointer will be used and an unrelated memory
  region could be released.

For all these reasons, krealloc() must not be used on a
pointer returned by devm_*() functions.

Cc: Tejun Heo 
Cc: Pekka Enberg 
Acked-by: Julia Lawall 
Signed-off-by: Yann Droneaud 
Signed-off-by: Michal Marek

coccinelle: recognize more devm_* memory allocation functions

2016-06-21T09:43:32+00:00

Updates free/devm_free.cocci to recognize functions added by:

- commit 64c862a839a8 ('devres: add kernel standard devm_k.alloc functions')
- commit e31108cad3de ('devres: introduce API "devm_kstrdup"')
- commit 3046365bb470 ('devres: introduce API "devm_kmemdup')
- commit 43339bed7010 ('devres: Add devm_get_free_pages API')
- commit 75f2a4ead5d5 ('devres: Add devm_kasprintf and devm_kvasprintf API')

See also Documentation/driver-model/devres.txt

Cc: Joe Perches 
Cc: Manish Badarkhe 
Cc: Srinivas Pandruvada 
Cc: Eli Billauer 
Cc: Himangi Saraogi 
Cc: Geert Uytterhoeven 
Cc: Wolfram Sang 
Cc: Daniel Thompson 
Acked-by: Julia Lawall 
Signed-off-by: Yann Droneaud 
Signed-off-by: Michal Marek

coccinelle: also catch kzfree() issues

2016-06-21T09:43:32+00:00

Since commit 3ef0e5ba4673 ('slab: introduce kzfree()'),
kfree() is no more the only function to be considered:
kzfree() should be recognized too.

In particular, kzfree() must not be called on memory
allocated through devm_*() functions.

Cc: Johannes Weiner 
Acked-by: Julia Lawall 
Signed-off-by: Yann Droneaud 
Signed-off-by: Michal Marek

Coccinelle: noderef: Add new rules and correct the old rule

2016-06-20T15:20:13+00:00

Add new rules to detect the cases where sizeof is used in
function calls as a argument.

Also, for the patch mode third rule should behave same as
second rule with arguments reversed. So, change that as well.

Signed-off-by: Vaishali Thakkar 
Acked-by: Julia Lawall 
Signed-off-by: Michal Marek

Merge branch 'misc' of git://git.kernel.org/pub/scm/linux/kernel/git/mmarek/kbuild

2016-05-27T05:32:05+00:00

Pull misc kbuild updates from Michal Marek:
 "This is the non-critical part of kbuild:

   - Coccinelle fixes, one semantic patch less in this round [Vaishali
     Thakkar, Wolfram Sang, Kees Cook]

   - rpm-pkg support for (open)SUSE's update-bootloader [Jiří Kosian]

   - rpm-pkg restored support for $RPMOPTS [Srinivas Pandruvada]

   - deb-pkg fixes for the linux-headers package [Bjørn Mork, Azriel
     Samson]"

* 'misc' of git://git.kernel.org/pub/scm/linux/kernel/git/mmarek/kbuild:
  coccicheck: Fix missing 0 index in kill loop
  scripts/package/Makefile: rpmbuild add support of RPMOPTS
  builddeb: fix missing headers in linux-headers package
  builddeb: include objtool binary in headers package
  kbuild/mkspec: support 'update-bootloader'-based systems
  scripts: coccinelle: remove check to move constants to right
  Coccinelle: setup_timer: Add space in front of parentheses

scripts: coccinelle: remove check to move constants to right

2016-04-20T07:53:27+00:00

The header mentions this check depends on personal taste. I agree.
Running coccicheck on patches before I apply them, this SmPL produced
enough false positives for me that I'd rather see it removed.

Signed-off-by: Wolfram Sang 
Acked-by: Julia Lawall 
Signed-off-by: Michal Marek