linux-toradex.git/scripts/kconfig/confdata.c, branch tegra-10.11.7

kconfig: fix savedefconfig with choice marked optional

2010-08-14T22:32:12+00:00

savedefconfig failed to save the correct minimal config
when it encountered a choice marked optional.

Consider following minimal configuration:
$cat Kconfig
choice
	prompt "choice"
	optional

config A
	bool "a"

config B
	bool "b"

endchoice

$cat .config | grep -v ^#
CONFIG_A=y

$conf --savedefconfig=defconfig Kconfig

would before this fix result in an empty file, because
kconfig would assume that CONFIG_A=y is a default value.
But because the choice is optional the default is that
both A and B are =n.

Fix so we handle optional choices correct.

Signed-off-by: Sam Ravnborg 
Signed-off-by: Michal Marek

kconfig: Fix warning: ignoring return value of 'fwrite'

2010-08-12T22:40:26+00:00

This fix facilitates fwrite() in both confdata.c and expr.c, either it
succeeds in writing, or an error occurs, or the end of file is reached.

Signed-off-by: Jean Sacren 
Signed-off-by: Michal Marek

kconfig: fix tristate choice with minimal config

2010-08-12T08:55:02+00:00

If a minimal config did not specify the value
of all choice values, the resulting configuration
could have wrong values.

Consider following example:
config M
        def_bool y
        option modules
choice
        prompt "choice list"
config A
        tristate "a"
config B
	tristate "b"
endchoice

With a defconfig like this:
CONFIG_M=y
CONFIG_A=y

The resulting configuration would have

    CONFIG_A=m

which was unexpected.

The problem was not not all choice values were set and thus
kconfig calculated a wrong value.

The fix is to set all choice values when we
read a defconfig files.

conf_set_all_new_symbols() is refactored such that
random choice values are now handled by a dedicated function.
And new choice values are set by set_all_choice_values().

This was not the minimal fix, but the fix that resulted
in the most readable code.

Signed-off-by: Sam Ravnborg 
Reported-by: Arve Hjønnevåg 
Tested-by: Arve Hjønnevåg 
Signed-off-by: Michal Marek

kconfig: fix savedefconfig for tristate choices

2010-08-12T08:55:02+00:00

savedefconfig failed to save choice symbols equal to 'y'
for tristate choices.
This resulted in this value being lost.

In particular is fixes an issue where

	make ARCH=avr32 atngw100_defconfig
	make ARCH=avr32 savedefconfig
	cp defconfig arch/avr32/configs/atngw100_defconfig
	make ARCH=avr32 atngw100_defconfig
	diff -u .config .config.old

failed to produce an identical .config.

Signed-off-by: Sam Ravnborg 
Signed-off-by: Michal Marek

kconfig: add savedefconfig

2010-08-03T11:49:32+00:00

savedefconfig will save a minimal config to a file
named "defconfig".

The config symbols are saved in the same order as
they appear in the menu structure so it should
be possible to map them to the relevant menus
if desired.

The implementation was tested against several minimal
configs for arm which was created using brute-force.

There was one regression related to default numbers
which had their valid range further limited by another symbol.

Sample:

config FOO
	int "foo"
	default 4

config BAR
	int "bar"
	range 0 FOO

If FOO is set to 3 then BAR cannot take a value higher than 3.
But the current implementation will set BAR equal to 4.

This is seldomly used and the final configuration is OK,
and the fix was non-trivial.
So it was documented in the code and left as is.

Signed-off-by: Sam Ravnborg 
Acked-by: Uwe Kleine-König 
Signed-off-by: Michal Marek

kconfig: code refactoring in confdata.c

2010-08-03T11:49:32+00:00

Add a a few local functions to avoid some code duplication
No functional changes.

Signed-off-by: Sam Ravnborg 
Signed-off-by: Michal Marek

kconfig: fix MODULES-related bug in case of no .config

2010-07-29T14:56:02+00:00

There seems to be a kconfig bug due to MODULES not always being
evaluated if no .config is found. Take the following Kconfig as an
example:

config MODULES
	def_bool y

config FOO
	def_tristate m

With no .config, the following configuration is generated:

CONFIG_MODULES=y
CONFIG_FOO=y

With an empty .config, the following:

CONFIG_MODULES=y
CONFIG_FOO=m

Tristate choice statements can also exhibit the problem, due to having an
implicit rev_dep (select) containing "m".

The problem is that MODULES is never evaluted in conf_read_simple() unless
there's a .config. The following patch fixes this.

Signed-off-by: Ulf Magnusson 
Reviewed-by: WANG Cong 
Signed-off-by: Michal Marek

kconfig: make randconfig fair for booleans

2010-07-26T13:40:52+00:00

Give boolean symbols a 50% chance of getting enabled, rather than 67%.

Signed-off-by: Peter Korsgaard 
Acked-by: Sam Ravnborg 
Signed-off-by: Michal Marek

kbuild: generate modules.builtin

2009-12-12T12:08:16+00:00

To make it easier for module-init-tools and scripts like mkinitrd to
distinguish builtin and missing modules, install a modules.builtin file
listing all builtin modules. This is done by generating an additional
config file (tristate.conf) with tristate options set to uppercase 'Y'
or 'M'. If we source that config file, the builtin modules appear in
obj-Y.

Signed-off-by: Michal Marek

kbuild: move autoconf.h to include/generated

2009-12-12T12:08:15+00:00

Signed-off-by: Sam Ravnborg 
Signed-off-by: Michal Marek