linux-toradex.git/scripts/kconfig/menu.c, branch v4.11-rc3

Kconfig: Introduce the "imply" keyword

2016-11-16T08:26:33+00:00

The "imply" keyword is a weak version of "select" where the target
config symbol can still be turned off, avoiding those pitfalls that come
with the "select" keyword.

This is useful e.g. with multiple drivers that want to indicate their
ability to hook into a secondary subsystem while allowing the user to
configure that subsystem out without also having to unset these drivers.

Currently, the same effect can almost be achieved with:

config DRIVER_A
	tristate

config DRIVER_B
	tristate

config DRIVER_C
	tristate

config DRIVER_D
	tristate

[...]

config SUBSYSTEM_X
	tristate
	default DRIVER_A || DRIVER_B || DRIVER_C || DRIVER_D || [...]

This is unwieldy to maintain especially with a large number of drivers.
Furthermore, there is no easy way to restrict the choice for SUBSYSTEM_X
to y or n, excluding m, when some drivers are built-in. The "select"
keyword allows for excluding m, but it excludes n as well. Hence
this "imply" keyword.  The above becomes:

config DRIVER_A
	tristate
	imply SUBSYSTEM_X

config DRIVER_B
	tristate
	imply SUBSYSTEM_X

[...]

config SUBSYSTEM_X
	tristate

This is much cleaner, and way more flexible than "select". SUBSYSTEM_X
can still be configured out, and it can be set as a module when none of
the drivers are configured in or all of them are modular.

Signed-off-by: Nicolas Pitre 
Acked-by: Richard Cochran 
Acked-by: Thomas Gleixner 
Acked-by: John Stultz 
Reviewed-by: Josh Triplett 
Cc: Paul Bolle 
Cc: linux-kbuild@vger.kernel.org
Cc: netdev@vger.kernel.org
Cc: Michal Marek 
Cc: Edward Cree 
Link: http://lkml.kernel.org/r/1478841010-28605-2-git-send-email-nicolas.pitre@linaro.org
Signed-off-by: Thomas Gleixner

kconfig: return 'false' instead of 'no' in bool function

2016-01-05T10:19:13+00:00

menu_is_visible() is a bool function and should use boolean return
values. "no" is a tristate value which happens to also have a value
of 0, but we should nevertheless use the right symbol for it.

This is a very minor cleanup with no semantic change.

Fixes: 86e187ff9 ("kconfig: add an option to determine a menu's visibility")
Cc: Arnaud Lacombe 
Cc: Mauro Carvalho Chehab 
Signed-off-by: Vegard Nossum 
Signed-off-by: Michal Marek

kconfig: Remove unnecessary prototypes from headers

2015-02-25T14:00:17+00:00

Signed-off-by: Michal Marek

kconfig: Fix warning "‘jump’ may be used uninitialized"

2014-11-28T13:39:13+00:00

Warning:
In file included from scripts/kconfig/zconf.tab.c:2537:0:
scripts/kconfig/menu.c: In function ‘get_symbol_str’:
scripts/kconfig/menu.c:590:18: warning: ‘jump’ may be used uninitialized in this function [-Wmaybe-uninitialized]
     jump->offset = strlen(r->s);

Simplifies the test logic because (head && local) means (jump != 0)
and makes GCC happy when checking if the jump pointer was initialized.

Signed-off-by: Peter Kümmel 
Signed-off-by: Michal Marek

kbuild: trivial - use tabs for code indent where possible

2014-06-10T12:00:53+00:00

Signed-off-by: Masahiro Yamada 
Signed-off-by: Michal Marek

kconfig: make allnoconfig disable options behind EMBEDDED and EXPERT

2014-04-07T23:36:09+00:00

"make allnoconfig" exists to ease testing of minimal configurations.
Documentation/SubmitChecklist includes a note to test with allnoconfig.
This helps catch missing dependencies on common-but-not-required
functionality, which might otherwise go unnoticed.

However, allnoconfig still leaves many symbols enabled, because they're
hidden behind CONFIG_EMBEDDED or CONFIG_EXPERT.  For instance, allnoconfig
still has CONFIG_PRINTK and CONFIG_BLOCK enabled, so drivers don't
typically get build-tested with those disabled.

To address this, introduce a new Kconfig option "allnoconfig_y", used on
symbols which only exist to hide other symbols.  Set it on CONFIG_EMBEDDED
(which then selects CONFIG_EXPERT).  allnoconfig will then disable all the
symbols hidden behind those.

Signed-off-by: Josh Triplett 
Tested-by: Paul E. McKenney 
Cc: Michal Marek 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

kconfig: fix bug in search results string: use strlen(gstr->s), not gstr->len

2013-10-08T21:52:16+00:00

The struct gstr has a capacity that may differ from the actual string length.

However, a string manipulation in the function search_conf made the assumption
that it is the same, which led to messing up some search results, especially
when the content of the gstr in use had not yet reached at least 63 chars.

Signed-off-by: Martin Walch 
Acked-by: Wang YanQing 
Acked-by: Benjamin Poirier 
Reviewed-by: "Yann E. MORIN" 
Signed-off-by: "Yann E. MORIN"

kconfig: adjust warning message for conflicting types

2013-10-08T21:52:15+00:00

Each symbol must have exactly one type assigned. However, if a symbol happens
to have two different types assigned at runtime, a warning is printed and the
first type is preserved while the second type is being ignored.

The warning message says

type of  redefined from  to 

which may be misleading as it may create the impression that the second type
replaces the first type.

This patch clarifies this by changing the warning to

ignoring type redefinition of  from  to 

Signed-off-by: Martin Walch 
Acked-by: Wang YanQing 
Reviewed-by: "Yann E. MORIN" 
Signed-off-by: "Yann E. MORIN"

kconfig: fix trivial typos and update mconf documentation

2013-10-08T21:52:14+00:00

This fixes lots of typos in comments and strings.

It also updates the documentation strings in mconf to reflect the changes in
the user interface from the two commits

6364fd0cb1e4c7f72b974613e0cf5744ae4d2cb2
  menuconfig: Add Save/Load buttons
1bdbac478a858d2aa73a6784c7c2e09de0f6d06b
  menuconfig: Get rid of the top-level entries for "Load an Alternate/Save an Alternate"

And it updates the layout of the example search result, i. e. moves down the
"Defined at" and "Depends on" lines and adds a symbol state ([=n]) to the
symbol in the "Selected by" line.

Furthermore, the help texts now should fit in 80 columns again when viewed
in mconf.

Signed-off-by: Martin Walch 
Reviewed-by: Jean Delvare 
Reviewed-by: Wang YanQing 
Signed-off-by: "Yann E. MORIN"

kconfig: do not allow more than one symbol to have 'option modules'

2013-09-05T09:10:08+00:00

Previously, it was possible to have more than one symbol with the
'option modules' attached to them, although only the last one would
in fact control tristates.

Since this does not make much sense, only allow at most one symbol to
control tristates.

Note: it is still possible to have more than one symbol that control
tristates, but indirectly:

    config MOD1
        bool "mod1"
        select MODULES
    config MOD2
        bool "mod2"
        select MODULES
    config MODULES
        bool
        option modules

Signed-off-by: "Yann E. MORIN" 
Cc: Sam Ravnborg 
Signed-off-by: Michal Marek