linux-toradex.git/scripts/kconfig/nconf.c, branch tegra-next

kconfig/nconf: remove useless conditionnal

2011-07-13T11:54:01+00:00

After the test

	if (!submenu || ...)
		continue;

the variable `submenu' can _not_ be NULL, so do not test for this
situation.

Cc: Nir Tzachar 
Signed-off-by: Arnaud Lacombe 
Signed-off-by: Michal Marek

kconfig/nconf: prevent segfault on empty menu

2011-07-13T11:48:11+00:00

nconf does not check the validity of the current menu when help is
requested (with either , '?' or 'h'). This leads to a NULL pointer
dereference when an empty menu is encountered.

The following reduced testcase exposes the problem:

config DEP
        bool

menu "FOO"

config BAR
        bool "BAR"
        depends on DEP

endmenu

Issue will happen when entering menu "FOO" and requesting help.

nconf is the only front-end which do not filter the validity of the
current menu. Such filter can not really happen beforehand as other key
which does not deals with the current menu might be entered by the user,
so just bails out earlier if we encounter an invalid menu.

Cc: Nir Tzachar 
Cc: Andrej Gelenberg 
Reported-by: Andrej Gelenberg 
Signed-off-by: Arnaud Lacombe 
Signed-off-by: Michal Marek

kconfig/nconf: use the generic menu_get_ext_help()

2011-07-13T11:48:08+00:00

nconf is the only front-end which does not use this helper, but prefer
to copy/paste the code. The test wrt. menu validity added in this
version of the code is bogus anyway as an invalid menu will get
dereferenced a few line below by calling menu_get_prompt().

For now, convert nconf to use menu_get_ext_help(), as do every other
front-end. We will deals with menu validity checks properly in a
separate commit.

Cc: Nir Tzachar 
Cc: Andrej Gelenberg 
Signed-off-by: Arnaud Lacombe 
Signed-off-by: Michal Marek

nconfig: Avoid Wunused-but-set warning

2011-07-13T11:47:09+00:00

I am seeing Wunused-but-set warning while make nconfig.  Looks like
active_menu is not used. Removing it fixes the warning.

Signed-off-by: Raghavendra D Prabhu 
Acked-by: WANG Cong 
Signed-off-by: Michal Marek

kconfig: nuke LKC_DIRECT_LINK cruft

2011-06-06T19:32:20+00:00

This interface is not (and has never been ?) used by any frontend, just get rid
of it.

Signed-off-by: Arnaud Lacombe

nconfig: Silence unused return values from wattrset

2011-04-19T07:21:52+00:00

Ignore the return value from wattrset since we ignore the return
value in nconf.gui.c as well.

scripts/kconfig/nconf.c: In function 'print_function_line':
scripts/kconfig/nconf.c:376: warning: value computed is not used
scripts/kconfig/nconf.c:380: warning: value computed is not used
scripts/kconfig/nconf.c:387: warning: value computed is not used
scripts/kconfig/nconf.c: In function 'show_menu':
scripts/kconfig/nconf.c:956: warning: value computed is not used
scripts/kconfig/nconf.c:961: warning: value computed is not used
scripts/kconfig/nconf.c:963: warning: value computed is not used
scripts/kconfig/nconf.c:965: warning: value computed is not used

Cc: Nir Tzachar 
Signed-off-by: Stephen Boyd 
Signed-off-by: Michal Marek

nconf: handle comment entries within choice/endchoice

2011-01-07T14:45:28+00:00

Equivalent to af6c1598 (kconfig: handle comment entries within
choice/endchoice), but for nconfig instead.

Implement support for comment entries within choice groups. Comment entries
are displayed visually distinct from normal configs, and selecting them is
a no-op.

Signed-off-by: Peter Korsgaard 
Signed-off-by: Michal Marek

kbuild/nconf: fix spaces damage

2010-12-15T13:42:11+00:00

Signed-off-by: Arnaud Lacombe 
Signed-off-by: Michal Marek

Merge branch 'message-callback' into kbuild/kconfig

2010-10-27T22:54:25+00:00

Conflicts:
	scripts/kconfig/nconf.c

Merge branch 'kbuild/kconfig/kbuild-generic-v7' of http://github.com/lacombar/linux-2.6 into kbuild/kconfig

2010-09-27T21:24:53+00:00

* 'kbuild/kconfig/kbuild-generic-v7' of http://github.com/lacombar/linux-2.6:
  kbuild: migrate all arch to the kconfig mainmenu upgrade
  kconfig: expand file names
  kconfig: use the file's name of sourced file
  kconfig: constify file name
  kconfig: don't emit warning upon rootmenu's prompt redefinition
  kconfig: replace KERNELVERSION usage by the mainmenu's prompt
  kconfig: delay gconf window initialization
  kconfig: expand by default the rootmenu's prompt
  kconfig: add a symbol string expansion helper
  kconfig: regen parser
  kconfig: implement the `mainmenu' directive
  kconfig: allow PACKAGE to be defined on the compiler's command-line
  kconfig: rephrase help texts/comments not to include the package name
  kconfig: allow build-time definition of the internal config prefix
  kconfig: rephrase help text not to mention the internal prefix
  kconfig: replace a `switch()' statement by a more flexible `if()' statement