linux-toradex.git/scripts/kconfig/nconf.gui.c, branch v4.4.93

kconfig/nconf: Fix hang when editing symbol with a long prompt

2017-01-09T07:07:53+00:00

commit 79e51b5c2deea542b3bb8c66e0d502230b017dde upstream.

Currently it is impossible to edit the value of a config symbol with a
prompt longer than (terminal width - 2) characters.  dialog_inputbox()
calculates a negative x-offset for the input window and newwin() fails
as this is invalid.  It also doesn't check for this failure, so it
busy-loops calling wgetch(NULL) which immediately returns -1.

The additions in the offset calculations also don't match the intended
size of the window.

Limit the window size and calculate the offset similarly to
show_scroll_win().

Fixes: 692d97c380c6 ("kconfig: new configuration interface (nconfig)")
Signed-off-by: Ben Hutchings 
Signed-off-by: Greg Kroah-Hartman

nconf: use function calls instead of ncurses' variables LINES and COLS

2013-06-18T21:58:58+00:00

According to the documentation [1], LINES and COLS are initialized by
initscr(); it does not say anything about the behavior when windows are
resized.

Do not rely on the current implementation of ncurses that updates
these variables on resize, but use the propper function calls or macros
to get window dimensions.

The use of the variables in main() was OK, but for the sake of
consistency it was modified to use the macro getmaxyx().

[1] ncurses(3X)

Signed-off-by: Dirk Gouders 
Reviewed-by: "Yann E. MORIN" 
[yann.morin.1998@free.fr: declare 'lines' and 'columns' on a single line]
Signed-off-by: Yann E. MORIN

nconf: function keys line, change background color for better readability

2013-01-24T10:43:44+00:00

•  In function keys line descriptions black on darkblue are almost
   impossible to read.  Change colors to black on brown.

Signed-off-by: Roland Eggner 
Tested-by: "Yann E. MORIN" 
Signed-off-by: "Yann E. MORIN"

nconf: add u, d command keys in scroll windows

2012-07-26T10:20:46+00:00

They function just like they do in less(1).
Also correct some discrepancy between the help text and the code wrt
function keys.

Signed-off-by: Benjamin Poirier 
Signed-off-by: Michal Marek

scripts/kconfig/nconf: add KEY_HOME / KEY_END for dialog_inputbox

2011-09-09T12:40:08+00:00

to make it easier to locate begin/end when editing long strings;

Signed-off-by: Cheng Renquan 
Acked By: Nir Tzachar

scripts/kconfig/nconf: fix editing long strings

2011-09-09T12:40:08+00:00

The original dialog_inputbox doesn't work with longer than prompt_width
strings, here fixed it in this way:
1) add variable cursor_form_win to record cursor of form_win,
   keep its value always between [0, prompt_width-1];
   reuse the original cursor_position as cursor of the string result,
   use (cursor_position-cursor_form_win) as begin offset to show part of
   the string in form_win;

Signed-off-by: Cheng Renquan 
Cc: Arnaud Lacombe 
Cc: Nir Tzachar

scripts/kconfig/nconf: dynamically alloc dialog_input_result

2011-09-09T12:40:08+00:00

To support unlimited length string config items;

No check for realloc return value keeps code simple, and to be
consistent with other existing unchecked malloc in kconfig.

Signed-off-by: Cheng Renquan 
Signed-off-by: Arnaud Lacombe

scripts/kconfig/nconf: fix memmove's length arg

2011-09-09T12:40:08+00:00

In case KEY_BACKSPACE / KEY_DC to delete a char, it memmove only
(len-cursor_position+1) bytes;
the default case is to insert a char, it should also memmove exactly
(len-cursor_position+1) bytes;

the original use of (len+1) is wrong and may access following memory
that doesn't belong to result, may cause SegFault in theory;

	case KEY_BACKSPACE:
		if (cursor_position > 0) {
			memmove(&result[cursor_position-1],
					&result[cursor_position],
					len-cursor_position+1);
			cursor_position--;
		}
		break;
	case KEY_DC:
		if (cursor_position >= 0 && cursor_position < len) {
			memmove(&result[cursor_position],
					&result[cursor_position+1],
					len-cursor_position+1);
		}
		break;
	default:
		if ((isgraph(res) || isspace(res)) &&
				len-2 < result_len) {
			/* insert the char at the proper position */
			memmove(&result[cursor_position+1],
					&result[cursor_position],
					len-cursor_position+1);
			result[cursor_position] = res;
			cursor_position++;
		}

Signed-off-by: Cheng Renquan 
Acked-by: Nir Tzachar

scripts/kconfig/nconf: fix typo: unknow => unknown

2011-09-09T12:40:08+00:00

Signed-off-by: Cheng Renquan 
Acked-by: Arnaud Lacombe

kbuild: fix typo

2010-08-17T09:00:43+00:00

Signed-off-by: Arnaud Lacombe 
Signed-off-by: Michal Marek