linux-toradex.git/security/inode.c, branch v2.6.35-rc5

security: testing the wrong variable in create_by_name()

2010-04-22T11:17:41+00:00

There is a typo here.  We should be testing "*dentry" instead of
"dentry".  If "*dentry" is an ERR_PTR, it gets dereferenced in either
mkdir() or create() which would cause an OOPs.

Signed-off-by: Dan Carpenter 
Signed-off-by: James Morris

get rid of pointless checks after simple_pin_fs()

2010-01-27T03:22:26+00:00

if we'd just got success from it, vfsmount won't be NULL

Signed-off-by: Al Viro

securityfs: securityfs_remove should handle IS_ERR pointers

2009-05-12T01:06:11+00:00

Both of the securityfs users (TPM and IMA) can call securityfs_remove and pass
an IS_ERR(dentry) in their failure paths.  This patch handles those rather
than panicing when it tries to start deferencing some negative memory.

Signed-off-by: Eric Paris 
Signed-off-by: James Morris

Merge branch 'master' into next

2009-02-06T00:01:45+00:00

Conflicts:
	fs/namei.c

Manually merged per:

diff --cc fs/namei.c
index 734f2b5,bbc15c2..0000000
--- a/fs/namei.c
+++ b/fs/namei.c
@@@ -860,9 -848,8 +849,10 @@@ static int __link_path_walk(const char
  		nd->flags |= LOOKUP_CONTINUE;
  		err = exec_permission_lite(inode);
  		if (err == -EAGAIN)
- 			err = vfs_permission(nd, MAY_EXEC);
+ 			err = inode_permission(nd->path.dentry->d_inode,
+ 					       MAY_EXEC);
 +		if (!err)
 +			err = ima_path_check(&nd->path, MAY_EXEC);
   		if (err)
  			break;

@@@ -1525,14 -1506,9 +1509,14 @@@ int may_open(struct path *path, int acc
  		flag &= ~O_TRUNC;
  	}

- 	error = vfs_permission(nd, acc_mode);
+ 	error = inode_permission(inode, acc_mode);
  	if (error)
  		return error;
 +
- 	error = ima_path_check(&nd->path,
++	error = ima_path_check(path,
 +			       acc_mode & (MAY_READ | MAY_WRITE | MAY_EXEC));
 +	if (error)
 +		return error;
  	/*
  	 * An append-only file must be opened in append mode for writing.
  	 */

Signed-off-by: James Morris

securityfs: fix long-broken securityfs_create_file comment

2009-02-03T00:02:51+00:00

If there is an error creating a file through securityfs_create_file,
NULL is not returned, rather the error is propagated.

Signed-off-by: Serge E. Hallyn 
Signed-off-by: James Morris

zero i_uid/i_gid on inode allocation

2009-01-05T16:54:28+00:00

... and don't bother in callers.  Don't bother with zeroing i_blocks,
while we are at it - it's already been zeroed.

i_mode is not worth the effort; it has no common default value.

Signed-off-by: Al Viro

integrity: special fs magic

2008-10-12T22:47:43+00:00

Discussion on the mailing list questioned the use of these
magic values in userspace, concluding these values are already
exported to userspace via statfs and their correct/incorrect
usage is left up to the userspace application.

  - Move special fs magic number definitions to magic.h
  - Add magic.h include

Signed-off-by: Mimi Zohar 
Reviewed-by: James Morris 
Signed-off-by: James Morris

security: add/fix security kernel-doc

2008-08-20T10:16:32+00:00

Add security/inode.c functions to the kernel-api docbook.
Use '%' on constants in kernel-doc notation.
Fix several typos/spellos in security function descriptions.

Signed-off-by: Randy Dunlap 
Signed-off-by: James Morris

Kobject: convert remaining kobject_unregister() to kobject_put()

2008-01-25T04:40:40+00:00

There is no need for kobject_unregister() anymore, thanks to Kay's
kobject cleanup changes, so replace all instances of it with
kobject_put().


Cc: Kay Sievers 
Signed-off-by: Greg Kroah-Hartman

kobject: convert kernel_kset to be a kobject

2008-01-25T04:40:24+00:00

kernel_kset does not need to be a kset, but a much simpler kobject now
that we have kobj_attributes.

We also rename kernel_kset to kernel_kobj to catch all users of this
symbol with a build error instead of an easy-to-ignore build warning.

Cc: Kay Sievers 
Signed-off-by: Greg Kroah-Hartman