linux-toradex.git/security/selinux, branch v3.2.2-rt10 Linux kernel for Apalis and Colibri modules SELinux: Fix RCU deref check warning in sel_netport_insert() 2011-12-21T00:28:56+00:00 David Howells dhowells@redhat.com 2011-12-13T14:49:04+00:00 50345f1ea9cda4618d9c26e590a97ecd4bc7ac75 Fix the following bug in sel_netport_insert() where rcu_dereference() should be rcu_dereference_protected() as sel_netport_lock is held. =================================================== [ INFO: suspicious rcu_dereference_check() usage. ] --------------------------------------------------- security/selinux/netport.c:127 invoked rcu_dereference_check() without protection! other info that might help us debug this: rcu_scheduler_active = 1, debug_locks = 0 1 lock held by ossec-rootcheck/3323: #0: (sel_netport_lock){+.....}, at: [<ffffffff8117d775>] sel_netport_sid+0xbb/0x226 stack backtrace: Pid: 3323, comm: ossec-rootcheck Not tainted 3.1.0-rc8-fsdevel+ #1095 Call Trace: [<ffffffff8105cfb7>] lockdep_rcu_dereference+0xa7/0xb0 [<ffffffff8117d871>] sel_netport_sid+0x1b7/0x226 [<ffffffff8117d6ba>] ? sel_netport_avc_callback+0xbc/0xbc [<ffffffff8117556c>] selinux_socket_bind+0x115/0x230 [<ffffffff810a5388>] ? might_fault+0x4e/0x9e [<ffffffff810a53d1>] ? might_fault+0x97/0x9e [<ffffffff81171cf4>] security_socket_bind+0x11/0x13 [<ffffffff812ba967>] sys_bind+0x56/0x95 [<ffffffff81380dac>] ? sysret_check+0x27/0x62 [<ffffffff8105b767>] ? trace_hardirqs_on_caller+0x11e/0x155 [<ffffffff81076fcd>] ? audit_syscall_entry+0x17b/0x1ae [<ffffffff811b5eae>] ? trace_hardirqs_on_thunk+0x3a/0x3f [<ffffffff81380d7b>] system_call_fastpath+0x16/0x1b Signed-off-by: David Howells <dhowells@redhat.com> Acked-by: Paul Moore <paul@paul-moore.com> Acked-by: Eric Dumazet <eric.dumazet@gmail.com> Cc: stable@kernel.org Signed-off-by: James Morris <jmorris@namei.org> 
Fix the following bug in sel_netport_insert() where rcu_dereference() should
be rcu_dereference_protected() as sel_netport_lock is held.

===================================================
[ INFO: suspicious rcu_dereference_check() usage. ]
---------------------------------------------------
security/selinux/netport.c:127 invoked rcu_dereference_check() without protection!

other info that might help us debug this:

rcu_scheduler_active = 1, debug_locks = 0
1 lock held by ossec-rootcheck/3323:
 #0:  (sel_netport_lock){+.....}, at: [<ffffffff8117d775>] sel_netport_sid+0xbb/0x226

stack backtrace:
Pid: 3323, comm: ossec-rootcheck Not tainted 3.1.0-rc8-fsdevel+ #1095
Call Trace:
 [<ffffffff8105cfb7>] lockdep_rcu_dereference+0xa7/0xb0
 [<ffffffff8117d871>] sel_netport_sid+0x1b7/0x226
 [<ffffffff8117d6ba>] ? sel_netport_avc_callback+0xbc/0xbc
 [<ffffffff8117556c>] selinux_socket_bind+0x115/0x230
 [<ffffffff810a5388>] ? might_fault+0x4e/0x9e
 [<ffffffff810a53d1>] ? might_fault+0x97/0x9e
 [<ffffffff81171cf4>] security_socket_bind+0x11/0x13
 [<ffffffff812ba967>] sys_bind+0x56/0x95
 [<ffffffff81380dac>] ? sysret_check+0x27/0x62
 [<ffffffff8105b767>] ? trace_hardirqs_on_caller+0x11e/0x155
 [<ffffffff81076fcd>] ? audit_syscall_entry+0x17b/0x1ae
 [<ffffffff811b5eae>] ? trace_hardirqs_on_thunk+0x3a/0x3f
 [<ffffffff81380d7b>] system_call_fastpath+0x16/0x1b

Signed-off-by: David Howells <dhowells@redhat.com>
Acked-by: Paul Moore <paul@paul-moore.com>
Acked-by: Eric Dumazet <eric.dumazet@gmail.com>
Cc: stable@kernel.org
Signed-off-by: James Morris <jmorris@namei.org>
selinux: Add export.h to files using EXPORT_SYMBOL/THIS_MODULE 2011-10-31T23:31:32+00:00 Paul Gortmaker paul.gortmaker@windriver.com 2011-05-27T00:52:10+00:00 44fc7ea0bfe9143551649a42eb35f1460566c3c5 The pervasive, but implicit presence of <linux/module.h> meant that things like this file would happily compile as-is. But with the desire to phase out the module.h being included everywhere, point this file at export.h which will give it THIS_MODULE and the EXPORT_SYMBOL variants. Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com> 
The pervasive, but implicit presence of <linux/module.h> meant
that things like this file would happily compile as-is.  But
with the desire to phase out the module.h being included everywhere,
point this file at export.h which will give it THIS_MODULE and
the EXPORT_SYMBOL variants.

Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
selinux: sparse fix: fix several warnings in the security server code 2011-09-09T23:56:32+00:00 James Morris jmorris@namei.org 2011-08-30T02:52:32+00:00 7b98a5857c3fa86cb0a7e5f893643491a8b5b425 Fix several sparse warnings in the SELinux security server code. Signed-off-by: James Morris <jmorris@namei.org> 
Fix several sparse warnings in the SELinux security server code.

Signed-off-by: James Morris <jmorris@namei.org>
selinux: sparse fix: include selinux.h in exports.c 2011-09-09T23:56:32+00:00 James Morris jmorris@namei.org 2011-08-30T02:36:39+00:00 0ff53f5ddbaebeac1c2735125901275acc1fecc6 Fix warning: security/selinux/exports.c:18:6: warning: symbol 'selinux_is_enabled' was not declared. Should it be static? Signed-off-by: James Morris <jmorris@namei.org> 
Fix warning:
security/selinux/exports.c:18:6: warning: symbol 'selinux_is_enabled' was not declared. Should it be static?

Signed-off-by: James Morris <jmorris@namei.org>
selinux: sparse fix: fix warnings in netlink code 2011-09-09T23:56:31+00:00 James Morris jmorris@namei.org 2011-08-30T02:09:15+00:00 6a3fbe81179c85eb53054a0f4c8423ffec0276a7 Fix sparse warnings in SELinux Netlink code. Signed-off-by: James Morris <jmorris@namei.org> 
Fix sparse warnings in SELinux Netlink code.

Signed-off-by: James Morris <jmorris@namei.org>
selinux: sparse fix: eliminate warnings for selinuxfs 2011-09-09T23:56:30+00:00 James Morris jmorris@namei.org 2011-08-30T00:50:12+00:00 ad3fa08c4ff84ed87649d72e8497735c85561a3d Fixes several sparse warnings for selinuxfs.c Signed-off-by: James Morris <jmorris@namei.org> 
Fixes several sparse warnings for selinuxfs.c

Signed-off-by: James Morris <jmorris@namei.org>
selinux: sparse fix: declare selinux_disable() in security.h 2011-09-09T23:56:26+00:00 James Morris jmorris@namei.org 2011-08-17T01:17:14+00:00 58982b74832917405a483a22beede729e3175376 Sparse fix: declare selinux_disable() in security.h Signed-off-by: James Morris <jmorris@namei.org> 
Sparse fix: declare selinux_disable() in security.h

Signed-off-by: James Morris <jmorris@namei.org>
selinux: sparse fix: move selinux_complete_init 2011-09-09T23:56:26+00:00 James Morris jmorris@namei.org 2011-08-17T01:13:31+00:00 cc59a582d6081b296e481b8bc9676b5c2faad818 Sparse fix: move selinux_complete_init Signed-off-by: James Morris <jmorris@namei.org> 
Sparse fix: move selinux_complete_init

Signed-off-by: James Morris <jmorris@namei.org>
selinux: sparse fix: make selinux_secmark_refcount static 2011-09-09T23:56:25+00:00 James Morris jmorris@namei.org 2011-08-17T01:08:43+00:00 56a4ca996181b94b30e6b46509dc28e4ca3cc3f8 Sparse fix: make selinux_secmark_refcount static. Signed-off-by: James Morris <jmorris@namei.org> 
Sparse fix: make selinux_secmark_refcount  static.

Signed-off-by: James Morris <jmorris@namei.org>
doc: Update the email address for Paul Moore in various source files 2011-08-02T00:58:33+00:00 Paul Moore paul.moore@hp.com 2011-08-01T11:10:33+00:00 82c21bfab41a77bc01affe21bea9727d776774a7 My @hp.com will no longer be valid starting August 5, 2011 so an update is necessary. My new email address is employer independent so we don't have to worry about doing this again any time soon. Signed-off-by: Paul Moore <paul.moore@hp.com> Signed-off-by: Paul Moore <paul@paul-moore.com> Signed-off-by: David S. Miller <davem@davemloft.net> 
My @hp.com will no longer be valid starting August 5, 2011 so an update is
necessary.  My new email address is employer independent so we don't have
to worry about doing this again any time soon.

Signed-off-by: Paul Moore <paul.moore@hp.com>
Signed-off-by: Paul Moore <paul@paul-moore.com>
Signed-off-by: David S. Miller <davem@davemloft.net>