linux-toradex.git/security/smack/smack_access.c, branch v6.16-rc6

smack: remove /smack/logging if audit is not configured

2025-02-14T02:33:55+00:00

If CONFIG_AUDIT is not set then
SMACK does not generate audit messages,
however, keeps audit control file, /smack/logging,
while there is no entity to control.
This change removes audit control file /smack/logging
when audit is not configured in the kernel

Signed-off-by: Konstantin Andreev 
Signed-off-by: Casey Schaufler

Smack: fix typos and spelling errors

2025-02-11T22:34:02+00:00

Fix typos and spelling errors in security/smack module comments that
were identified using the codespell tool.
No functional changes - documentation only.

Signed-off-by: Tanya Agarwal 
Reviewed-by: Mimi Zohar 
Signed-off-by: Casey Schaufler

smack: deduplicate access to string conversion

2024-12-06T21:21:12+00:00

Signed-off-by: Konstantin Andreev 
Signed-off-by: Casey Schaufler

smack: Replace kzalloc + strncpy with kstrndup

2022-08-01T18:26:09+00:00

Simplify the code by using kstrndup instead of kzalloc and strncpy in
smk_parse_smack(), which meanwhile remove strncpy as [1] suggests.

[1]: https://github.com/KSPP/linux/issues/90

Signed-off-by: GONG, Ruiqi 
Signed-off-by: Casey Schaufler

Smack: Fix wrong semantics in smk_access_entry()

2021-07-20T16:17:36+00:00

In the smk_access_entry() function, if no matching rule is found
in the rust_list, a negative error code will be used to perform bit
operations with the MAY_ enumeration value. This is semantically
wrong. This patch fixes this issue.

Signed-off-by: Tianjia Zhang 
Signed-off-by: Casey Schaufler

Smack: fix doc warning

2021-06-08T17:23:08+00:00

Fix gcc W=1 warning:

security/smack/smack_access.c:342: warning: Function parameter or member 'ad' not described in 'smack_log'
security/smack/smack_access.c:403: warning: Function parameter or member 'skp' not described in 'smk_insert_entry'
security/smack/smack_access.c:487: warning: Function parameter or member 'level' not described in 'smk_netlbl_mls'
security/smack/smack_access.c:487: warning: Function parameter or member 'len' not described in 'smk_netlbl_mls'

Signed-off-by: ChenXiaoSong 
Signed-off-by: Casey Schaufler

Revert "Smack: Handle io_uring kernel thread privileges"

2021-05-18T17:36:48+00:00

This reverts commit 942cb357ae7d9249088e3687ee6a00ed2745a0c7.

The io_uring PF_IO_WORKER threads no longer have PF_KTHREAD set, so no
need to special case them for credential checks.

Cc: Casey Schaufler 
Signed-off-by: Jens Axboe 
Signed-off-by: Casey Schaufler

Smack: Handle io_uring kernel thread privileges

2020-12-22T23:34:24+00:00

Smack assumes that kernel threads are privileged for smackfs
operations. This was necessary because the credential of the
kernel thread was not related to a user operation. With io_uring
the credential does reflect a user's rights and can be used.

Suggested-by: Jens Axboe 
Acked-by: Jens Axboe 
Acked-by: Eric W. Biederman 
Signed-off-by: Casey Schaufler

Smack: Use the netlabel cache

2020-09-11T22:31:31+00:00

Utilize the Netlabel cache mechanism for incoming packet matching.
Refactor the initialization of secattr structures, as it was being
done in two places.

Signed-off-by: Casey Schaufler

smack: use GFP_NOFS while holding inode_smack::smk_lock

2019-09-04T16:37:07+00:00

inode_smack::smk_lock is taken during smack_d_instantiate(), which is
called during a filesystem transaction when creating a file on ext4.
Therefore to avoid a deadlock, all code that takes this lock must use
GFP_NOFS, to prevent memory reclaim from waiting for the filesystem
transaction to complete.

Reported-by: syzbot+0eefc1e06a77d327a056@syzkaller.appspotmail.com
Cc: stable@vger.kernel.org
Signed-off-by: Eric Biggers 
Signed-off-by: Casey Schaufler