linux-toradex.git/security/tomoyo/common.c, branch v3.0.69

TOMOYO: Fix infinite loop bug when reading /sys/kernel/security/tomoyo/audit

2011-04-18T23:37:12+00:00

In tomoyo_flush(), head->r.w[0] holds pointer to string data to be printed.
But head->r.w[0] was updated only when the string data was partially
printed (because head->r.w[0] will be updated by head->r.w[1] later if
completely printed). However, regarding /sys/kernel/security/tomoyo/query ,
an additional '\0' is printed after the string data was completely printed.
But if free space for read buffer became 0 before printing the additional '\0',
tomoyo_flush() was returning without updating head->r.w[0]. As a result,
tomoyo_flush() forever reprints already printed string data.

Signed-off-by: Tetsuo Handa 
Signed-off-by: James Morris

TOMOYO: Fix race on updating profile's comment line.

2011-04-18T23:37:06+00:00

In tomoyo_write_profile() since 2.6.34, a lock was by error missing when
replacing profile's comment line. If multiple threads attempted

  echo '0-COMMENT=comment' > /sys/kernel/security/tomoyo/profile

in parallel, garbage collector will fail to kfree() the old value.
Protect the replacement using a lock. Also, keep the old value rather than
replace with empty string when out of memory error has occurred.

Signed-off-by: Xiaochen Wang 
Signed-off-by: Tetsuo Handa 
Signed-off-by: James Morris

TOMOYO: Print URL information before panic().

2010-10-20T23:12:45+00:00

Configuration files for TOMOYO 2.3 are not compatible with TOMOYO 2.2.
But current panic() message is too unfriendly and is confusing users.

Signed-off-by: Tetsuo Handa 
Reviewed-by: KOSAKI Motohiro 
Signed-off-by: James Morris

tomoyo: cleanup. don't store bogus pointer

2010-10-20T23:12:32+00:00

If domain is NULL then &domain->list is a bogus address.  Let's leave
head->r.domain NULL instead of saving an unusable pointer.

This is just a cleanup.  The current code always checks head->r.eof
before dereferencing head->r.domain.

Signed-off-by: Dan Carpenter 
Acked-by: Tetsuo Handa

TOMOYO: Don't abuse sys_getpid(), sys_getppid()

2010-09-27T00:53:18+00:00

System call entry functions sys_*() are never to be called from
general kernel code.  The fact that they aren't declared in header
files should have been a clue.  These functions also don't exist on
Alpha since it has sys_getxpid() instead.

Signed-off-by: Ben Hutchings 
Acked-by: Tetsuo Handa 
Signed-off-by: James Morris

TOMOYO: Update version to 2.3.0

2010-08-02T05:35:10+00:00

Signed-off-by: Tetsuo Handa 
Signed-off-by: James Morris

TOMOYO: Add missing poll() hook.

2010-08-02T05:34:55+00:00

Commit 1dae08c "TOMOYO: Add interactive enforcing mode." forgot to register
poll() hook. As a result, /usr/sbin/tomoyo-queryd was doing busy loop.

Signed-off-by: Tetsuo Handa 
Signed-off-by: James Morris

TOMOYO: Rename symbols.

2010-08-02T05:34:54+00:00

Use shorter name in order to make it easier to fit 80 columns limit.

Signed-off-by: Tetsuo Handa 
Signed-off-by: James Morris

TOMOYO: Small cleanup.

2010-08-02T05:34:54+00:00

Split tomoyo_write_profile() into several functions.

Signed-off-by: Tetsuo Handa 
Signed-off-by: James Morris

TOMOYO: Copy directly to userspace buffer.

2010-08-02T05:34:45+00:00

When userspace program reads policy from /sys/kernel/security/tomoyo/
interface, TOMOYO uses line buffered mode. A line has at least one word.

Commit 006dacc "TOMOYO: Support longer pathname." changed a word's max length
from 4000 bytes to max kmalloc()able bytes. By that commit, a line's max length
changed from 8192 bytes to more than max kmalloc()able bytes.

Max number of words in a line remains finite. This patch changes the way of
buffering so that all words in a line are firstly directly copied to userspace
buffer as much as possible and are secondly queued for next read request.
Words queued are guaranteed to be valid until /sys/kernel/security/tomoyo/
interface is close()d.

Signed-off-by: Tetsuo Handa 
Signed-off-by: James Morris