linux-toradex.git/security, branch v3.4.10

posix_types.h: Cleanup stale __NFDBITS and related definitions

2012-08-09T15:31:39+00:00

commit 8ded2bbc1845e19c771eb55209aab166ef011243 upstream.

Recently, glibc made a change to suppress sign-conversion warnings in
FD_SET (glibc commit ceb9e56b3d1).  This uncovered an issue with the
kernel's definition of __NFDBITS if applications #include
 after including .  A build failure would
be seen when passing the -Werror=sign-compare and -D_FORTIFY_SOURCE=2
flags to gcc.

It was suggested that the kernel should either match the glibc
definition of __NFDBITS or remove that entirely.  The current in-kernel
uses of __NFDBITS can be replaced with BITS_PER_LONG, and there are no
uses of the related __FDELT and __FDMASK defines.  Given that, we'll
continue the cleanup that was started with commit 8b3d1cda4f5f
("posix_types: Remove fd_set macros") and drop the remaining unused
macros.

Additionally, linux/time.h has similar macros defined that expand to
nothing so we'll remove those at the same time.

Reported-by: Jeff Law 
Suggested-by: Linus Torvalds 
Signed-off-by: Josh Boyer 
[ .. and fix up whitespace as per akpm ]
Signed-off-by: Linus Torvalds 
Signed-off-by: Greg Kroah-Hartman

SELinux: if sel_make_bools errors don't leave inconsistent state

2012-06-01T07:18:16+00:00

commit 154c50ca4eb9ae472f50b6a481213e21ead4457d upstream.

We reset the bool names and values array to NULL, but do not reset the
number of entries in these arrays to 0.  If we error out and then get back
into this function we will walk these NULL pointers based on the belief
that they are non-zero length.

Signed-off-by: Eric Paris 
Signed-off-by: Greg Kroah-Hartman

security: fix compile error in commoncap.c

2012-04-19T02:56:39+00:00

Add missing "personality.h"
security/commoncap.c: In function 'cap_bprm_set_creds':
security/commoncap.c:510: error: 'PER_CLEAR_ON_SETID' undeclared (first use in this function)
security/commoncap.c:510: error: (Each undeclared identifier is reported only once
security/commoncap.c:510: error: for each function it appears in.)

Signed-off-by: Jonghwan Choi 
Acked-by: Serge Hallyn 
Signed-off-by: James Morris

fcaps: clear the same personality flags as suid when fcaps are used

2012-04-18T02:37:56+00:00

If a process increases permissions using fcaps all of the dangerous
personality flags which are cleared for suid apps should also be cleared.
Thus programs given priviledge with fcaps will continue to have address space
randomization enabled even if the parent tried to disable it to make it
easier to attack.

Signed-off-by: Eric Paris 
Reviewed-by: Serge Hallyn 
Signed-off-by: James Morris

Smack: move label list initialization

2012-04-18T02:02:28+00:00

A kernel with Smack enabled will fail if tmpfs has xattr support.

Move the initialization of predefined Smack label
list entries to the LSM initialization from the
smackfs setup. This became an issue when tmpfs
acquired xattr support, but was never correct.

Signed-off-by: Casey Schaufler 
Signed-off-by: James Morris

Smack: build when CONFIG_AUDIT not defined

2012-04-10T23:14:40+00:00

This fixes builds where CONFIG_AUDIT is not defined and
CONFIG_SECURITY_SMACK=y.

This got introduced by the stack-usage reducation commit 48c62af68a40
("LSM: shrink the common_audit_data data union").

Signed-off-by: Kees Cook 
Acked-by: Eric Paris 
Signed-off-by: Linus Torvalds

lsm_audit: don't specify the audit pre/post callbacks in 'struct common_audit_data'

2012-04-03T16:49:59+00:00

It just bloats the audit data structure for no good reason, since the
only time those fields are filled are just before calling the
common_lsm_audit() function, which is also the only user of those
fields.

So just make them be the arguments to common_lsm_audit(), rather than
bloating that structure that is passed around everywhere, and is
initialized in hot paths.

Signed-off-by: Linus Torvalds

SELinux: do not allocate stack space for AVC data unless needed

2012-04-03T16:49:41+00:00

Instead of declaring the entire selinux_audit_data on the stack when we
start an operation on declare it on the stack if we are going to use it.
We know it's usefulness at the end of the security decision and can declare
it there.

Signed-off-by: Eric Paris 
Signed-off-by: Linus Torvalds

SELinux: remove avd from slow_avc_audit()

2012-04-03T16:49:10+00:00

We don't use the argument, so remove it.

Signed-off-by: Eric Paris 
Signed-off-by: Linus Torvalds

SELinux: remove avd from selinux_audit_data

2012-04-03T16:49:10+00:00

We do not use it.  Remove it.

Signed-off-by: Eric Paris 
Signed-off-by: Linus Torvalds