linux-toradex.git/sound/core/compress_offload.c, branch v4.9.14

ALSA: compress: fix some missing and misplaced \n in messages

2016-09-16T17:24:13+00:00

Fix a missing \n in a pr_debug message and move the \n to the end
of a pr_err message.

Signed-off-by: Colin Ian King 
Signed-off-by: Takashi Iwai

ALSA: compress: Use memdup_user() rather than duplicating its implementation

2016-08-22T12:04:18+00:00

Reuse existing functionality from memdup_user() instead of keeping
duplicate source code.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring 
Acked-by: Vinod Koul 
Signed-off-by: Takashi Iwai

ALSA: compress: Add function to indicate the stream has gone bad

2016-06-13T15:45:37+00:00

Currently, the avail IOCTL doesn't pass any error status, which
means typically on error it simply shows no data available. This
can lead to situations where user-space is waiting indefinitely
for data that will never come as the DSP has suffered an
unrecoverable error.

Add snd_compr_stop_error which end drivers can call to indicate
the stream has suffered an unrecoverable error and stop it. The
avail and poll IOCTLs are then updated to report if the stream is
in an error state to user-space. Allowing the error to propagate
out. Processing of the actual snd_compr_stop needs to be deferred
to a worker thread as the end driver may detect the errors during
an existing operation callback.

Signed-off-by: Charles Keepax 
Acked-by: Vinod Koul 
Signed-off-by: Mark Brown

ALSA: compress: Replace complex if statement with switch

2016-05-09T15:35:50+00:00

A switch statement looks a bit cleaner than an if statement
spread over 3 lines, as such update this to a switch.

Signed-off-by: Charles Keepax 
Acked-by: Vinod Koul 
Signed-off-by: Takashi Iwai

ALSA: compress: Fix poll error return codes

2016-05-09T15:35:43+00:00

We can't return a negative error code from the poll callback the return
type is unsigned and is checked against the poll specific flags we need
to return POLLERR if we encounter an error.

Signed-off-by: Charles Keepax 
Acked-by: Vinod Koul 
Signed-off-by: Takashi Iwai

ALSA: compress: Remove pointless NULL check

2016-05-09T15:35:32+00:00

stream can't be NULL here as we have just taken the address of it, so no
need for the check.

Signed-off-by: Charles Keepax 
Acked-by: Vinod Koul 
Signed-off-by: Takashi Iwai

ALSA: compress: Use snd_compr_get_poll on error path

2016-05-09T15:35:14+00:00

We have a function that returns the appropriate flags for the stream
direction, so we should use it.

Signed-off-by: Charles Keepax 
Acked-by: Vinod Koul 
Signed-off-by: Takashi Iwai

ALSA: compress: fix more typos

2016-03-04T20:55:36+00:00

More inspection of code revealed few more typos so fix them as well

Signed-off-by: Vinod Koul 
Signed-off-by: Takashi Iwai

ALSA: compress: fix some typos

2016-03-04T16:49:42+00:00

Found few typos while looking at code, so fix them

Signed-off-by: Vinod Koul 
Signed-off-by: Takashi Iwai

ALSA: compress: Add SNDRV_PCM_STATE_PREPARED state explanation

2016-03-04T16:49:42+00:00

Stream states were explained in the code comments but
SNDRV_PCM_STATE_PREPARED was missed so add it

Signed-off-by: Vinod Koul 
Signed-off-by: Takashi Iwai