linux-toradex.git/sound/core/info.c, branch v4.4.2

ALSA: info: Drop kerneldoc comment from snd_info_create_entry()

2015-05-18T07:45:11+00:00

It's no longer a part of API but merely a local function.

Signed-off-by: Takashi Iwai

ALSA: info: Move list addition to snd_info_create_entry()

2015-05-18T07:44:28+00:00

Just a minor refactoring, no functional changes.

Signed-off-by: Takashi Iwai

ALSA: info: Register proc entries recursively, too

2015-05-18T07:20:24+00:00

The commit [c560a6797e3b: ALSA: core: Remove child proc file elements
recursively] converted snd_card_proc_new() with the normal
snd_info_*() call and removed snd_device chain for such info
entries. However, it misses one point: the creation of the proc entry
was managed by snd_device chain in the former code, and now it's also
gone, which results in no proc files creation at all.  Mea culpa.

This patch makes snd_info_card_register() creating the all pending
child proc entries in a shot.  Also, since snd_card_register() might
be called multiple times, this function is also changed to be callable
multiple times.

Along with the changes above, now the linked list of snd_info_entry is
added at creation time instead of snd_info_register() for keeping eyes
of pending info entries.

Fixes: c560a6797e3b ('ALSA: core: Remove child proc file elements recursively')
Reported-by: "Lu, Han" 
Signed-off-by: Takashi Iwai

ALSA: info: Fix leaks of child entries at snd_info_free_entry()

2015-05-18T07:10:45+00:00

snd_info_free_entry() releases the all children nodes as well, but due
to the wrong timing of releasing the link, the children nodes may be
disconnected but left unreleased.  This patch fixes it by moving the
link free at the right position.  Also it eases list_for_each_entry()
without _safe option in snd_info_disconnect() because it no longer
frees the children nodes there.

Fixes: c560a6797e3b ('ALSA: core: Remove child proc file elements recursively')
Signed-off-by: Takashi Iwai

ALSA: core: Clean up OSS proc file management

2015-04-24T15:31:08+00:00

A few minor cleanups:
- Move the call of snd_info_minor_register() into snd_info_init() so
  that we can call all proc-related stuff in a shot
- Add missing __init prefix to snd_info_minor_register()
- Return an error properly from snd_oss_info_register()
- Drop snd_info_minor_unregister() that is superfluous now

Acked-by: Jaroslav Kysela 
Signed-off-by: Takashi Iwai

ALSA: core: Build conditionally and remove superfluous ifdefs

2015-04-24T15:31:07+00:00

Minor cleanups of Makefile to build some codes conditionally so that
a few ifdefs can be reduced.

Acked-by: Jaroslav Kysela 
Signed-off-by: Takashi Iwai

ALSA: core: Don't ignore errors at creating proc files

2015-04-24T15:31:06+00:00

So far we've ignored the errors at creating proc files in many places.
But they should be rather treated seriously.

Also, by assuring the error handling, we can get rid of superfluous
snd_info_free_entry() calls as they will be removed by the parent in
the caller side.

This patch fixes the missing error checks and reduces the superfluous
free calls.

Acked-by: Jaroslav Kysela 
Signed-off-by: Takashi Iwai

ALSA: core: Remove superfluous exit calls for proc entries

2015-04-24T15:31:04+00:00

Since each proc entry is freed automatically by the parent, we don't
have to take care of its life cycle any longer.  This allows us to
reduce a few more lines of codes.

Acked-by: Jaroslav Kysela 
Signed-off-by: Takashi Iwai

ALSA: core: Manage asound root directory with snd_info_entry

2015-04-24T15:31:02+00:00

Using snd_info_entry for /proc/asound root makes easier to release the
all children, too.  Further cleanups will follow.

Acked-by: Jaroslav Kysela 
Signed-off-by: Takashi Iwai

ALSA: core: Remove child proc file elements recursively

2015-04-24T15:27:57+00:00

This patch changes the way to manage the resource release of proc
files: namely, let snd_info_free_entry() freeing the whole children.

This makes it us possible to drop the snd_device_*() management.  Then
snd_card_proc_new() becomes merely a wrapper to
snd_info_create_card_entry().

Together with this change, now you need to call snd_info_free_entry()
for a proc entry created via snd_card_proc_new(), while it was freed
via snd_device_free() beforehand.

Acked-by: Jaroslav Kysela 
Signed-off-by: Takashi Iwai