linux-toradex.git/sound/core/oss, branch v3.4.77

ALSA: Fix card refcount unbalance

2012-11-17T21:16:36+00:00

commit 8bb4d9ce08b0a92ca174e41d92c180328f86173f upstream.

There are uncovered cases whether the card refcount introduced by the
commit a0830dbd isn't properly increased or decreased:
- OSS PCM and mixer success paths
- When lookup function gets NULL

This patch fixes these places.

Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=50251

Signed-off-by: Takashi Iwai 
Signed-off-by: Greg Kroah-Hartman

ALSA: Avoid endless sleep after disconnect

2012-11-17T21:16:13+00:00

commit 0914f7961babbf28aaa2f19b453951fb4841c03f upstream.

When disconnect callback is called, each component should wake up
sleepers and check card->shutdown flag for avoiding the endless sleep
blocking the proper resource release.

Signed-off-by: Takashi Iwai 
Signed-off-by: Greg Kroah-Hartman

ALSA: Add a reference counter to card instance

2012-11-17T21:16:13+00:00

commit a0830dbd4e42b38aefdf3fb61ba5019a1a99ea85 upstream.

For more strict protection for wild disconnections, a refcount is
introduced to the card instance, and let it up/down when an object is
referred via snd_lookup_*() in the open ops.

The free-after-last-close check is also changed to check this refcount
instead of the empty list, too.

Reported-by: Matthieu CASTET 
Signed-off-by: Takashi Iwai 
Signed-off-by: Greg Kroah-Hartman

ALSA: module_param: make bool parameters really bool

2011-12-19T09:34:41+00:00

module_param(bool) used to counter-intuitively take an int.  In
fddd5201 (mid-2009) we allowed bool or int/unsigned int using a messy
trick.

It's time to remove the int/unsigned int option.  For this version
it'll simply give a warning, but it'll break next kernel version.

Signed-off-by: Rusty Russell 
Signed-off-by: Takashi Iwai

sound: Add module.h to the previously silent sound users

2011-10-31T23:31:21+00:00

Lots of sound drivers were getting module.h via the implicit presence
of it in  but we are going to clean that up.  So
fix up those users now.

Signed-off-by: Paul Gortmaker

sound: fix drivers needing module.h not moduleparam.h

2011-10-31T23:31:19+00:00

The implicit presence of module.h lured several users into
incorrectly thinking that they only needed/used modparam.h
but once we clean up the module.h presence, these will show
up as build failures, so fix 'em now.

Signed-off-by: Paul Gortmaker

ALSA: oss-mixer - use strlcpy() instead strcpy()

2011-10-04T06:47:52+00:00

This is mostly a static checker fix more than anything else.  We're
copying from a 64 char buffer into a 44 char buffer.

The 64 character buffer is str[] in snd_mixer_oss_build_test_all().
The call tree is:
	snd_mixer_oss_build_test_all()
	-> snd_mixer_oss_build_test()
	   -> snd_mixer_oss_build_test().

We never actually do fill str[] buffer all the way to 64 characters.
The longest string is:
	sprintf(str, "%s Playback Switch", ptr->name);
ptr->name is a 32 character buffer so 32 plus 16 characters for
" Playback Switch" still puts us over the 44 limit from "id.name".

Most likely ptr->name never gets filled to the limit, but we can't
really change the size of that buffer so lets just use strlcpy() here
and be safe.

Signed-off-by: Dan Carpenter 
Signed-off-by: Takashi Iwai

ALSA: core: remove unused variables.

2011-05-26T06:19:04+00:00

Drop a few variables that are never read.

Signed-off-by: Luca Tettamanti 
Signed-off-by: Takashi Iwai

ALSA: core: sparse cleanups

2011-02-14T16:10:11+00:00

Change the core code where sparse complains.  In most cases, this means
just adding annotations to confirm that we indeed want to do the dirty
things we're doing.

Signed-off-by: Clemens Ladisch 
Signed-off-by: Takashi Iwai

ALSA: Don't leak in sound/core/oss/pcm_oss.c::snd_pcm_hw_param_near()

2011-01-10T10:13:42+00:00

snd_pcm_hw_param_near() will leak the memory allocated to 'save' if the
call to snd_pcm_hw_param_max() returns less than zero.
This patch makes sure we never leak.

Signed-off-by: Jesper Juhl 
Signed-off-by: Takashi Iwai