linux-toradex.git/sound/core/oss, branch v4.4.99

ALSA: pcm: Fix potential deadlock in OSS emulation

2016-02-17T20:30:59+00:00

commit b248371628aad599a48540962f6b85a21a8a0c3f upstream.

There are potential deadlocks in PCM OSS emulation code while
accessing read/write and mmap concurrently.  This comes from the
infamous mmap_sem usage in copy_from/to_user().  Namely,

   snd_pcm_oss_write() ->
     &runtime->oss.params_lock ->
        copy_to_user() ->
          &mm->mmap_sem
  mmap() ->
    &mm->mmap_sem ->
      snd_pcm_oss_mmap() ->
        &runtime->oss.params_lock

Since we can't avoid taking params_lock from mmap code path, use
trylock variant and aborts with -EAGAIN as a workaround of this AB/BA
deadlock.

BugLink: http://lkml.kernel.org/r/CACT4Y+bVrBKDG0G2_AcUgUQa+X91VKTeS4v+wN7BSHwHtqn3kQ@mail.gmail.com
Reported-by: Dmitry Vyukov 
Signed-off-by: Takashi Iwai 
Signed-off-by: Greg Kroah-Hartman

ALSA: oss: underflow in snd_mixer_oss_proc_write()

2015-10-15T08:00:29+00:00

We cap the upper bound of "idx" but not the negative side.  Let's make
it unsigned to fix this.

Signed-off-by: Dan Carpenter 
Signed-off-by: Takashi Iwai

ALSA: replace CONFIG_PROC_FS with CONFIG_SND_PROC_FS

2015-05-27T19:25:19+00:00

We may disable proc fs only for sound part, to reduce ALSA
memory footprint. So add CONFIG_SND_PROC_FS and replace the
old CONFIG_PROC_FSs in alsa code.

With sound proc fs disabled, we can save about 9KB memory
size on X86_64 platform.

Signed-off-by: Jie Yang 
Reviewed-by: Mark Brown 
Signed-off-by: Takashi Iwai

ALSA: core: Drop superfluous error/debug messages after malloc failures

2015-03-10T14:42:14+00:00

The kernel memory allocators already report the errors when the
requested allocation fails, thus we don't need to warn it again in
each caller side.

Signed-off-by: Takashi Iwai

ALSA: snd_pcm_oss_period_size: Use round{up,down}_pow_of_two()

2014-12-30T15:41:55+00:00

Instead of opencoding them use the standard roundup_pow_of_two() and
rounddown_pow_of_two() helper functions. This gets rids one of the few users
of the custom ld2() function and also makes it a bit more obvious what the
code does.

Signed-off-by: Lars-Peter Clausen 
Signed-off-by: Takashi Iwai

ALSA: oss: Use standard printk helpers

2014-02-14T07:14:17+00:00

Use dev_err() & co as much as possible.  If not available (no device
assigned at the calling point), use pr_xxx() helpers instead.

Signed-off-by: Takashi Iwai

ALSA: Drop unused name argument in snd_register_oss_device()

2014-02-12T09:58:19+00:00

The last argument, name, of snd_oss_register_device() is nowhere
referred in the function in the current code.  Let's drop it.

Signed-off-by: Takashi Iwai

ALSA: core: fix NULL checking in snd_pcm_plug_slave_size()

2012-11-14T07:03:31+00:00

The dereference snd_pcm_plug_stream(plug) should come after the NULL
check snd_BUG_ON(!plug).

Signed-off-by: Xi Wang 
Signed-off-by: Takashi Iwai

ALSA: core: fix NULL checking in snd_pcm_plug_client_size()

2012-11-14T07:03:27+00:00

The dereference snd_pcm_plug_stream(plug) should come after the NULL
check snd_BUG_ON(!plug).

Signed-off-by: Xi Wang 
Signed-off-by: Takashi Iwai

ALSA: Fix card refcount unbalance

2012-11-08T13:36:18+00:00

There are uncovered cases whether the card refcount introduced by the
commit a0830dbd isn't properly increased or decreased:
- OSS PCM and mixer success paths
- When lookup function gets NULL

This patch fixes these places.

Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=50251

Cc: 
Signed-off-by: Takashi Iwai