linux-toradex.git/sound/core/pcm.c, branch v4.4.2

ALSA: pcm: remove structure member of 'struct snd_pcm_hwptr_log *' type because this structure had been removed

2015-09-13T10:03:15+00:00

This structure was added by 4d96eb255c53 ('ALSA: pcm_lib - add possibility
to log last 10 DMA ring buffer positions') to store PCM pointers
information of latest 10 pointer movements (=XRUN_LOG_CNT). When
CONFIG_SND_PCM_XRUN_DEBUG is configured, 'struct snd_pcm_runtime' has
'hwptr_log' member with a pointer to the structure. When calling
xrun_log() in pcm_lib.c, the structure was allocated to the pointer.
When calling snd_pcm_detach_substream() in pcm.c, the allocated pointer
is released.

In f5914908a5b7 ('ALSA: pcm: Replace PCM hwptr tracking with tracepoints'),
the pointer logging is replaced with using Linux Kernel Tracepoints. The
structure was also removed, while it's just declared. The member and kfree
still remains.

This commit removes the member and related codes. I think this was
overlooked because it brings no errors/warnings to C compilers.

Fixes: f5914908a5b7 ('ALSA: pcm: Replace PCM hwptr tracking with tracepoints')
Signed-off-by: Takashi Sakamoto 
Signed-off-by: Takashi Iwai

ALSA: pcm: Fix pcm_class sysfs output

2015-06-23T09:56:22+00:00

The pcm_class sysfs of each PCM substream gives only "none" since the
recent code change to embed the struct device.  Fix the code to point
directly to the embedded device object properly.

Fixes: ef46c7af93f9 ('ALSA: pcm: Embed struct device')
Cc:  # v4.0+
Signed-off-by: Takashi Iwai

ALSA: replace CONFIG_PROC_FS with CONFIG_SND_PROC_FS

2015-05-27T19:25:19+00:00

We may disable proc fs only for sound part, to reduce ALSA
memory footprint. So add CONFIG_SND_PROC_FS and replace the
old CONFIG_PROC_FSs in alsa code.

With sound proc fs disabled, we can save about 9KB memory
size on X86_64 platform.

Signed-off-by: Jie Yang 
Reviewed-by: Mark Brown 
Signed-off-by: Takashi Iwai

ALSA: core: Drop superfluous error/debug messages after malloc failures

2015-03-10T14:42:14+00:00

The kernel memory allocators already report the errors when the
requested allocation fails, thus we don't need to warn it again in
each caller side.

Signed-off-by: Takashi Iwai

ALSA: pcm: Don't ignore internal PCMs in snd_pcm_dev_disconnect()

2015-02-20T18:52:04+00:00

Some codes in snd_pcm_dev_disconnect() are still valid even for
internal PCMs, but they are skipped because of the check of
list_empty(&pcm->list) at the beginning.  Remove this check and put
pcm->internal checks appropriately for internal PCM object to process
through this function.

Acked-by: Liam Girdwood 
Signed-off-by: Takashi Iwai

ALSA: pcm: Don't notify internal PCMs

2015-02-20T18:51:50+00:00

Notifier shouldn't listen to the changes of internal PCMs.

Acked-by: Liam Girdwood 
Signed-off-by: Takashi Iwai

ALSA: pcm: Don't add internal PCMs to PCM device list

2015-02-20T18:51:42+00:00

An internal PCM object shouldn't be added to the PCM device list, as
it's never accessed directly from the user-space, and it has no proc
or any similar accesses.  Currently, it's excluded in snd_pcm_get()
and snd_pcm_next(), but it's easier not to add such an object to the
list.

Actually, the whole snd_pcm_dev_register() can be skipped for an
internal PCM.  So this patch changes the code there, but also
addresses the uninitialized list_head access.

Acked-by: Liam Girdwood 
Signed-off-by: Takashi Iwai

ALSA: pcm: Minor refactoring in snd_pcm_attach_substream()

2015-02-20T18:51:04+00:00

No functional changes at all.

Acked-by: Liam Girdwood 
Signed-off-by: Takashi Iwai

ALSA: Simplify snd_device_register() variants

2015-02-02T16:01:26+00:00

Now that all callers have been replaced with
snd_device_register_for_dev(), let's drop the obsolete device
registration code and concentrate only on the code handling struct
device directly.  That said,

- remove the old snd_device_register(),
- rename snd_device_register_for_dev() with snd_device_register(),
- drop superfluous arguments from snd_device_register(),
- change snd_unregister_device() to pass the device pointer directly

Reviewed-by: Jaroslav Kysela 
Signed-off-by: Takashi Iwai

ALSA: pcm: Embed struct device

2015-02-02T13:42:42+00:00

Like previous patches, at this time we embed the struct device into
PCM object.  However, this needs a bit more caution: struct snd_pcm
doesn't own one device but two, for both playback and capture!  Thus
not struct snd_pcm but struct snd_pcm_str object contains the device.

Along with this change, pcm->dev field is dropped for avoiding
confusion.  It was meant to point to a non-standard parent.  But,
since now we can touch each struct device directly, we can manipulate
the parent field easily there, too.

Reviewed-by: Jaroslav Kysela 
Signed-off-by: Takashi Iwai