linux-toradex.git/sound/core/seq/oss, branch v4.0

ALSA: seq: Deletion of unnecessary checks before the function call "snd_midi_event_free"

2015-01-04T14:11:05+00:00

The snd_midi_event_free() function tests whether its argument is NULL and then
returns immediately. Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring 
Signed-off-by: Takashi Iwai

ALSA: core: Deletion of unnecessary checks before two function calls

2014-11-21T19:06:57+00:00

The functions snd_seq_oss_timer_delete() and vunmap() perform also input
parameter validation. Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring 
Signed-off-by: Takashi Iwai

ALSA: seq_oss: Use standard printk helpers

2014-02-14T07:14:18+00:00

Use the standard pr_xxx() helpers instead of home-baked snd_print*().

Signed-off-by: Takashi Iwai

ALSA: seq_oss: Drop debug prints

2014-02-14T07:14:13+00:00

The debug prints in snd-seq-oss module are rather useless.
Let's clean up before further modifications.

Signed-off-by: Takashi Iwai

ALSA: Drop unused name argument in snd_register_oss_device()

2014-02-12T09:58:19+00:00

The last argument, name, of snd_oss_register_device() is nowhere
referred in the function in the current code.  Let's drop it.

Signed-off-by: Takashi Iwai

ALSA: seq-oss: Initialize MIDI clients asynchronously

2013-07-17T07:19:24+00:00

We've got bug reports that the module loading stuck on Debian system
with 3.10 kernel.  The debugging session revealed that the initial
registration of OSS sequencer clients stuck at module loading time,
which involves again with request_module() at the init phase.  This is
triggered only by special --install stuff Debian is using, but it's
still not good to have such loops.

As a workaround, call the registration part asynchronously.  This is a
better approach irrespective of the hang fix, in anyway.

Reported-and-tested-by: Philipp Matthias Hahn 
Cc: 
Signed-off-by: Takashi Iwai

ALSA: seq: seq_oss_event: missing range checks

2013-03-04T15:39:50+00:00

The "dev" variable could be out of bounds.  Calling
snd_seq_oss_synth_is_valid() checks that it is is a valid device
which has been opened.  We check this inside set_note_event() so
this function can't succeed without a valid "dev".  But we need to
do the check earlier to prevent invalid dereferences and memory
corruption.

One call tree where "dev" could be out of bounds is:
-> snd_seq_oss_oob_user()
   -> snd_seq_oss_process_event()
      -> extended_event()
         -> note_on_event()

Signed-off-by: Dan Carpenter 
Signed-off-by: Takashi Iwai

sound: Add export.h for THIS_MODULE/EXPORT_SYMBOL where needed

2011-10-31T23:31:22+00:00

These aren't modules, but they do make use of these macros, so
they will need export.h to get that definition.  Previously,
they got it via the implicit module.h inclusion.

Signed-off-by: Paul Gortmaker

sound: Add module.h to the previously silent sound users

2011-10-31T23:31:21+00:00

Lots of sound drivers were getting module.h via the implicit presence
of it in  but we are going to clean that up.  So
fix up those users now.

Signed-off-by: Paul Gortmaker

sound: fix drivers needing module.h not moduleparam.h

2011-10-31T23:31:19+00:00

The implicit presence of module.h lured several users into
incorrectly thinking that they only needed/used modparam.h
but once we clean up the module.h presence, these will show
up as build failures, so fix 'em now.

Signed-off-by: Paul Gortmaker