linux-toradex.git/sound/core/seq, branch v4.0

ALSA: seq: potential out of bounds in do_control()

2015-02-12T10:07:48+00:00

Smatch complains that "control" is user specifigy and needs to be
capped.  The call tree to understand this warning is quite long.

snd_seq_write()  <-- get the event from the user
  snd_seq_client_enqueue_event()
    snd_seq_deliver_event()
      deliver_to_subscribers()
        snd_seq_deliver_single_event()
          snd_opl3_oss_event_input()
            snd_midi_process_event()
              do_control()

Signed-off-by: Dan Carpenter 
Signed-off-by: Takashi Iwai

Merge branch 'topic/snd-device' into for-next

2015-02-03T16:57:16+00:00

ALSA: Simplify snd_device_register() variants

2015-02-02T16:01:26+00:00

Now that all callers have been replaced with
snd_device_register_for_dev(), let's drop the obsolete device
registration code and concentrate only on the code handling struct
device directly.  That said,

- remove the old snd_device_register(),
- rename snd_device_register_for_dev() with snd_device_register(),
- drop superfluous arguments from snd_device_register(),
- change snd_unregister_device() to pass the device pointer directly

Reviewed-by: Jaroslav Kysela 
Signed-off-by: Takashi Iwai

ALSA: seq: Handle the device directly

2015-02-02T13:42:45+00:00

Like the previous change for the timer device, this patch changes the
device management for the ALSA sequencer device using the struct
device directly.

Reviewed-by: Jaroslav Kysela 
Signed-off-by: Takashi Iwai

ALSA: seq: remove unused callback_all field

2015-01-26T12:56:58+00:00

Signed-off-by: Clemens Ladisch 
Signed-off-by: Takashi Iwai

ALSA: seq: fix off-by-one error in port limit check

2015-01-26T12:54:47+00:00

Signed-off-by: Clemens Ladisch 
Signed-off-by: Takashi Iwai

ALSA: seq: correctly report maximum number of ports

2015-01-26T12:54:39+00:00

Due to SNDRV_SEQ_ADDRESS_BROADCAST, not all 256 port number values can
be used.

Signed-off-by: Clemens Ladisch 
Signed-off-by: Takashi Iwai

Merge branch 'for-linus' into for-next

2015-01-26T12:53:41+00:00

Sync with the latest 3.19-rc state for applying other ALSA sequencer
core fixes.

ALSA: seq-dummy: remove deadlock-causing events on close

2015-01-26T12:53:13+00:00

When the last subscriber to a "Through" port has been removed, the
subscribed destination ports might still be active, so it would be
wrong to send "all sounds off" and "reset controller" events to them.
The proper place for such a shutdown would be the closing of the actual
MIDI port (and close_substream() in rawmidi.c already can do this).

This also fixes a deadlock when dummy_unuse() tries to send events to
its own port that is already locked because it is being freed.

Reported-by: Peter Billam 
Cc: 
Signed-off-by: Clemens Ladisch 
Signed-off-by: Takashi Iwai

ALSA: seq: Deletion of unnecessary checks before the function call "snd_midi_event_free"

2015-01-04T14:11:05+00:00

The snd_midi_event_free() function tests whether its argument is NULL and then
returns immediately. Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring 
Signed-off-by: Takashi Iwai