linux-toradex.git/sound/core/timer.c, branch v3.0.44

ALSA: timer - Fix Oops at closing slave timer

2011-08-16T01:31:36+00:00

commit 0584ffa548b6e59aceb027112f23a55f0133400e upstream.

A slave-timer instance has no timer reference, and this results in
NULL-dereference at stopping the timer, typically called at closing
the device.

Reference: https://bugzilla.kernel.org/show_bug.cgi?id=40682

Signed-off-by: Takashi Iwai 
Signed-off-by: Greg Kroah-Hartman

ALSA: sound/core: merge list_del()/list_add_tail() to list_move_tail()

2011-03-16T16:35:16+00:00

Merge list_del() + list_add_tail() to list_move_tail().

Signed-off-by: Nicolas Kaiser 
Signed-off-by: Takashi Iwai

ALSA: support module on-demand loading for seq and timer

2010-11-24T04:53:25+00:00

If CONFIG_SND_DYNAMIC_MINORS is used, assign /dev/snd/seq and
/dev/snd/timer the usual static minors, and export specific
module aliases to generate udev module on-demand loading
instructions:

  $ cat /lib/modules/2.6.33.4-smp/modules.devname
  # Device nodes to trigger on-demand module loading.
  microcode cpu/microcode c10:184
  fuse fuse c10:229
  ppp_generic ppp c108:0
  tun net/tun c10:200
  uinput uinput c10:223
  dm_mod mapper/control c10:236
  snd_timer snd/timer c116:33
  snd_seq snd/seq c116:1

The last two lines instruct udev to create device nodes, even
when the modules are not loaded at that time.

As soon as userspace accesses any of these nodes, the in-kernel
module-loader will load the module, and the device can be used.

The header file minor calculation needed to be simplified to
make __stringify() (supports only two indirections) in
the MODULE_ALIAS macro work.

This is part of systemd's effort to get rid of unconditional
module load instructions and needless init scripts.

Cc: Lennart Poettering 
Signed-off-by: Kay Sievers 
Signed-off-by: Clemens Ladisch 
Signed-off-by: Takashi Iwai

ALSA: timer: automatically load the high-resolution timer

2010-11-22T07:14:31+00:00

Increase the default timer limit so that snd-hrtimer.ko can be
automatically loaded when needed, e.g., when used as the default
sequencer timer.  This replaces the check for the obsolete
CONFIG_SND_HPET.

Signed-off-by: Clemens Ladisch 
Signed-off-by: Takashi Iwai

Merge branch 'topic/core-cleanup' into for-linus

2010-05-20T09:58:57+00:00

ALSA: take tu->qlock with irqs disabled

2010-05-05T07:57:08+00:00

We should disable irqs when we take the tu->qlock because it is used in
the irq handler.  The only place that doesn't is
snd_timer_user_ccallback().  Most of the time snd_timer_user_ccallback()
is called with interrupts disabled but the the first ti->ccallback()
call in snd_timer_notify1() has interrupts enabled.

This was caught by lockdep which generates the following message:

> =================================
> [ INFO: inconsistent lock state ]
> 2.6.34-rc5 #5
> ---------------------------------
> inconsistent {HARDIRQ-ON-W} -> {IN-HARDIRQ-W} usage.
> dolphin/4003 [HC1[1]:SC0[0]:HE0:SE1] takes:
> (&(&tu->qlock)->rlock){?.+...}, at: [] snd_timer_user_tinterrupt+0x28/0x132 [snd_timer]
> {HARDIRQ-ON-W} state was registered at:
>   [] __lock_acquire+0x654/0x1482
>   [] lock_acquire+0x5c/0x73
>   [] _raw_spin_lock+0x25/0x34
>   [] snd_timer_user_ccallback+0x55/0x95 [snd_timer]
>   [] snd_timer_notify1+0x53/0xca [snd_timer]

Reported-by: Stefan Richter 
Signed-off-by: Dan Carpenter 
Signed-off-by: Takashi Iwai

ALSA: core - Define llseek fops

2010-04-13T10:01:21+00:00

Set no_llseek to llseek file ops of each sound component (but for hwdep).
This avoids the implicit BKL invocation via generic_file_llseek() used
as default when fops.llseek is NULL.

Also call nonseekable_open() at each open ops to ensure the file flags
have no seek bit.

Signed-off-by: Takashi Iwai

ALSA: timer - pass real event in snd_timer_notify1() to instance callback

2010-03-03T21:39:45+00:00

Do not use hardcoded SNDRV_TIMER_EVENT_START value.

Signed-off-by: Jaroslav Kysela 
Signed-off-by: Takashi Iwai

ALSA: sound/core: use memdup_user()

2009-04-14T10:39:12+00:00

Remove open-coded memdup_user().

Signed-off-by: Li Zefan 
Signed-off-by: Takashi Iwai

Rationalize fasync return values

2009-03-16T14:34:35+00:00

Most fasync implementations do something like:

     return fasync_helper(...);

But fasync_helper() will return a positive value at times - a feature used
in at least one place.  Thus, a number of other drivers do:

     err = fasync_helper(...);
     if (err < 0)
             return err;
     return 0;

In the interests of consistency and more concise code, it makes sense to
map positive return values onto zero where ->fasync() is called.

Cc: Al Viro 
Signed-off-by: Jonathan Corbet